* bug#66456: 30.0.50; erc-server-prevent-duplicates uses list instead of repeat
@ 2023-10-10 23:19 Mauro Aranda
2023-10-10 23:23 ` Mauro Aranda
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-10 23:19 UTC (permalink / raw)
To: 66456
The docstring of erc-server-prevent-duplicates says it can be either nil
or a list of strings (multiple strings). So it looks like
:type '(choice (const nil) (list string))
is not right.
It should be:
:type '(repeat string)
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#66456: 30.0.50; erc-server-prevent-duplicates uses list instead of repeat
2023-10-10 23:19 bug#66456: 30.0.50; erc-server-prevent-duplicates uses list instead of repeat Mauro Aranda
@ 2023-10-10 23:23 ` Mauro Aranda
2023-10-11 2:52 ` J.P.
0 siblings, 1 reply; 3+ messages in thread
From: Mauro Aranda @ 2023-10-10 23:23 UTC (permalink / raw)
To: 66456
[-- Attachment #1: Type: text/plain, Size: 39 bytes --]
tags 66456 patch
quit
Patch attached.
[-- Attachment #2: 0001-Fix-erc-server-prevent-duplicates-type.patch --]
[-- Type: text/x-patch, Size: 994 bytes --]
From 3f8a0ea79ad491ece1344c2f4a82fa4bdad54d2e Mon Sep 17 00:00:00 2001
From: Mauro Aranda <maurooaranda@gmail.com>
Date: Tue, 10 Oct 2023 20:22:06 -0300
Subject: [PATCH] Fix erc-server-prevent-duplicates :type
* lisp/erc/erc-backend.el (erc-server-prevent-duplicates): Change
:type to allow a variable-length list of strings. (Bug#66456)
---
lisp/erc/erc-backend.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/erc/erc-backend.el b/lisp/erc/erc-backend.el
index fb10ee31c78..2fb140f57ce 100644
--- a/lisp/erc/erc-backend.el
+++ b/lisp/erc/erc-backend.el
@@ -511,7 +511,7 @@ erc-server-prevent-duplicates
"Either nil or a list of strings.
Each string is a IRC message type, like PRIVMSG or NOTICE.
All Message types in that list of subjected to duplicate prevention."
- :type '(choice (const nil) (list string)))
+ :type '(repeat string))
(defcustom erc-server-duplicate-timeout 60
"The time allowed in seconds between duplicate messages.
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#66456: 30.0.50; erc-server-prevent-duplicates uses list instead of repeat
2023-10-10 23:23 ` Mauro Aranda
@ 2023-10-11 2:52 ` J.P.
0 siblings, 0 replies; 3+ messages in thread
From: J.P. @ 2023-10-11 2:52 UTC (permalink / raw)
To: Mauro Aranda; +Cc: emacs-erc, 66456-done
Mauro Aranda <maurooaranda@gmail.com> writes:
> tags 66456 patch
> quit
>
>
> Patch attached.
I've installed this as cdf369b0129eb196684dad5d290c076392997770. Thanks
and closing.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-11 2:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-10 23:19 bug#66456: 30.0.50; erc-server-prevent-duplicates uses list instead of repeat Mauro Aranda
2023-10-10 23:23 ` Mauro Aranda
2023-10-11 2:52 ` J.P.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).