unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Glenn Morris <rgm@gnu.org>, 29193@debbugs.gnu.org
Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal
Date: Fri, 18 Dec 2020 04:06:05 +0200	[thread overview]
Message-ID: <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> (raw)
In-Reply-To: <3ewnxgqalm.fsf_-_@fencepost.gnu.org>

On 18.12.2020 01:25, Glenn Morris wrote:
> fda9a2 causes a test failure.
> 
> Ref eg:https://hydra.nixos.org/build/132986117

Thanks! It was a curious bug: one would expect that some highlighting's 
boundaries might change. What changed, however, is one's _type_.

I've pushed a fix, and I'll let the Flymake's maintainer sort out at his 
leisure whether flymake-diag-region can be relied on not to change match 
data, as several of its clients seem to assume.

> (Are people trying to run foo-tests.el before pushing changes to foo.el?)

Some of us are spoiled enough to expect an email from the CI when some 
breakage occurs.

(Sorry.)





  reply	other threads:[~2020-12-18  2:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-07 15:28 bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Dmitry Gutov
2020-12-12 11:39 ` Lars Ingebrigtsen
2020-12-12 23:56   ` Dmitry Gutov
2020-12-13 12:51     ` Lars Ingebrigtsen
2020-12-13 13:19       ` João Távora
2020-12-13 20:55         ` Dmitry Gutov
2020-12-14 11:03           ` João Távora
2020-12-16  0:55             ` Dmitry Gutov
     [not found] ` <handler.29193.D29193.160808016725606.notifdone@debbugs.gnu.org>
2020-12-17 23:25   ` Glenn Morris
2020-12-18  2:06     ` Dmitry Gutov [this message]
2020-12-18 11:42       ` João Távora
2020-12-18 15:22         ` Dmitry Gutov
2020-12-18 15:26           ` João Távora
2020-12-18 15:29             ` Dmitry Gutov
2020-12-18 15:39               ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=29193@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).