From: Dmitry Gutov <dmitry@gutov.dev>
To: Yuan Fu <casouri@gmail.com>, 69625@debbugs.gnu.org
Subject: bug#69625: 30.0.50; [PATCH] rust-ts-mode doesn't fontify some enum
Date: Sat, 9 Mar 2024 00:56:04 +0200 [thread overview]
Message-ID: <085f5fb8-ac4c-45de-80e8-8f60adf54515@gutov.dev> (raw)
In-Reply-To: <CD02B2B2-ACA6-484B-B832-B7F0F3F3B385@gmail.com>
On 08/03/2024 06:43, Yuan Fu wrote:
> The problem is follows: given the rust code below, some enum are not
> fontified with type face under font lock level 3, and those enum are
> fontified as function or variable under font lock level 4.
>
> fn main() {
> func(MyEnum::VariantA(0));
> func(MyEnum::VariantB);
> func(VariantC);
> func(VariantD(0));
> }
>
> VariantA and VariantB are fontified correctly, but VariantC and VariantD
> are not.
>
> I think a simple rule that fontifies every capitalized identifier would
> fix this. But I don’t know if that’ll create other problem. AFAIK
> capitalized identifier is always some type in rust, right?
This might be more of an issue with highlighters order. As you can see,
level 3 fontifies these as 'type' already, and does that because the
identifiers are capitalized.
Some level 4 rules probably either come earlier than where they should
be (thus applying before the ones with the "capitalized" matcher), or
they should use a "not capitalized" matcher if moving them down would
cause other problems.
next prev parent reply other threads:[~2024-03-08 22:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 4:43 bug#69625: 30.0.50; [PATCH] rust-ts-mode doesn't fontify some enum Yuan Fu
2024-03-08 22:56 ` Dmitry Gutov [this message]
2024-03-09 3:50 ` Randy Taylor
2024-03-15 1:52 ` Dmitry Gutov
2024-03-16 1:37 ` Randy Taylor
2024-04-08 7:25 ` Yuan Fu
2024-06-22 11:07 ` Stefan Kangas
2024-06-22 23:17 ` Yuan Fu
2024-06-28 2:40 ` Randy Taylor
2024-06-28 4:43 ` Yuan Fu
2024-06-29 2:37 ` Randy Taylor
2024-06-29 3:03 ` Stefan Kangas
2024-06-29 5:41 ` Yuan Fu
2024-06-29 19:08 ` Randy Taylor
2024-07-06 8:05 ` Eli Zaretskii
2024-07-06 21:10 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=085f5fb8-ac4c-45de-80e8-8f60adf54515@gutov.dev \
--to=dmitry@gutov.dev \
--cc=69625@debbugs.gnu.org \
--cc=casouri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).