From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#26623: 24.5; bad variable name: `inside-post-command-hook' Date: Wed, 26 Apr 2017 06:39:18 -0700 (PDT) Message-ID: <07ad96c0-1fe7-4997-8607-837288075411@default> References: <<88ab0589-09f2-496d-aa02-553ab60d1d58@default>> <<83h91bpw7w.fsf@gnu.org>> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1493214012 1908 195.159.176.226 (26 Apr 2017 13:40:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 26 Apr 2017 13:40:12 +0000 (UTC) Cc: 26623@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 26 15:40:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3NAu-0000OL-3M for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Apr 2017 15:40:08 +0200 Original-Received: from localhost ([::1]:55299 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3NAz-0006Il-To for geb-bug-gnu-emacs@m.gmane.org; Wed, 26 Apr 2017 09:40:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47319) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d3NAu-0006HA-59 for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2017 09:40:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d3NAo-00089L-Jt for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2017 09:40:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42515) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d3NAo-00089E-Fz for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2017 09:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d3NAo-00048v-6k for bug-gnu-emacs@gnu.org; Wed, 26 Apr 2017 09:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Apr 2017 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 26623 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 26623-submit@debbugs.gnu.org id=B26623.149321397615887 (code B ref 26623); Wed, 26 Apr 2017 13:40:02 +0000 Original-Received: (at 26623) by debbugs.gnu.org; 26 Apr 2017 13:39:36 +0000 Original-Received: from localhost ([127.0.0.1]:40714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3NAM-00048A-GZ for submit@debbugs.gnu.org; Wed, 26 Apr 2017 09:39:36 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:46643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d3NAK-00047x-Ol for 26623@debbugs.gnu.org; Wed, 26 Apr 2017 09:39:33 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v3QDdP9j003876 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Apr 2017 13:39:25 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v3QDdLIe005065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 26 Apr 2017 13:39:23 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id v3QDdJNp025594; Wed, 26 Apr 2017 13:39:20 GMT In-Reply-To: <<83h91bpw7w.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6767.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:132016 Archived-At: > > This variable's name should not end in `-hook', because that means, > > by convention, that this is a hook variable, which it is not. >=20 > No, it's the other way around: a hook variable should have its name > end in "-hook", but not every symbol whose name ends in "-hook" is a > hook variable. Clearly nothing _prevents_ a non-hook-variable symbol from having such a perverted name as to suggest that it is a hook variable. But that is not what the convention is for. I don't think you can show documentation to support such a use. This is a perversion, which works against users. Think `apropos' or think completion (assuming substring or regexp matching, both of which are possible now even with vanilla Emacs), to look for or discover hook variables. This particular non-hook variable works against users for this and similar use cases - it simply gives the wrong message, claiming loud and clear that it is a hook variable. And to what end? What possible reason could we have for keeping such a misleading name here? > I think the name of this variable speaks very clearly for its purpose, > and see no reason for such formalism in this case. No, it does not speak clearly for its purpose. Its purpose is to be a Boolean flag for whether execution is currently inside that hook. Simply end the name with `-p' or `?' or some other suffix that suggests that this is a Boolean variable. And more importantly does not suggest that it is a hook variable, which it is not.