* bug#6431: 24.0.50; read-file-name-predicate is never reset
@ 2010-06-15 18:06 Drew Adams
2014-02-10 7:36 ` Lars Ingebrigtsen
0 siblings, 1 reply; 5+ messages in thread
From: Drew Adams @ 2010-06-15 18:06 UTC (permalink / raw)
To: 6431
read-file-name-predicate is declared obsolete in 23.2. But it is still
available and still used.
However, it is no longer bound in `read-file-name', as it was. So if
3rd-party code ever sets it then it stays set instead of being
reinitialized by `read-file-name'.
The binding is missing here, in `read-file-name':
(let ((completion-ignore-case read-file-name-completion-ignore-case)
(minibuffer-completing-file-name t)
(read-file-name-predicate (or predicate 'file-exists-p)) ; MISSING
(add-to-history nil))
In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600)
of 2010-06-14 on 3249CTO
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (4.4) --no-opt --cflags -Ic:/xpm/include'
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#6431: 24.0.50; read-file-name-predicate is never reset
2010-06-15 18:06 bug#6431: 24.0.50; read-file-name-predicate is never reset Drew Adams
@ 2014-02-10 7:36 ` Lars Ingebrigtsen
2014-02-10 18:54 ` Drew Adams
0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2014-02-10 7:36 UTC (permalink / raw)
To: Drew Adams; +Cc: 6431
"Drew Adams" <drew.adams@oracle.com> writes:
> read-file-name-predicate is declared obsolete in 23.2. But it is still
> available and still used.
>
> However, it is no longer bound in `read-file-name', as it was. So if
> 3rd-party code ever sets it then it stays set instead of being
> reinitialized by `read-file-name'.
It no longer seems to be used. Closing.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#6431: 24.0.50; read-file-name-predicate is never reset
2014-02-10 7:36 ` Lars Ingebrigtsen
@ 2014-02-10 18:54 ` Drew Adams
2014-02-10 23:31 ` Bastien
0 siblings, 1 reply; 5+ messages in thread
From: Drew Adams @ 2014-02-10 18:54 UTC (permalink / raw)
To: Lars Ingebrigtsen; +Cc: 6431
> > read-file-name-predicate is declared obsolete in 23.2. But it is
> > still available and still used.
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> > However, it is no longer bound in `read-file-name', as it was. So
> > if 3rd-party code ever sets it then it stays set instead of being
> > reinitialized by `read-file-name'.
>
> It no longer seems to be used. Closing.
It is used - by 3rd-party code. Please restore the binding
cited in the bug report.
^ permalink raw reply [flat|nested] 5+ messages in thread* bug#6431: 24.0.50; read-file-name-predicate is never reset
2014-02-10 18:54 ` Drew Adams
@ 2014-02-10 23:31 ` Bastien
2014-02-10 23:35 ` Drew Adams
0 siblings, 1 reply; 5+ messages in thread
From: Bastien @ 2014-02-10 23:31 UTC (permalink / raw)
To: Drew Adams; +Cc: Lars Ingebrigtsen, 6431
Drew Adams <drew.adams@oracle.com> writes:
>> > read-file-name-predicate is declared obsolete in 23.2. But it is
>> > still available and still used.
> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> > However, it is no longer bound in `read-file-name', as it was. So
>> > if 3rd-party code ever sets it then it stays set instead of being
>> > reinitialized by `read-file-name'.
>>
>> It no longer seems to be used. Closing.
>
> It is used - by 3rd-party code. Please restore the binding
> cited in the bug report.
Changes that are incompatible with third-part code should be
documented in NEWS, not restored.
Can you suggest something for NEWS?
--
Bastien
^ permalink raw reply [flat|nested] 5+ messages in thread
* bug#6431: 24.0.50; read-file-name-predicate is never reset
2014-02-10 23:31 ` Bastien
@ 2014-02-10 23:35 ` Drew Adams
0 siblings, 0 replies; 5+ messages in thread
From: Drew Adams @ 2014-02-10 23:35 UTC (permalink / raw)
To: Bastien; +Cc: Lars Ingebrigtsen, 6431
> > It is used - by 3rd-party code. Please restore the binding
> > cited in the bug report.
>
> Changes that are incompatible with third-part code should be
> documented in NEWS, not restored.
>
> Can you suggest something for NEWS?
My suggestion is to restore the binding. That will fix this
bug.
If you want to file a bug report about something being missing
from NEWS, please go for it.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-10 23:35 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-15 18:06 bug#6431: 24.0.50; read-file-name-predicate is never reset Drew Adams
2014-02-10 7:36 ` Lars Ingebrigtsen
2014-02-10 18:54 ` Drew Adams
2014-02-10 23:31 ` Bastien
2014-02-10 23:35 ` Drew Adams
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).