From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#52237: 29.0.50; [PATCH] Doubled separators in context-menu-mode Date: Thu, 2 Dec 2021 10:47:06 -0800 Message-ID: <07494cfd-0608-acb9-2839-e7ecbef4610c@gmail.com> References: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5088"; mail-complaints-to="usenet@ciao.gmane.io" To: 52237@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 02 19:48:33 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msr8D-00017C-8h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Dec 2021 19:48:33 +0100 Original-Received: from localhost ([::1]:46004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msr8B-0006gW-CQ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 02 Dec 2021 13:48:31 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:38184) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msr7i-0006fF-Pi for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 13:48:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1msr7h-0005II-Kp for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 13:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1msr7h-0004Nb-JI for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2021 13:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2021 18:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 52237-submit@debbugs.gnu.org id=B52237.163847083616639 (code B ref 52237); Thu, 02 Dec 2021 18:48:01 +0000 Original-Received: (at 52237) by debbugs.gnu.org; 2 Dec 2021 18:47:16 +0000 Original-Received: from localhost ([127.0.0.1]:49249 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msr6y-0004KJ-LN for submit@debbugs.gnu.org; Thu, 02 Dec 2021 13:47:16 -0500 Original-Received: from mail-pg1-f169.google.com ([209.85.215.169]:36388) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1msr6v-0004K4-U0 for 52237@debbugs.gnu.org; Thu, 02 Dec 2021 13:47:14 -0500 Original-Received: by mail-pg1-f169.google.com with SMTP id 137so650521pgg.3 for <52237@debbugs.gnu.org>; Thu, 02 Dec 2021 10:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:references:message-id:date:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=YgxWvmXIomXjsuvKq/+JVRvMKQEX9m9O3W9N/vHqKeo=; b=XvVoGT9blFPacs5iDmezEnFD41AiBO7VEYLdrSyolmkAi7hRKSc/3P/h9N7Mimu2/p O3vRconGOFdc0d2viYV+CxhWz9+sJP+VU0d329HGf4g8ucOO0gkYXkLvupuZuxCd+mxk oMPnNuDHcil1WxbndC1o2fD+WNA/u7LFCftY1/k4AH+yRBMhwlb6irVax1V0VnL/uwyr jtmdlR+NWzSvRrF3yLnQWznSK8UJ4TSqkgi7oxZJv6ZT9ihZueYcadt+CV/Cz0HcMpJ+ wzkZ6qreTcyqd4Rg6ua3zBEr0YIgT65UdTnO+ZDkpyQLp+NwdGfJpbCOA/tmZNc78dSz 3ovw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=YgxWvmXIomXjsuvKq/+JVRvMKQEX9m9O3W9N/vHqKeo=; b=BQXxofKN7+H85sFHm8WiKAXWcN/+6GzObuVEJr8J1iEEBqDpY4K604FafpAcfMFa+A ZvfDdY+ZTy2LYn5ZIYjKPeYaRhQw2tdBG9R888qtS0aNP14V51OOqG2GdplK4f9ZmstR KL1QU0Rz2tfedAC7wZFpycjRTHcPVs7+MIa+A0/u7GFY6Cxf44zE6w59C5lMdZ7EL9Gb XVOki1+nYa8SSSZzMPMaTQ8An0v+uN7nu5Nthvxiya+kYXrFizP9HIO6ISTsH2blGJX9 XkKdr7DJ4SAfad4VzvZa0kScEojtsT/+yiWUe+gAemNGakClnQdBQGb+HyYuZ2KrP/pz 23RA== X-Gm-Message-State: AOAM531/rbwblBqeOKkpCgMwsiFeKEZhCAkRm7hkn0DougDvIB9AKyeX 92wLrZBsekv4Z6h7kGucsSz7jH31dNI= X-Google-Smtp-Source: ABdhPJxPhaTqA0siApT0TDLnC4wZZ1IidxFSVp6POiPhiAkWd7nuvyn9RBaSOYKP7rMN3x+0aIP1Sw== X-Received: by 2002:a63:481d:: with SMTP id v29mr732641pga.209.1638470827963; Thu, 02 Dec 2021 10:47:07 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id o9sm347400pgu.12.2021.12.02.10.47.06 for <52237@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Dec 2021 10:47:07 -0800 (PST) In-Reply-To: <0bbe5580-8e05-4e18-5b91-04b41b6f19bc@gmail.com> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:221340 Archived-At: On 12/1/2021 10:06 PM, Jim Porter wrote: > Sometimes, menu separators are doubled up in context-menu-mode. I found another odd case, but I'm not 100% sure the best way to fix it: emacs -Q --eval '(context-menu-mode)' C-h o identity RET ;; Right-click somewhere in the Help buffer There's a doubled separator after "Next Topic". Looking at the code, this is because `help-mode-context-menu' inserts new items using `define-key', which has the effect of putting the new items *before* the (hidden) menu title. The resulting keymap ends up looking like this: (keymap (Previous\ Topic ...) (Next\ Topic ...) (help-mode-separator "--") #("Context Menu" 0 12 (hide t)) (separator-undo "--") ...) Since there's a hidden item (the keymap title) between the `help-mode-separator' and `separator-undo'[1], the de-duplication doesn't handle that. Is there a standard/common way of defining a key such that it goes immediately *after* the keymap's title? I guess we could add `context-menu-top-separator' as an anchor (by analogy to `context-menu-middle-separator'), but maybe there's a simpler way... [1] As an aside, is there a standard naming convention to use here? Should "separator" go at the beginning of the name or the end?