From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#30938: 27.0; `dired-do-create-files' etc.: do NOT always raise error if no files Date: Thu, 29 Mar 2018 21:01:49 -0700 (PDT) Message-ID: <073d8109-fb1e-44c0-9565-fed5e8a59257@default> References: <7ea429b5-b12e-4639-9d77-11db71504d9c@default> <87605g7xpj.fsf@mail.linkov.net> <70149736-0c90-4059-91d0-155144bf4abd@default> <87o9j6k5qx.fsf@mail.linkov.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1522382416 28937 195.159.176.226 (30 Mar 2018 04:00:16 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 30 Mar 2018 04:00:16 +0000 (UTC) Cc: 30938@debbugs.gnu.org To: Noam Postavsky , Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 30 06:00:12 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1lD1-0007QZ-Lg for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Mar 2018 06:00:11 +0200 Original-Received: from localhost ([::1]:56989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1lF5-0006Um-1E for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Mar 2018 00:02:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1f1lEs-0006Ti-S0 for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 00:02:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1f1lEp-0005MJ-MO for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 00:02:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1f1lEp-0005MC-Ji for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 00:02:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1f1lEp-0001H5-9F for bug-gnu-emacs@gnu.org; Fri, 30 Mar 2018 00:02:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Mar 2018 04:02:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30938 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30938-submit@debbugs.gnu.org id=B30938.15223825224895 (code B ref 30938); Fri, 30 Mar 2018 04:02:03 +0000 Original-Received: (at 30938) by debbugs.gnu.org; 30 Mar 2018 04:02:02 +0000 Original-Received: from localhost ([127.0.0.1]:59246 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1lEo-0001Gp-9Z for submit@debbugs.gnu.org; Fri, 30 Mar 2018 00:02:02 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:49544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f1lEl-0001GN-Tr for 30938@debbugs.gnu.org; Fri, 30 Mar 2018 00:02:00 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w2U3xcCg149235; Fri, 30 Mar 2018 04:01:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=1nXG5ZsKpLzqaetjFCL7WhdLDK78kYXqdiG9kfuPCwQ=; b=ha81+fT9/qDpM2sd0Zb2O6QYIzid6xZ8vamoEqa/INFBt8IRY2UFFO7a/FApyBBOf96N z8znIx+DmN0ldY6GyPf4semsIL36dF/2O5s0E6m99Ovc1xBKE6Dp13njbdGdgEnsElt5 xwu6WD2YJqqaYSexNOtYYSSf49Dhxj4zABB//Xw560mI07ZfzCm+wdewIDC3MASX+Mx8 vrTz6CIDHB2wzVADyLqt0bq6AUWJSg3sDzolpT09Op1KVqqIIJAb6YtTzyJeXXdnsnvd 4BEVEp/zyl6jsluVrxkMn6GehLdaJmKK3iNQZXogDAG+cF5C3EI8BzvxxB6ZotpQUjMU 7w== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp2120.oracle.com with ESMTP id 2h1dtq804j-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Mar 2018 04:01:52 +0000 Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w2U41oVl001245 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 30 Mar 2018 04:01:51 GMT Original-Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w2U41oIl011287; Fri, 30 Mar 2018 04:01:50 GMT In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4666.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8847 signatures=668697 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=549 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803300029 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144712 Archived-At: > > Don't you see there is something wrong in adding the same INTERACTIVEP > > arg to all these 13 commands and possibly to more 15 other commands? >=20 > The parameter should be named THROW-ERROR-P, then it's clear that > there is nothing wrong with it, all commands just happen to share this > interface feature: they may throw error, or not. > (and they can still work correctly if called non-interactively from > some other interactive command) Actually, as you can see from the change log I cited, I call the optional arg for `dired-get-marked-files' ERROR-IF-NONE-P (which is better than THROW-ERROR-P, which doesn't say what the error is about). That's precisely what that optional arg means for `dired-get-marked-files'. And it will only ever mean that, no doubt. However, for the individual commands that call that function, the arg can be called either that or just INTERACTIVEP. Yes, it is the case _currently_ that in those commands distinguishing the interactive case is used only in the call to `dired-get-marked-files', i.e., only to make it raise the corner-case error, so far. So I'm OK with calling the arg ERROR-IF-NONE-P there also. I'm also OK with calling it INTERACTIVEP there. In neither place should it be called THROW-ERROR-P, IMO. But as long as the problem gets fixed I don't really care much about the parameter name.