From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#24676: 25.1; `completion-pcm-all-completions' should not reverse order of candidates Date: Tue, 18 Oct 2016 06:56:34 -0700 (PDT) Message-ID: <06e9ce6f-685c-475b-a431-c6d902d6b74d@default> References: <39f09e8d-8381-4176-917e-35cf12a9ae90@default> <871szers91.fsf@web.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1476801386 31747 195.159.176.226 (18 Oct 2016 14:36:26 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2016 14:36:26 +0000 (UTC) Cc: 24676@debbugs.gnu.org To: Michael Heerdegen , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 18 16:36:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwVUk-00054M-7y for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 16:35:58 +0200 Original-Received: from localhost ([::1]:41938 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwVUm-0004cz-C6 for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2016 10:36:00 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bwUt7-0004Nj-Jl for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 09:57:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bwUt4-0006iY-Hd for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 09:57:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60237) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1bwUt4-0006iK-Eh for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 09:57:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bwUt3-00018Q-Vq for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2016 09:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2016 13:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 24676 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 24676-submit@debbugs.gnu.org id=B24676.14767990074342 (code B ref 24676); Tue, 18 Oct 2016 13:57:01 +0000 Original-Received: (at 24676) by debbugs.gnu.org; 18 Oct 2016 13:56:47 +0000 Original-Received: from localhost ([127.0.0.1]:38194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwUsp-00017y-8l for submit@debbugs.gnu.org; Tue, 18 Oct 2016 09:56:47 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:23490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bwUsn-00017l-SH for 24676@debbugs.gnu.org; Tue, 18 Oct 2016 09:56:46 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u9IDudZV003322 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Oct 2016 13:56:40 GMT Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id u9IDucjM023142 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 18 Oct 2016 13:56:39 GMT Original-Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u9IDuZXP022901; Tue, 18 Oct 2016 13:56:36 GMT In-Reply-To: <871szers91.fsf@web.de> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6753.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:124629 Archived-At: > > > (let ((poss ())) > > > (dolist (c compl) > > > (when (string-match-p regex c) (push c poss))) > > > (nreverse poss)) > > > > Looks good, please install, >=20 > This doesn't seem to meet any of the criteria in > http://lists.gnu.org/archive/html/emacs-devel/2016-10/msg00007.html > so I think I'll have to commit to master. Thanks for fixing this, Michael. Unfortunately, there is no way for my code that compensates for this bug to= now know whether/when it has been fixed. No simple test such as `fboundp'= or an Emacs version. Of course, if you happened to decide to rename the function, there would be= no problem... And it's already a bit much that there is also a function `completion-pcm-a= ll-completions' that does not even call `completion-pcm--all-completions', = and that has a completely different signature. And the "internal" function= has a nice doc string, but the "external" one has no doc string... Perhaps you would consider taking this opportunity to find a better name fo= r this "internal" function? Especially since it is "internal", probably fe= w 3rd-party libraries would be affected by a name change. In my case, I would not be referencing this "internal" function at all, exc= ept that I needed to work around this bug. If you did choose to rename it,= I would not need to make any code changes, because I already protect this = change with `(when (fboundp 'completion-pcm--all-completions)...)'.