bug#60987: 30.0.50; Calendar not accepting custom holidays

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 9204 bytes --]

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Eli Zaretskii]

> Date: Sat, 21 Jan 2023 15:00:09 +0100
> From: "Emanuele M. Monterosso" <emanuele.monterosso@gmail.com>
> 
> I've found the current issue with my build of emacs:
> I set the variables holiday-general-holidays and
> holiday-christian-holidays using the Localized snippets found
> in the Emacswiki page, they appear if I do:
>  
> M-x holiday-list RET RET RET General/Christian
>  
> But they don't appear at all on the calendar and if I choose
> All from holiday-list menu they also do not appear. Am I doing something
> wrong?

Please show step by step instructions to reproduce the issue starting
from "emacs -Q".  It is hard to look into an issue without such a
recipe, as the details are usually important.

Thanks.

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Eli Zaretskii]

[Please keep the bug address on the CC list.]

> Date: Sat, 21 Jan 2023 15:53:49 +0100
> From: "Emanuele M. Monterosso" <emanuele.monterosso@gmail.com>
> 
> >Please show step by step instructions to reproduce the issue starting
> >from "emacs -Q".  It is hard to look into an issue without such a
> >recipe, as the details are usually important.
> >
>  
> >Thanks.
>  
> Steps to reproduce:
> 
> * emacs -Q -> scratch-buffer
> * Copy this snippet from the EmacsWiki 
> 
> (setq holiday-general-holidays
>       '((holiday-fixed 1 1 "Capodanno")
>         (holiday-fixed 5 1 "1 Maggio")
>         (holiday-fixed 4 25 "Liberazione")
>         (holiday-fixed 6 2 "Festa Repubblica")
> ))
>  
> * C-x C-e to eval the snippet
> * Either open the calendar or M-x holiday-list RET RET RET All and they do not appear at all. However,
> 
> they do appear if you do M-x holiday-list RET RET RET General.

For me they appear both with "All" and with "General" if I invoke
holiday-list.

Also, I don't have commit 8aae5fbaf29ee3d845e2bb40ef728765a2246e35 in
my clone of the Emacs Git repository.  Which Git repository are you
using to build Emacs?

bug#60987: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 6777 bytes --]

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Eli Zaretskii]

> Date: Sat, 21 Jan 2023 17:04:12 +0100
> From: "Emanuele M. Monterosso" <emanuele.monterosso@gmail.com>
> Cc: "60987@debbugs.gnu.org" <60987@debbugs.gnu.org>
> 
> Is there an official build of emacs for windows with native-comp enabled?

I think the one on the GNU FTP site is such a build:

  https://ftp.gnu.org/gnu/emacs/windows/emacs-28/

bug#60987: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 1926 bytes --]

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Eli Zaretskii]

> Date: Sun, 22 Jan 2023 15:59:57 +0100
> From: "Emanuele M. Monterosso" <emanuele.monterosso@gmail.com>
> Cc: "60987@debbugs.gnu.org" <60987@debbugs.gnu.org>
> 
> runemacs.exe -Q
> 
> (native-comp-available-p) and C-x C-e returns nil

Do you have libgccjit installed and GCC and Binutils on PATH?

bug#60987: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 6136 bytes --]

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Eli Zaretskii]

> Date: Sun, 22 Jan 2023 16:26:46 +0100
> From: "Emanuele M. Monterosso" <emanuele.monterosso@gmail.com>
> Cc: "60987@debbugs.gnu.org" <60987@debbugs.gnu.org>
> 
> On the other hand I confirm this bug still happens under WSL Ubuntu for emacs30 but not for emacs 28.2,
> haven’t tried emacs29 and my config depends on some things 
> 
> and features in emacs29, gonna wait until pretest I guess. 

Like I said: I cannot reproduce this on Emacs 30 or 29, so I'm not
sure what's going on.  Maybe something related to your locale?

Other than that, I can only suggest debugging the code with Edebug.

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Eli Zaretskii]

> Date: Sun, 22 Jan 2023 16:26:46 +0100
> From: "Emanuele M. Monterosso" <emanuele.monterosso@gmail.com>
> Cc: "60987@debbugs.gnu.org" <60987@debbugs.gnu.org>
> 
> On the other hand I confirm this bug still happens under WSL Ubuntu for emacs30 but not for emacs 28.2,
> haven’t tried emacs29 and my config depends on some things 
> 
> and features in emacs29, gonna wait until pretest I guess. 

Maybe it's a problem with the Emacs 30 build you used?  It isn't a
build from the Emacs repository, so perhaps it has some changes that
cause this?

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Eli Zaretskii]

> Date: Sun, 22 Jan 2023 18:04:27 +0100
> From: "Emanuele M. Monterosso" <emanuele.monterosso@gmail.com>
> 
> >Maybe it's a problem with the Emacs 30 build you used?  It isn't a
> >build from the Emacs repository, so perhaps it has some changes that
> >cause this?
> 
> It could be, but it also did happen in WSL (tho I can’t use emacs from there due to work policies) emacs
> build
> 
> From the Ubuntu Emacs Lisp ppa https://launchpad.net/~ubuntu-elisp/+archive/ubuntu/ppa.

Can someone else please reproduce this and investigate?

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Michael Heerdegen]

Eli Zaretskii <eliz@gnu.org> writes:

> > (setq holiday-general-holidays
> >       '((holiday-fixed 1 1 "Capodanno")
> >         (holiday-fixed 5 1 "1 Maggio")
> >         (holiday-fixed 4 25 "Liberazione")
> >         (holiday-fixed 6 2 "Festa Repubblica")
> > ))
> >
> > * C-x C-e to eval the snippet
> > * Either open the calendar or M-x holiday-list RET RET RET All and
> > they do not appear at all. However,
> >
> > they do appear if you do M-x holiday-list RET RET RET General.
>
> For me they appear both with "All" and with "General" if I invoke
> holiday-list.

I too can't reproduce the issue in emacs -Q.

But this all looks like the difference in behavior one would expect
between an emacs where "holidays.el" is already loaded vs. is not
already loaded:

#+begin_src emacs-lisp
;; (require 'holidays) ; try with and without

(setq holiday-general-holidays
      '((holiday-fixed 1 1 "Capodanno")
        (holiday-fixed 5 1 "1 Maggio")
        (holiday-fixed 4 25 "Liberazione")
        (holiday-fixed 6 2 "Festa Repubblica")))
#+end_src


Michael.

bug#60987: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 3143 bytes --]

bug#60987: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Michael Heerdegen]

"Emanuele M. Monterosso" <emanuele.monterosso@gmail.com> writes:

> And nothing, I still get the non localized ones. Tried with emacs -Q
> and evaluated the forms (both with and without require), still
> nothing.

What does evaluating

  (featurep 'holidays)

and

  calendar-holidays

in a fresh emacs -Q (where it doesn't work) return (before setting or
evaluating anything else)?


TIA,

Michael.

bug#60987: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 2417 bytes --]

bug#60987: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Michael Heerdegen]

"Emanuele M. Monterosso" <emanuele.monterosso@gmail.com> writes:

> > (featurep 'holidays)

> In my emacs this evaluates to t, while it’s nil under emacs -Q

This is like it should be.


> >  calendar-holidays
>
> This is more interesting, under emacs -Q, with holidays evaluating to
> nil [...]

What evals to nil - `calendar-holidays'?

Michael.

bug#60987: R: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 1495 bytes --]

bug#60987: R: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Michael Heerdegen]

"Emanuele M. Monterosso" <emanuele.monterosso@gmail.com> writes:

> (featurep ‘holidays) 
>
> Evaluates to nil, and when I do calendar-list-holidays the error I
> wrote in my previouse message appear for every single default holiday

But what I wanted to know was the evaluation result of
`calendar-holidays' in your emacs -Q.

Michael.

bug#60987: R: R: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 1410 bytes --]

bug#60987: R: R: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Michael Heerdegen]

"Emanuele M. Monterosso" <emanuele.monterosso@gmail.com> writes:

> >But what I wanted to know was the evaluation result of
>
> >`calendar-holidays' in your emacs -Q.
>
> Debugger entered--Lisp error: (void-function calendar-holidays)

No, not (calendar-holidays), calendar-holidays please.

Michael.

bug#60987: R: bug#60987: R: R: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 1511 bytes --]

bug#60987: R: bug#60987: R: R: R: R: bug#60987: 30.0.50; Calendar not accepting custom holidays

[Michael Heerdegen]

"Emanuele M. Monterosso" <emanuele.monterosso@gmail.com> writes:

> Like M-x calendar-holidays?

No:

emacs -Q
M-: calendar-holidays RET


TIA,

Michael.

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Emanuele M. Monterosso]

[-- Attachment #1: Type: text/html, Size: 2975 bytes --]

bug#60987: 30.0.50; Calendar not accepting custom holidays

[Michael Heerdegen]

"Emanuele M. Monterosso" <emanuele.monterosso@gmail.com> writes:

> Debugger entered--Lisp error: (void-variable calendar-holidays)

Thanks.  This is also as expected.  So I don't have any idea why you are
seeing this.

In the meantime I tried your recipe in a build with native compilation
enabled, but I still can't reproduce it.

Michael.