From: martin rudalics <rudalics@gmx.at>
To: Lars Ingebrigtsen <larsi@gnus.org>,
"Charles A. Roelli" <charles@aurox.ch>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, 26513@debbugs.gnu.org
Subject: bug#26513: 25.2; pop-up-frames and *Completions* buffer
Date: Thu, 17 Feb 2022 11:01:50 +0100 [thread overview]
Message-ID: <066f0fac-2ce9-fe9a-355f-e148953fc6f0@gmx.at> (raw)
In-Reply-To: <877d9wpg9z.fsf@gnus.org>
[-- Attachment #1: Type: text/plain, Size: 826 bytes --]
>> >From emacs -Q:
>>
>> M-x set-variable RET pop-up-frames RET t RET
>> M-x global- TAB
>>
>> The *Completions* buffer is opened in a new frame, but the cursor is in
>> the frame too, so the user has to switch back to the minibuffer to
>> continue typing.
>
> This problem is still present in Emacs 29. I guess the general solution
> here would be for completion to ensure that it's gotten focus back again
> after displaying the *Completions* buffer?
Maybe Stefan Monnier can tell us what he does in such case.
I can offer the attached, largely untested patch. A possible
customization would then be
(customize-set-variable
'display-buffer-alist
'(("*Completions*"
(display-buffer-reuse-window
display-buffer-pop-up-frame)
(reusable-frames . t)
(redirect-frame-focus . t))))
martin
[-- Attachment #2: redirect-frame-focus.diff --]
[-- Type: text/x-patch, Size: 6922 bytes --]
diff --git a/lisp/window.el b/lisp/window.el
index 582600e1c6..96aa2ecc2d 100644
--- a/lisp/window.el
+++ b/lisp/window.el
@@ -7598,6 +7598,9 @@ display-buffer
Possible values are nil (the selected frame), t (any live
frame), visible (any visible frame), 0 (any visible or
iconified frame) or an existing live frame.
+ `redirect-frame-focus' -- The value t means to redirect focus
+ from the frame used for display to the frame selected at the
+ time `display-buffer' was called (if these are different).
`pop-up-frame-parameters' -- The value specifies an alist of
frame parameters to give a new frame, if one is created.
`window-height' -- The value specifies the desired height of the
@@ -7740,6 +7743,7 @@ display-buffer-use-some-frame
(lambda (frame)
(and (not (eq frame (selected-frame)))
(get-lru-window frame)))))
+ (selected-frame (selected-frame))
(frame (car (filtered-frame-list predicate)))
(window
(and frame
@@ -7749,7 +7753,10 @@ display-buffer-use-some-frame
(prog1
(window--display-buffer buffer window 'reuse alist)
(unless (cdr (assq 'inhibit-switch-frame alist))
- (window--maybe-raise-frame frame))))))
+ (window--maybe-raise-frame frame))
+ (when (and (cdr (assq 'redirect-frame-focus alist))
+ (not (eq frame selected-frame)))
+ (redirect-frame-focus frame selected-frame))))))
(defun display-buffer-same-window (buffer alist)
"Display BUFFER in the selected window.
@@ -7817,6 +7824,7 @@ display-buffer-reuse-window
called only by `display-buffer' or a function directly or
indirectly called by the latter."
(let* ((alist-entry (assq 'reusable-frames alist))
+ (selected-frame (selected-frame))
(frames (cond (alist-entry (cdr alist-entry))
((if (eq pop-up-frames 'graphic-only)
(display-graphic-p)
@@ -7845,7 +7853,11 @@ display-buffer-reuse-window
(when (window-live-p window)
(prog1 (window--display-buffer buffer window 'reuse alist)
(unless (cdr (assq 'inhibit-switch-frame alist))
- (window--maybe-raise-frame (window-frame window)))))))
+ (window--maybe-raise-frame (window-frame window)))
+ (when (and (cdr (assq 'redirect-frame-focus alist))
+ (not (eq (window-frame window) selected-frame)))
+ (redirect-frame-focus
+ (window-frame window) selected-frame))))))
(defun display-buffer-reuse-mode-window (buffer alist)
"Return a window based on the mode of the buffer it displays.
@@ -7918,7 +7930,11 @@ display-buffer-reuse-mode-window
(when (window-live-p window)
(prog1 (window--display-buffer buffer window 'reuse alist)
(unless (cdr (assq 'inhibit-switch-frame alist))
- (window--maybe-raise-frame (window-frame window)))))))))
+ (window--maybe-raise-frame (window-frame window)))
+ (when (and (cdr (assq 'redirect-frame-focus alist))
+ (not (eq (window-frame window) curframe)))
+ (redirect-frame-focus
+ (window-frame window) curframe))))))))
(defun display-buffer--special-action (buffer)
"Return special display action for BUFFER, if any.
@@ -7955,6 +7971,7 @@ display-buffer-pop-up-frame
(let* ((params (cdr (assq 'pop-up-frame-parameters alist)))
(pop-up-frame-alist (append params pop-up-frame-alist))
(fun pop-up-frame-function)
+ (selected-frame (selected-frame))
frame window)
(when (and fun
;; Make BUFFER current so `make-frame' will use it as the
@@ -7963,8 +7980,11 @@ display-buffer-pop-up-frame
(setq frame (funcall fun)))
(setq window (frame-selected-window frame)))
(prog1 (window--display-buffer buffer window 'frame alist)
- (unless (cdr (assq 'inhibit-switch-frame alist))
- (window--maybe-raise-frame frame))))))
+ (unless (cdr (assq 'inhibit-switch-frame alist))
+ (window--maybe-raise-frame frame))
+ (when (and (cdr (assq 'redirect-frame-focus alist))
+ (not (eq frame selected-frame)))
+ (redirect-frame-focus frame selected-frame))))))
(defun display-buffer-pop-up-window (buffer alist)
"Display BUFFER by popping up a new window.
@@ -7986,7 +8006,8 @@ display-buffer-pop-up-window
indirectly called by the latter."
(let ((frame (or (window--frame-usable-p (selected-frame))
(window--frame-usable-p (last-nonminibuffer-frame))))
- window)
+ (selected-frame (selected-frame))
+ window)
(when (and (or (not (frame-parameter frame 'unsplittable))
;; If the selected frame cannot be split, look at
;; `last-nonminibuffer-frame'.
@@ -8002,7 +8023,10 @@ display-buffer-pop-up-window
(prog1 (window--display-buffer buffer window 'window alist)
(unless (cdr (assq 'inhibit-switch-frame alist))
- (window--maybe-raise-frame (window-frame window)))))))
+ (window--maybe-raise-frame (window-frame window)))
+ (when (and (cdr (assq 'redirect-frame-focus alist))
+ (not (eq frame selected-frame)))
+ (redirect-frame-focus frame selected-frame))))))
(defun display-buffer--maybe-pop-up-frame-or-window (buffer alist)
"Try displaying BUFFER based on `pop-up-frames' or `pop-up-windows'.
@@ -8086,7 +8110,9 @@ display-buffer-in-child-frame
(prog1 (window--display-buffer buffer window type alist)
(unless (cdr (assq 'inhibit-switch-frame alist))
- (window--maybe-raise-frame frame)))))
+ (window--maybe-raise-frame frame))
+ (when (cdr (assq 'redirect-frame-focus alist))
+ (redirect-frame-focus frame parent)))))
(defun windows-sharing-edge (&optional window edge within)
"Return list of live windows sharing the same edge with WINDOW.
@@ -8456,7 +8482,8 @@ display-buffer-use-some-window
(let* ((not-this-window (cdr (assq 'inhibit-same-window alist)))
(frame (or (window--frame-usable-p (selected-frame))
(window--frame-usable-p (last-nonminibuffer-frame))))
- (window
+ (selected-frame (selected-frame))
+ (window
;; Reuse an existing window.
(or (get-lru-window frame nil not-this-window)
(let ((window (get-buffer-window buffer 'visible)))
@@ -8486,7 +8513,11 @@ display-buffer-use-some-window
(window--display-buffer buffer window 'reuse alist)
(window--even-window-sizes window)
(unless (cdr (assq 'inhibit-switch-frame alist))
- (window--maybe-raise-frame (window-frame window)))))))
+ (window--maybe-raise-frame (window-frame window)))
+ (when (and (cdr (assq 'redirect-frame-focus alist))
+ (not (eq (window-frame window) selected-frame)))
+ (redirect-frame-focus
+ (window-frame window) selected-frame))))))
(defun display-buffer-no-window (_buffer alist)
"Display BUFFER in no window.
next prev parent reply other threads:[~2022-02-17 10:01 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 9:17 bug#26513: 25.2; pop-up-frames and *Completions* buffer Charles A. Roelli
2017-04-15 14:50 ` martin rudalics
2017-04-15 19:14 ` Charles A. Roelli
2017-04-15 19:40 ` martin rudalics
2017-04-15 20:28 ` Charles A. Roelli
2017-04-16 7:16 ` martin rudalics
2017-04-17 7:44 ` Charles A. Roelli
2017-04-15 16:49 ` Drew Adams
2017-04-15 20:05 ` Charles A. Roelli
2017-04-16 15:54 ` Drew Adams
2017-04-18 17:27 ` martin rudalics
2017-04-18 20:34 ` Charles A. Roelli
2017-04-19 7:26 ` martin rudalics
2022-02-15 10:37 ` Lars Ingebrigtsen
2022-02-17 10:01 ` martin rudalics [this message]
2022-02-17 13:13 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-17 16:02 ` martin rudalics
2022-02-17 19:21 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-02-19 9:40 ` martin rudalics
2022-02-19 12:23 ` Eli Zaretskii
2022-02-20 0:25 ` bug#26513: [External] : " Drew Adams
2022-02-20 0:28 ` Drew Adams
2022-02-20 9:17 ` martin rudalics
2022-02-20 21:16 ` Drew Adams
2022-02-21 16:25 ` Drew Adams
2022-02-17 16:40 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=066f0fac-2ce9-fe9a-355f-e148953fc6f0@gmx.at \
--to=rudalics@gmx.at \
--cc=26513@debbugs.gnu.org \
--cc=charles@aurox.ch \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).