unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: 33871@debbugs.gnu.org
Subject: bug#33871: 27.0.50; Revert Dired window saved in window configuration
Date: Tue, 9 Apr 2024 11:05:08 +0200	[thread overview]
Message-ID: <05efdf36-b474-430c-b22b-b05a8256579e@gmx.at> (raw)
In-Reply-To: <868r1nhw6l.fsf@mail.linkov.net>

 > With 'with-selected-window' the code was so simple: just one call
 > 'with-selected-window' and no special handling needed.  But
 > without 'with-selected-window' the code became more complicated
 > and error-prone.  I just found another place that needed to use
 > the window's buffer, and fixed it.  I don't know maybe
 > 'with-selected-window' was not too bad?  Or it has other problems?

In my experience 'with-selected-window' is bad because any functions its
body calls cannot tell whether the selected window is the "real selected
window" and its buffer the "real current buffer" at that time.  A
typical example is 'mode-line-format': users who wanted to paint the
mode line of the selected window in some special way could not do that
because they could not tell whether that window was the real selected
one.  If such issues are of no concern, use 'with-selected-window'.

martin





      reply	other threads:[~2024-04-09  9:05 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-25 21:39 bug#33871: 27.0.50; Revert Dired window saved in window configuration Juri Linkov
2018-12-26  9:43 ` martin rudalics
2018-12-27  0:01   ` Juri Linkov
2018-12-27  9:37     ` martin rudalics
2018-12-27 21:34       ` Juri Linkov
2018-12-28  8:34         ` martin rudalics
2018-12-29 11:19           ` Markus Triska
2018-12-29 18:18             ` martin rudalics
2018-12-29 23:21           ` Juri Linkov
2018-12-30  9:52             ` martin rudalics
2018-12-30 14:57               ` martin rudalics
2018-12-30 21:29               ` Juri Linkov
2022-02-12  8:45 ` Lars Ingebrigtsen
2022-02-13 18:40   ` Juri Linkov
2022-02-14  9:13     ` martin rudalics
2022-02-14 18:10       ` Juri Linkov
2022-02-14 18:36         ` martin rudalics
2022-02-15 19:30           ` Juri Linkov
2022-02-16  8:50             ` martin rudalics
2022-02-16 18:34               ` Juri Linkov
2022-02-17 10:05                 ` martin rudalics
2022-02-17 17:28                   ` Juri Linkov
2022-02-19  9:37                     ` martin rudalics
2022-02-19 17:08                       ` Juri Linkov
2022-02-19 17:22                         ` martin rudalics
2022-02-20 18:40                           ` Juri Linkov
2022-02-21  9:07                             ` martin rudalics
2022-02-22 17:14                               ` Juri Linkov
2022-02-23  9:31                                 ` martin rudalics
2022-02-23 17:53                                   ` Juri Linkov
2022-02-24  9:19                                     ` martin rudalics
2024-02-16  7:37                                       ` Juri Linkov
2024-02-16  9:41                                         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-18  7:39                                           ` Juri Linkov
2024-02-19  9:42                                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-20  7:45                                               ` Juri Linkov
2024-02-21  9:05                                                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-21 17:18                                                   ` Juri Linkov
2024-03-20 17:27                                                   ` Juri Linkov
2024-03-21  9:20                                                     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-21 17:54                                                       ` Juri Linkov
2024-03-22  9:26                                                         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-22 16:15                                                           ` Juri Linkov
2024-03-23  9:14                                                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-23 18:31                                                               ` Juri Linkov
2024-03-24  9:54                                                                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-24 17:12                                                                   ` Juri Linkov
2024-03-25  9:41                                                                     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-25 17:10                                                                       ` Juri Linkov
2024-03-26  9:55                                                                         ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28  7:40                                                                           ` Juri Linkov
2024-03-28  9:18                                                                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-28 17:54                                                                               ` Juri Linkov
2024-03-29  8:45                                                                                 ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-29 16:25                                                                                   ` Juri Linkov
2024-03-30  9:36                                                                                     ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-30 18:19                                                                                       ` Juri Linkov
2024-04-02 17:19                                                                                         ` Juri Linkov
2024-04-09  6:44                                           ` Juri Linkov
2024-04-09  9:05                                             ` martin rudalics via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05efdf36-b474-430c-b22b-b05a8256579e@gmx.at \
    --to=bug-gnu-emacs@gnu.org \
    --cc=33871@debbugs.gnu.org \
    --cc=juri@linkov.net \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).