From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#29193: 26.0.90; Using (thing-at-point 'sexp) in flymake-diag-region might be suboptimal Date: Fri, 18 Dec 2020 17:22:18 +0200 Message-ID: <05dcfc56-ae5b-7943-4139-80c8b996e968@yandex.ru> References: <3ewnxgqalm.fsf_-_@fencepost.gnu.org> <08689c1a-3afc-6f83-6ded-7ee2e589d3c6@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38174"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: Glenn Morris , 29193@debbugs.gnu.org To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 18 16:37:42 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kqHp7-0009oe-NE for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 16:37:41 +0100 Original-Received: from localhost ([::1]:52354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kqHp6-0006UE-Jv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Dec 2020 10:37:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56704) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kqHax-0005lk-Fx for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:23:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56330) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kqHaw-0000Qp-3v for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:23:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kqHaw-0004SD-0F for bug-gnu-emacs@gnu.org; Fri, 18 Dec 2020 10:23:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Dec 2020 15:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 29193 X-GNU-PR-Package: emacs Original-Received: via spool by 29193-submit@debbugs.gnu.org id=B29193.160830494917081 (code B ref 29193); Fri, 18 Dec 2020 15:23:01 +0000 Original-Received: (at 29193) by debbugs.gnu.org; 18 Dec 2020 15:22:29 +0000 Original-Received: from localhost ([127.0.0.1]:39643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHaP-0004RR-JG for submit@debbugs.gnu.org; Fri, 18 Dec 2020 10:22:29 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:34422) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kqHaN-0004RA-KK for 29193@debbugs.gnu.org; Fri, 18 Dec 2020 10:22:27 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id g25so6134021wmh.1 for <29193@debbugs.gnu.org>; Fri, 18 Dec 2020 07:22:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=SCRDPkVoBOgO8Ja6MCAnh+Cz+8aMm9+PGS9qNhCttiE=; b=i/YPhrFnc/dO2hpqrT8HJkP1jZUxu2hsVGW845zc//LiX0+3jrr6XTORbunE+VC7tI JFFD5SNt25qu7LY54uWI7amXEaSV/eNc0bn8NJQwQmB8Eh8VGiCLZDj1jmcR+yXNZtS2 ncR9BHgwukbRFhrbtvWzY1g7WPk/ISEDw5LGj8VIlYrck3jZ0w/v7mPO7LGU6XN1TM9W Lltj14/CVQZaPOJv8LK9gZblTRhA5OMj2RoyyfsLq9e88bhLB+mZ4w+i5J89LJYfmiue 00yExMt7EVCNbNtgnzUbf63THERbBzhlGiAW1IJsL/0cTntUEhT85LgZ2uInL91m6Aj4 Jltg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=SCRDPkVoBOgO8Ja6MCAnh+Cz+8aMm9+PGS9qNhCttiE=; b=b28RijNLnxsQyZirliBLnwX4evp+2wt1M4+u1o4jwUMH95bWm/Fuj0uO5nBnNujRUX wTOlJ3yIPvM6q/hf84MWaVqo/7WlACKmtRKPHGfI83TFcoy+j8gFUfcgHAfsW0p7MAgC X9CM/IrkIGt7VHnF/Gzke9kmnnNd3YpIrdcvfYxjwT3QdiSozOZgngXAe3Sv9IUGuqCM pDKFi8JLEKoW3asd2zb8JKliTRBvrHn3MpauD+fkptAJ9nTDCZ1ogdMW7BxoKG7gfNd3 P17mwAGT47XnOJZ82WuUYF4bgn11vQ1RpGTxANkNZgo69yDLhcXlPgEI/2gVd9U7l9EH L13A== X-Gm-Message-State: AOAM532hgncFhntUL/wHBXXZOQa/xemoyZG9mGY1HH2K5CPz/EjFjENH JFXWCEoee5L1T/+RiIDObQJHMUOpWo+FiQ== X-Google-Smtp-Source: ABdhPJytBMa2bkJ+DQ7QJj+YT1LQQt5266yTjlDcR+2GZERQ6FTBTavMoxmiSYxyYdvjYQusSVzxLA== X-Received: by 2002:a7b:cf37:: with SMTP id m23mr4676488wmg.37.1608304941502; Fri, 18 Dec 2020 07:22:21 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id v4sm10550066wrw.42.2020.12.18.07.22.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Dec 2020 07:22:20 -0800 (PST) In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:196326 Archived-At: On 18.12.2020 13:42, João Távora wrote: > I think this is rather a thingatpt.el issue, which makes no mention of > match-data destruction. Regardless, it's decent enough to do that in > flymake-diag-region so I pushed save-match-data a bit higher. By default we assume that any function can destroy match-data (and only a certain set doesn't). But it's an easy mistake to make, especially given the fairly opaque implementation of (end-of-thing 'symbol).