unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Drew Adams <drew.adams@oracle.com>
To: bruce.connor.am@gmail.com
Cc: 22018@debbugs.gnu.org
Subject: bug#22018: 25.0.50; REGRESSION wrt `isearch-new-word'
Date: Thu, 26 Nov 2015 16:29:08 -0800 (PST)	[thread overview]
Message-ID: <05c9d4b4-736a-4825-9f5d-0b1544487b56@default> (raw)
In-Reply-To: <CAAdUY-+FjFrd6sO0NzxKu3T0cv_+8EofmsA_y3kj3cf1qg38tA@mail.gmail.com>

> > An alias (e.g., `defvaralias') would make it a global
> > variable, no?
> 
> Yes. I'll probably do that anyway. There's obviously code
> out there calling setq on this variable. Since this variable
> is no longer let bound, these setq will globally define the
> variable anyway.

Any such code out there would be used within the scope of
the macro (i.e., in BODY) - that's the point of such code.
It would count on the `let' binding in `with-search-suspended'.

So an alternative to adding a global binding would be to
first bind `isearch-new-word' to `isearch-regexp-function',
just as was done before.  That DTRT.  Any assignment by setq
in BODY would *not* "globally define the variable anyway."

That would let any 3rd-party code that uses `isearch-new-word'
behave exactly the same as before wrt that local variable.
The behavior could be altered negatively or unexpectedly if
we suddenly change the variable to a defvar.

But this is more of a nit.  I think it makes the behavior
cleaner, but admittedly it makes the code messier.  So please
do whatever you think best, as long as the bug gets fixed.
Thx.





  parent reply	other threads:[~2015-11-27  0:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-26 17:10 bug#22018: 25.0.50; REGRESSION wrt `isearch-new-word' Drew Adams
2015-11-26 23:21 ` Artur Malabarba
2015-11-26 23:44   ` Drew Adams
2015-11-27  0:03     ` Artur Malabarba
2015-11-27  0:05       ` Artur Malabarba
2015-11-27  0:29       ` Drew Adams [this message]
2015-11-27 11:26 ` Artur Malabarba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=05c9d4b4-736a-4825-9f5d-0b1544487b56@default \
    --to=drew.adams@oracle.com \
    --cc=22018@debbugs.gnu.org \
    --cc=bruce.connor.am@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).