From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#73722: 30.0.91; error calling eshell/clear with no argument Date: Tue, 15 Oct 2024 14:31:21 -0700 Message-ID: <05bd5ca0-7c14-a2af-ff58-77e6725b4be7@gmail.com> References: <87v7y1p4fi.fsf@librehacker.com> <2126f0f9-388e-5717-b0af-b7e3ec90e7d9@gmail.com> <86msj5qm2g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1268"; mail-complaints-to="usenet@ciao.gmane.io" Cc: christopher@librehacker.com, 73722@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 15 23:33:09 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0pAC-00006n-Pn for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 15 Oct 2024 23:33:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0p9r-0007wz-Tf; Tue, 15 Oct 2024 17:32:47 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0p9p-0007wr-0v for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 17:32:45 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0p9o-0002qJ-Ot for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 17:32:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=In-Reply-To:From:References:MIME-Version:Date:To:Subject; bh=HcuSmC3BJNoS9qxGHUtj+IPer0i8M8H1IG7yDoPgZbU=; b=hE5HrJd6LHlhTLhPB4wNCPcHRDl1G4eu/qux8e6YXdIP7ET2pLyE8QeND3//u/owsmHcybM9xqmvR13GkAm1uHbuMcq3jFc+FL5Hbgb/KyrkgI0cWd6KAAsrpwjrit+Ap5sM3rpdXvkgLRYmVhAf21G+O/osx2icUZPiwuGobo92en/taSMy6rc5zcRR5W3tKlDboT53cUC3MgRGUe3j+BofGbs3PURuI0/9mdDXEkZ9VC2hMwkfCdzrQPIq7wLE1rYKy3gkGtm2y/e56H/aZauo+fRl6759NhPometIm617G98zJcTxl/Z6lxfQpoB0kQvIDLXCN6tZKcsB9cz8pg==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0pA6-0004HP-Bs for bug-gnu-emacs@gnu.org; Tue, 15 Oct 2024 17:33:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 15 Oct 2024 21:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73722 X-GNU-PR-Package: emacs Original-Received: via spool by 73722-submit@debbugs.gnu.org id=B73722.172902796516396 (code B ref 73722); Tue, 15 Oct 2024 21:33:02 +0000 Original-Received: (at 73722) by debbugs.gnu.org; 15 Oct 2024 21:32:45 +0000 Original-Received: from localhost ([127.0.0.1]:57719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0p9p-0004GN-4L for submit@debbugs.gnu.org; Tue, 15 Oct 2024 17:32:45 -0400 Original-Received: from mail-pl1-f175.google.com ([209.85.214.175]:44489) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0p9n-0004GB-BC for 73722@debbugs.gnu.org; Tue, 15 Oct 2024 17:32:44 -0400 Original-Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-20cdbe608b3so22821725ad.1 for <73722@debbugs.gnu.org>; Tue, 15 Oct 2024 14:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729027883; x=1729632683; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=HcuSmC3BJNoS9qxGHUtj+IPer0i8M8H1IG7yDoPgZbU=; b=S7fQR8iMctnhq7ocuHXL85exnGfGQr8PpLJXb6LcWh1OkmTNso6o0qVKhZ00jmLKi6 RMlNJ8XAGnekQNCqW/ndieYnZQFKotg4a4eOgTFsRaVnQfDxGfZsfX0jZCajSwcsL1EU y+qiMJ52Nj592UqhuwgnP6qk+IQysrdfIAlQr3SRKhBiZ1fbZV3KGuvX7JukpNPLoxc5 +Ne83gL5tA24oL4n2KxuFnjyDhA2zsSirJ+UCVOWjLkKPQXy7DBqySR7KUotvfY5DBXg qB1nSMPfV3zvF75nlvIrpla6Wj4jNG5y9+v8ws5SS4mC05QKkBNGeBwJB3WzmQYSarA4 ih1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729027883; x=1729632683; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HcuSmC3BJNoS9qxGHUtj+IPer0i8M8H1IG7yDoPgZbU=; b=B9Trk8p1ZOL0ohU1WCxdvA7ZsIFzX9Jh2pL8RhQFhziasUF+5VzRiE3AKV1E6eDmix djbVhBpfs1J5Cj6Wg7n0+PEb/JVvZelOa62Q15S6b2xBTIy6lmqKUl1+4d5map4iSvOB 4UG7gdqSLjU+qyXQrk71HrYz2J8up+h/Ey1gF7u8b43rv3BNtPQafVdK1ytsNaQF3iTI 6NdTV26gZFn2oFpihoS575gWYjUwNESXLci6hNUvqqgNol+pkkeDdk/sv2rFUFeHGcRs HHTwbExk6sZR/WaPbXf75umFUQGeq6zQx3Lqgw+ExAh1fsqwmgRY+9sYZxR0tx14yuJa BctA== X-Forwarded-Encrypted: i=1; AJvYcCUNOlqRrPs9XDLjfx1Gi+8KhfSa43+XPI6RScLwNkqvql+NtD1KGcbXOB5bLq+a/llMVlEEGQ==@debbugs.gnu.org X-Gm-Message-State: AOJu0YwZGFmuNGr0H0i1nT9e5TnnuixCxFb0BMnDlcu+P23OzxcJlVO5 Ooxx6wRnttBWtqQBjiKUxx0PyjGoc/6IAH0iKZVaEJd53nA/zmOq X-Google-Smtp-Source: AGHT+IGfB9CRTBOeA6iR7KpFEmxwDjJVY9fhkc8/zrL3I3artBNl2JIWVv6pOy2ZQD4S1fS0/LmtpA== X-Received: by 2002:a17:902:c404:b0:20d:3015:b95c with SMTP id d9443c01a7336-20d3015ba80mr1921775ad.14.1729027883151; Tue, 15 Oct 2024 14:31:23 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-20d1804b76dsm16654255ad.210.2024.10.15.14.31.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Oct 2024 14:31:22 -0700 (PDT) Content-Language: en-US In-Reply-To: <86msj5qm2g.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:293647 Archived-At: On 10/15/2024 11:04 AM, Eli Zaretskii wrote: >> Eli, does this look ok for the release branch? It fixes a regression >> from Emacs 29 and adds a pair of regression tests to prevent future >> breakage. (If and when this merges, I'll see about a more-thorough fix >> for the master branch too.) > > If the problem is with empty body of progn, why does the fix have to > be so much less self-evident? Can you fix it by protecting against > empty body of progn instead, so that the fix is less likely to cause > unintended consequences? That's just the loudest part of the bug. Even though I've already fixed that part on Emacs 31, things still don't work correctly there. If you run the "clear" command in Eshell it clears the screen, but then prints two new prompts on the same line together. However, this behavior is pretty close to what "clear" did in Emacs 29: it prints two prompts (but there's a newline between them). If I fix the empty 'progn' case, I guess that would fix the regression (aside from the missing newline, which I'm not sure how to fix). However, "clear" still wouldn't work correctly. What do you think would be better for Emacs 30? Fix "clear" so it works properly, or just fix the new regression? (In the latter case, I can fix it with a one-liner.)