From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#72824: Eglot highlights matches incorrectly wrt case sensitivity Date: Tue, 27 Aug 2024 04:38:01 +0300 Message-ID: <05924929-997f-4d37-ba3b-a4620a687c03@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38181"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: joaotavora@gmail.com To: 72824@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Aug 27 03:41:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1silD7-0009on-QH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Aug 2024 03:41:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1silCr-0004Cv-Ov; Mon, 26 Aug 2024 21:41:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1silCp-0004Cd-Ej for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 21:41:11 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1silCp-0000Vk-5m for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 21:41:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=From:MIME-Version:Date:To:Subject; bh=sEzPFoUfBAY1A1hXgnfLaIAWF6WZE+DGyS+KPY3ySHo=; b=gGZVuIFVyCFnLC4ERtjmDLBJv3hiqXcDGgAwq7Se72Z8I+ORMI0ooA7PlIjp3FEb4Qltnxu8M8fSqqiSFjEb9yiCSDKDFFjmBfcjb91STXGeFvQEQ6P8zXqKyE6qX/8jDi1BPPJlbQNzRTssx0xhfJAGePaiD//XtU9zMCiZBKj46yNUqL15UvuQutjWaWx8W38yky8Xf8XLMvIYHYOaNrymjv0zfrAvk1WKW2+yDh92T70rEkCty1TY/9ROMAv7/Fb82jMCjahGz4mOzmJ57ZncC9pQv+xzenOiyEIxSdS4J27Tso+Jxzf4kTRb6nowQMrcazQnDZQHt8EVPZSxug==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1silDe-0000py-2c; Mon, 26 Aug 2024 21:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: joaotavora@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2024 01:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 72824 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: joaotavora@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.17247228733148 (code B ref -1); Tue, 27 Aug 2024 01:42:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 27 Aug 2024 01:41:13 +0000 Original-Received: from localhost ([127.0.0.1]:45726 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1silCr-0000oi-EW for submit@debbugs.gnu.org; Mon, 26 Aug 2024 21:41:13 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1silCp-0000oa-Dk for submit@debbugs.gnu.org; Mon, 26 Aug 2024 21:41:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sil9s-0006rt-V3 for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 21:38:08 -0400 Original-Received: from fhigh1-smtp.messagingengine.com ([103.168.172.152]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sil9r-00008H-5O for bug-gnu-emacs@gnu.org; Mon, 26 Aug 2024 21:38:08 -0400 Original-Received: from phl-compute-06.internal (phl-compute-06.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 8DB82115184B for ; Mon, 26 Aug 2024 21:38:04 -0400 (EDT) Original-Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-06.internal (MEProxy); Mon, 26 Aug 2024 21:38:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:message-id:mime-version:reply-to:subject :subject:to:to; s=fm2; t=1724722684; x=1724809084; bh=sEzPFoUfBA Y1A1hXgnfLaIAWF6WZE+DGyS+KPY3ySHo=; b=DcoyR4Fp7s1sjVdKWdOabOuCwn VXUW3YLjqbNrMygi5SidhzyB72PiENGbRZWnSCikW4YYDNbRipTp+xBLoT/Ee+/C KR48p7bz02+1kgAmfAinzdcJzQX6hOSytOp7Mdv6QhsNcjLdwm9mTCWG65QQaxHz YjUi/cpBWbQft7+B3iAokodDfQ0R2pnVQPo/+XkBNxJDSWqiw4BZuahGBgqbe5zl 7YfUmkNYnNXcTDshGn+Kw+ZH+4mf2XeesIYKsdPme3awYY9tHrmgceEcMGSefXI2 a+wR9qQRkdQu5idfJGhMFivIgLKB5S1ggspZ05R2AyenKh4KDPDAX3SKA74Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:message-id:mime-version:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1724722684; x=1724809084; bh=sEzPFoUfBAY1A1hXgnfLaIAWF6WZ E+DGyS+KPY3ySHo=; b=NW4KCwf24BgzUPBTlFwm8pEYjhP/siqY1VjV7aLVmpzr n9Nj/iybfwNT6zEA3j+YQh+oqgNL9OqO2jbY7KkHm/tcbCv2uMVHPeklO+W0+DPu 7dFCf9hrET1fs2vRRSEx1IwVUVdGv1dhdNJsy+PFMFoCaAQZm7TC//U71IyGYU1u gP0e+R6uVxtUU/J5YMb1SXJ8hezu6ty1B8wYlohXJm2FzUE3S3oz7R+XZRVhHe8G nzBWmAaBJdrfiDlbp7ZT7Qszu5nMB7gAfdBltZ9wkX8+9GkR24HVjvEakyjrClNM iNo+8kR1biDbMGEVKK/US2IuqKIqEY5Sw2qgeWFSGg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddruddvledggeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfg fvhffutgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhithhrhicuifhuthhovhcuoegu mhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrthhtvghrnhepfeekfeeghfejve ehkedtgefhffejgefgudetgfeguefhteekudeivefghfekgfevnecuvehluhhsthgvrhfu ihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepughmihhtrhihsehguhhtohhvrd guvghvpdhnsggprhgtphhtthhopedupdhmohguvgepshhmthhpohhuthdprhgtphhtthho pegsuhhgqdhgnhhuqdgvmhgrtghssehgnhhurdhorhhg X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Mon, 26 Aug 2024 21:38:03 -0400 (EDT) Content-Language: en-US Received-SPF: pass client-ip=103.168.172.152; envelope-from=dmitry@gutov.dev; helo=fhigh1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:290798 Archived-At: X-Debbugs-Cc: joaotavora@gmail.com 1. Server gopls, for example. 2. completion-ignore-case=nil, its default value. 3. Input "clCe" and completions for it like clockCenterX clockCenterY Completions are case-sensitive, but completions' highlighting works as if it's insensitive - highlights are on "cl", second "c" and "e", whereas the capital "C" is not highlighted. This fixes it for me: diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el index 844fc634be9..acc197754db 100644 --- a/lisp/progmodes/eglot.el +++ b/lisp/progmodes/eglot.el @@ -3260,7 +3260,7 @@ eglot-completion-at-point (try-completion pattern (funcall proxies))) ((eq action t) ; all-completions (let ((comps (funcall proxies))) - (dolist (c comps) (eglot--dumb-flex pattern c t)) + (dolist (c comps) (eglot--dumb-flex pattern c completion-ignore-case)) (all-completions "" comps