From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#6256: 24.0.50; read-event in `repeat' command Date: Mon, 24 May 2010 09:28:36 -0700 Message-ID: <058F2FC300154C1AB894694655B2A968@us.oracle.com> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1274720265 8576 80.91.229.12 (24 May 2010 16:57:45 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 24 May 2010 16:57:45 +0000 (UTC) To: <6256@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 24 18:57:43 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OGayB-0001IX-90 for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 May 2010 18:57:43 +0200 Original-Received: from localhost ([127.0.0.1]:52970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGaxy-0007yf-VP for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 May 2010 12:57:26 -0400 Original-Received: from [140.186.70.92] (port=48310 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGaxq-0007xI-Rh for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 12:57:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGaxm-0006Ot-EX for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 12:57:16 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49832) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGaxm-0006Oi-82 for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 12:57:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OGaWT-0002gZ-KT; Mon, 24 May 2010 12:29:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Drew Adams" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 May 2010 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6256 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6256-submit@debbugs.gnu.org id=B6256.127471853110317 (code B ref 6256); Mon, 24 May 2010 16:29:01 +0000 Original-Received: (at 6256) by debbugs.gnu.org; 24 May 2010 16:28:51 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGaWI-0002gM-PP for submit@debbugs.gnu.org; Mon, 24 May 2010 12:28:50 -0400 Original-Received: from rcsinet10.oracle.com ([148.87.113.121]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGaWG-0002gH-2R for 6256@debbugs.gnu.org; Mon, 24 May 2010 12:28:48 -0400 Original-Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o4OGSeJ3029612 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for <6256@debbugs.gnu.org>; Mon, 24 May 2010 16:28:42 GMT Original-Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o4OCFm49029339 for <6256@debbugs.gnu.org>; Mon, 24 May 2010 16:28:39 GMT Original-Received: from abhmt021.oracle.com by acsmt354.oracle.com with ESMTP id 262972221274718517; Mon, 24 May 2010 09:28:37 -0700 Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 24 May 2010 09:28:37 -0700 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Thread-Index: Acr7U2eLNMl3f5XOTxOtwKcH93l1zwACiewg X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090208.4BFAA93A.00B1:SCFMA922111,ss=1,fgs=0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 24 May 2010 12:29:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37230 Archived-At: > Is changing `read-event' to `read-char-exclusive' the proper > fix for this bug? It works for me. If it is not the right fix, > then what is? > > If it is important for some use reason to keep `read-event', > and no fix is found that would DTRT to distinguish real user > events from events such as `switch-frame', then could we at > least use `(funcall repeat-read-function)' instead of > `(read-event)', so that code that wants to be sensitive to > only char events can bind `repeat-read-function' to > `read-char-exclusive' around the call to `repeat'? > > The default value of such a var could be `read-event', if > that's deemed the best default, but we at least need some > way to make `repeat' ignore non-char events > (if we cannot find a way to make it ignore non-user events). Actually, I think that using `read-char-exclusive' is the right fix. If the action were initiated by a mouse event it is unlikely that the next event would be the same mouse event, so repetition would not occur anyway. Could you please make this fix: replace the unique occurrence of `read-event' by `read-char-exclusive' in `repeat'. Thx.