From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#12490: 24.2; Search inside Minibuffer don't work with M-x (M-x C-s) Date: Sat, 30 Nov 2019 15:41:38 -0800 (PST) Message-ID: <056252e6-d622-4b46-80c1-7d35f89d00e0@default> References: <20120922224229.7baf7964@jcubic> <87obkxod8c.fsf@mail.jurta.org> <87bltxx458.fsf@joffe.skangas.se> <87o8x2lkon.fsf@gnus.org> <87h82l82qx.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="175174"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Jakub Jankiewicz , 12490@debbugs.gnu.org, Stefan Kangas To: Juri Linkov , Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 01 00:42:31 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibCNi-000jNc-OZ for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Dec 2019 00:42:30 +0100 Original-Received: from localhost ([::1]:39268 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibCNh-0006Pw-HQ for geb-bug-gnu-emacs@m.gmane.org; Sat, 30 Nov 2019 18:42:29 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50122) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibCNJ-00069i-0x for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 18:42:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibCNG-0003Ky-NC for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 18:42:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57580) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ibCNG-0003KS-8F for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 18:42:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ibCNG-0000O4-4O for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2019 18:42:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Nov 2019 23:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 12490 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 12490-submit@debbugs.gnu.org id=B12490.15751573171477 (code B ref 12490); Sat, 30 Nov 2019 23:42:02 +0000 Original-Received: (at 12490) by debbugs.gnu.org; 30 Nov 2019 23:41:57 +0000 Original-Received: from localhost ([127.0.0.1]:35320 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibCNB-0000Nj-51 for submit@debbugs.gnu.org; Sat, 30 Nov 2019 18:41:57 -0500 Original-Received: from userp2130.oracle.com ([156.151.31.86]:50292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ibCN9-0000NQ-GU for 12490@debbugs.gnu.org; Sat, 30 Nov 2019 18:41:56 -0500 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAUNfk3H109665; Sat, 30 Nov 2019 23:41:46 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=r7+0Mmpt3XQE4KdiQQQqmuE22nqNW7ld4G6w0GPGqfA=; b=nexLZ/JBB/c/GG42iHB6ScmK2wKa/dnYd4l7wmxrUgMgfDWzavf70w8UhfEUgpud7WYO aSTfUOUFCfCAgny4ATWeuwdpJ4SJXZ7HNor/52T4mG2lD8i7QaaL1LmJ7BNvftgLsktc Jf8g1Uz80ozWVYVFHhExS4rKsdEauQsUAVJREN9qwIjYzfan2hfPs3kvsIbB9LJcN4w/ o/oa9KRustKZpPj1dcEkHTSAd2mZxJoboJ6tdaz9wxmNC4pqa+o7u7GTllir1F54YA82 nJDXcj4nPIucsRNdboH9rHtaEdLLZhHRr4n5OPH5UK5Uyh80oBVNpGbH0zxVTTGlEeYy Ug== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by userp2130.oracle.com with ESMTP id 2wkfuttc2h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 30 Nov 2019 23:41:46 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id xAUNYC1Y034989; Sat, 30 Nov 2019 23:41:46 GMT Original-Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3020.oracle.com with ESMTP id 2wm1xam12s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 30 Nov 2019 23:41:45 +0000 Original-Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id xAUNfdEj001137; Sat, 30 Nov 2019 23:41:40 GMT In-Reply-To: <87h82l82qx.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4927.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9457 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=942 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911300212 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9457 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-1911300213 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:172687 Archived-At: > This patch allows searching thru all commands available via M-x, That's not "searching" - certainly not isearching. > i.e. it's like using isearch in the *Completions* buffer like > M-x TAB C-s command That _is_ isearching (in buffer *Completions*). > with without opening the *Completions* buffer, with just > M-x C-s command > to search commands available with M-x M-n M-n M-n ... It's not searching. We use a different key, such as `M-s' or `M-r', to insert a matching history element. `M-s' is `next-matching history-element'. It has nothing in common with Isearch. IMHO, we should never bind `C-s' in the minibuffer to anything. Why? Because the minibuffer is a buffer where text editing and cursor movment are allowed/encouraged/normal. We shouldn't remove the ability to use Isearch there (using the global `C-s' binding). `C-s' in the minibuffer should, as it has before (prior to Emacs 23, it seems), provide Isearch on the minibuffer contents, just like it does in other buffers. I see now that someone changed this in Emacs 23, at least for `read-buffer', to make `C-s' do what has been described in this thread. IMHO, that was a step backward, not forward. (I didn't notice it because I have my own `read-buffer' code.) It's fine to have other keys to find and retrieve past inputs, completion candidates, defaults, etc. That's something we've always done (`M-s', `M-n', etc.). Co-opting `C-s' to do that kind of thing was (and is) misguided, IMO. Spreading it from `C-x b' to `M-x' will be yet another step backward. My FWIW vote is to remove any default bindings of `C-s' in the minibuffer, to let it do its useful job there of `isearch-forward'.