From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#50067: Context menus Date: Fri, 20 Aug 2021 12:29:46 +0200 Message-ID: <054BA74B-AACE-483F-994E-5E8E49E093E5@acm.org> References: <74BC00E9-2509-47DA-9428-1523FF7F3B33@acm.org> <87v942pvcj.fsf@mail.linkov.net> <83zgte3asy.fsf@gnu.org> <87mtpepqzw.fsf@mail.linkov.net> <83sfz639lh.fsf@gnu.org> <8735r6ppf0.fsf@mail.linkov.net> <83o89u37gh.fsf@gnu.org> <87wnohx5zd.fsf@mail.linkov.net> <831r6p3lzc.fsf@gnu.org> <87o89sh96g.fsf@mail.linkov.net> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.21\)) Content-Type: multipart/mixed; boundary="Apple-Mail=_B5FCEA10-E0DC-424D-9857-A27F1972A5F9" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19478"; mail-complaints-to="usenet@ciao.gmane.io" Cc: alan@idiocy.org, homeros.misasa@gmail.com, tkk@misasa.okayama-u.ac.jp, larsi@gnus.org, 50067@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 20 12:31:16 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mH1nu-0004rx-5Y for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Aug 2021 12:31:14 +0200 Original-Received: from localhost ([::1]:52194 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH1ns-00076r-50 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 20 Aug 2021 06:31:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46822) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH1ni-00075R-2b for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 06:31:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49691) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mH1nh-0006SC-QH for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 06:31:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mH1nh-00037p-NW for bug-gnu-emacs@gnu.org; Fri, 20 Aug 2021 06:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 20 Aug 2021 10:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50067 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 50067-submit@debbugs.gnu.org id=B50067.162945540311847 (code B ref 50067); Fri, 20 Aug 2021 10:31:01 +0000 Original-Received: (at 50067) by debbugs.gnu.org; 20 Aug 2021 10:30:03 +0000 Original-Received: from localhost ([127.0.0.1]:33001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mH1mk-00034r-9X for submit@debbugs.gnu.org; Fri, 20 Aug 2021 06:30:02 -0400 Original-Received: from mail1479c50.megamailservers.eu ([91.136.14.79]:42794 helo=mail118c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mH1mh-00034H-2a for 50067@debbugs.gnu.org; Fri, 20 Aug 2021 06:30:00 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1629455390; bh=xoa7oIRfmjXASWdFyylXfAv5lnqgYhFSycES2cquNg0=; h=From:Subject:Date:In-Reply-To:Cc:To:References:From; b=PIJ3M/2vdEqZnzmLBsMtyhT5kLD1bMDOr5bXIeb0RkYuZBCw4Cijym2AGNAf2eze+ R4ZKwAS2XRyZ/P2P2lWOiFXDR7UP6MHv/LgLdwQw0BBfhymG6P6sCPoOriQvZRvPdT jf+yCycCklzEPAJ6P+nZnesJF8T9PMMRj2sNsB/k= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.tele2.se [188.150.171.71]) (authenticated bits=0) by mail118c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 17KATkFW015080; Fri, 20 Aug 2021 10:29:48 +0000 In-Reply-To: <87o89sh96g.fsf@mail.linkov.net> X-Mailer: Apple Mail (2.3445.104.21) X-CTCH-RefID: str=0001.0A742F24.611F841E.0031, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=Ro+70xuK c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=M51BFTxLslgA:10 a=ucMQw-l_AAAA:8 a=fadQNI1QHYaLwKwGDA4A:9 a=CjuIK1q_8ugA:10 a=QB8CW2OmG7bqRjDTZ6EA:9 a=B2y7HmGcmWMA:10 a=tclcd6dtLQvEqt9_mmAA:9 a=xkTruGkd22MpkFU079mG:22 X-Origin-Country: SE X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212258 Archived-At: --Apple-Mail=_B5FCEA10-E0DC-424D-9857-A27F1972A5F9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii 20 aug. 2021 kl. 09.29 skrev Juri Linkov : > An example of such menu is mouse-buffer-menu bound to C- > where the user might wonder what do these menu items with mode names = mean? That's moot for macOS since C-mouse-1 will be used for the context menu. = (Proposed patch attached.) In macOS/NS, "titles" as disabled menu entries simply do not exist in = the GUI vocabulary and look alien, amateurish, confusing or wrong. The = menu is expected to be understood in its context of activation. Where menus have titles, it's the corresponding entry in the parent menu = (or menu bar). They are never named "something Menu" because that would = be silly; typically it's a verb, or a noun setting a context for the = entries in the sub-menu. For a menu of buffers to switch to, the title = (if any) might be "Switch to buffer", "Buffer", "Switch to" or similar. --Apple-Mail=_B5FCEA10-E0DC-424D-9857-A27F1972A5F9 Content-Disposition: attachment; filename=0001-Use-C-mouse-1-for-context-menu-on-NS.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="0001-Use-C-mouse-1-for-context-menu-on-NS.patch" Content-Transfer-Encoding: quoted-printable =46rom=20e505aa17a1ac679fee55220c594f0cfd53342739=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20=3D?UTF-8?q?Mattias=3D20Engdeg=3DC3=3DA5rd?=3D=20= =0ADate:=20Fri,=2020=20Aug=202021=2012:03:20=20+0200=0A= Subject:=20[PATCH]=20Use=20C-mouse-1=20for=20context=20menu=20on=20NS=0A=0A= The=20Mac=20platform=20convention=20is=20to=20use=20control-left-click=20= for=20context=0Amenus=20(as=20a=20synonym=20to=20right-click).=0A=0A*=20= lisp/mouse.el=20(context-menu--old-bindings):=20Remove.=0A= (context-menu--saved-bindings)=0A(context-menu--bind-mouse,=20= context-menu--reset-bindings):=20New.=0A(context-menu-mode):=20Use=20new=20= functions,=20with=20C-mouse-1=20as=20extra=0Abinding=20on=20NS.=0A---=0A=20= lisp/mouse.el=20|=2045=20+++++++++++++++++++++++++++++----------------=0A= =201=20file=20changed,=2029=20insertions(+),=2016=20deletions(-)=0A=0A= diff=20--git=20a/lisp/mouse.el=20b/lisp/mouse.el=0Aindex=20= 4c4a7d35a8..8af5509afc=20100644=0A---=20a/lisp/mouse.el=0A+++=20= b/lisp/mouse.el=0A@@=20-440,8=20+440,28=20@@=20context-menu-entry=0A=20=20= =20`(menu-item=20,(purecopy=20"Context=20Menu")=20ignore=0A=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20:filter=20(lambda=20(_)=20= (context-menu-map))))=0A=20=0A-(defvar=20context-menu--old-down-mouse-3=20= nil)=0A-(defvar=20context-menu--old-mouse-3=20nil)=0A+(defvar=20= context-menu--saved-bindings=20nil=0A+=20=20"Alist=20of=20bindings=20to=20= restore=20when=20`context-menu-mode'=20is=20disabled.")=0A+=0A+(defun=20= context-menu--bind-mouse=20(click-sym=20down-sym)=0A+=20=20"Enable=20= `context-menu-mode'=20mouse=20bindings.=0A+CLICK-SYM=20and=20DOWN-SYM=20= are=20the=20mouse=20click=20and=20down=20key=20symbols=20to=20use."=0A+=20= =20(let=20((click=20(vector=20click-sym))=0A+=20=20=20=20=20=20=20=20= (down=20(vector=20down-sym)))=0A+=20=20=20=20(push=20(cons=20click-sym=20= (global-key-binding=20click))=0A+=20=20=20=20=20=20=20=20=20=20= context-menu--saved-bindings)=0A+=20=20=20=20(global-unset-key=20click)=0A= +=20=20=20=20(push=20(cons=20down-sym=20(global-key-binding=20down))=0A+=20= =20=20=20=20=20=20=20=20=20context-menu--saved-bindings)=0A+=20=20=20=20= (global-set-key=20down=20context-menu-entry)))=0A+=0A+(defun=20= context-menu--reset-bindings=20()=0A+=20=20"Restore=20saved=20= `context-menu-mode'=20bindings."=0A+=20=20(pcase-dolist=20(`(sym=20.=20= binding)=20context-menu--saved-bindings)=0A+=20=20=20=20(let=20((key=20= (vector=20sym)))=0A+=20=20=20=20=20=20(if=20binding=0A+=20=20=20=20=20=20= =20=20=20=20(global-set-key=20key=20binding)=0A+=20=20=20=20=20=20=20=20= (global-unset-key=20key)))))=0A=20=0A=20(define-minor-mode=20= context-menu-mode=0A=20=20=20"Toggle=20Context=20Menu=20mode.=0A@@=20= -449,20=20+469,13=20@@=20context-menu-mode=0A=20When=20Context=20Menu=20= mode=20is=20enabled,=20clicking=20the=20mouse=20button=20down-mouse-3=0A=20= activates=20the=20menu=20whose=20contents=20depends=20on=20its=20= surrounding=20context."=0A=20=20=20:global=20t=20:group=20'mouse=0A-=20=20= (cond=0A-=20=20=20(context-menu-mode=0A-=20=20=20=20(setq=20= context-menu--old-mouse-3=20(global-key-binding=20[mouse-3]))=0A-=20=20=20= =20(global-unset-key=20[mouse-3])=0A-=20=20=20=20(setq=20= context-menu--old-down-mouse-3=20(global-key-binding=20[down-mouse-3]))=0A= -=20=20=20=20(global-set-key=20[down-mouse-3]=20context-menu-entry))=0A-=20= =20=20(t=0A-=20=20=20=20(if=20(not=20context-menu--old-down-mouse-3)=0A-=20= =20=20=20=20=20=20=20(global-unset-key=20[down-mouse-3])=0A-=20=20=20=20=20= =20(global-set-key=20[down-mouse-3]=20context-menu--old-down-mouse-3)=0A= -=20=20=20=20=20=20(setq=20context-menu--old-down-mouse-3=20nil))=0A-=20=20= =20=20(when=20context-menu--old-mouse-3=0A-=20=20=20=20=20=20= (global-set-key=20[mouse-3]=20context-menu--old-mouse-3)=0A-=20=20=20=20=20= =20(setq=20context-menu--old-mouse-3=20nil)))))=0A+=20=20(if=20= context-menu-mode=0A+=20=20=20=20=20=20(progn=0A+=20=20=20=20=20=20=20=20= (setq=20context-menu--saved-bindings=20nil)=0A+=20=20=20=20=20=20=20=20= (context-menu--bind-mouse=20'mouse-3=20'down-mouse-3)=0A+=20=20=20=20=20=20= =20=20(when=20(featurep=20'ns)=0A+=20=20=20=20=20=20=20=20=20=20= (context-menu--bind-mouse=20'C-mouse-1=20'C-down-mouse-1)))=0A+=20=20=20=20= (context-menu--restore-bindings)))=0A=20=0A=20=0C=0A=20;;=20Commands=20= that=20operate=20on=20windows.=0A--=20=0A2.21.1=20(Apple=20Git-122.3)=0A=0A= --Apple-Mail=_B5FCEA10-E0DC-424D-9857-A27F1972A5F9 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_B5FCEA10-E0DC-424D-9857-A27F1972A5F9--