bug#68880: 30.0.50; [pgtk] Theme customization is not applied by custom-theme-set-faces until theme is re-enabled

bug#68880: 30.0.50; [pgtk] Theme customization is not applied by custom-theme-set-faces until theme is re-enabled

[Dmitry Gutov]

To reproduce, put this into .emacs:

(add-hook
   'after-init-hook
   (lambda ()
     (load-theme 'adwaita t)

     (custom-theme-set-faces
      'adwaita
      '(font-lock-comment-face ((t (:foreground "yellow")))))))

Then run emacs -Q.

When the PGTK port is used, the comment face's foreground won't be
yellow. With other ports (e.g. GTK3 or Lucid), it is.

The use of after-init-hook itself it not crucial - you can just as well
enable the theme using 'M-x load-theme' and then evaluate the
custom-theme-set-faces form.

There is some text on the splash screen with font-lock-comment-face
applied, so you should see the effect right away.

In GNU Emacs 30.0.50 (build 333, x86_64-pc-linux-gnu, GTK+ Version
  3.24.38, cairo version 1.18.0) of 2024-02-02 built on potemkin
Repository revision: 71b5d5a9799a37948b2e8cca125a59e2bfb71e96
Repository branch: master
System Description: Ubuntu 23.10

Configured using:
  'configure --with-pgtk'

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBOTF LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PGTK PNG RSVG
SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP
XIM GTK3 ZLIB

bug#68880: 30.0.50; [pgtk] Theme customization is not applied by custom-theme-set-faces until theme is re-enabled

[Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Dmitry Gutov <dmitry@gutov.dev> writes:

> To reproduce, put this into .emacs:
>
> (add-hook
>   'after-init-hook
>   (lambda ()
>     (load-theme 'adwaita t)
>
>     (custom-theme-set-faces
>      'adwaita
>      '(font-lock-comment-face ((t (:foreground "yellow")))))))
>
> Then run emacs -Q.

Upon rereading your description, it appears as though you're reporting
that `emacs -Q' does not load the user's initialization files, while it
does in the non-PGTK builds.  Needless to say, if true, that is a severe
bug!

> When the PGTK port is used, the comment face's foreground won't be
> yellow. With other ports (e.g. GTK3 or Lucid), it is.
>
> The use of after-init-hook itself it not crucial - you can just as well
> enable the theme using 'M-x load-theme' and then evaluate the
> custom-theme-set-faces form.
>
> There is some text on the splash screen with font-lock-comment-face
> applied, so you should see the effect right away.

I can reproduce this, thanks.

bug#68880: 30.0.50; [pgtk] Theme customization is not applied by custom-theme-set-faces until theme is re-enabled

[Dmitry Gutov]

On 03/02/2024 08:41, Po Lu wrote:
> Dmitry Gutov <dmitry@gutov.dev> writes:
> 
>> To reproduce, put this into .emacs:
>>
>> (add-hook
>>    'after-init-hook
>>    (lambda ()
>>      (load-theme 'adwaita t)
>>
>>      (custom-theme-set-faces
>>       'adwaita
>>       '(font-lock-comment-face ((t (:foreground "yellow")))))))
>>
>> Then run emacs -Q.
> 
> Upon rereading your description, it appears as though you're reporting
> that `emacs -Q' does not load the user's initialization files, while it
> does in the non-PGTK builds.  Needless to say, if true, that is a severe
> bug!

Not sure it relates to the user initialization files: like I say below, 
the same scenario and the result can be reproduced interactively after 
Emacs has initialized.

>> When the PGTK port is used, the comment face's foreground won't be
>> yellow. With other ports (e.g. GTK3 or Lucid), it is.
>>
>> The use of after-init-hook itself it not crucial - you can just as well
>> enable the theme using 'M-x load-theme' and then evaluate the
>> custom-theme-set-faces form.
>>
>> There is some text on the splash screen with font-lock-comment-face
>> applied, so you should see the effect right away.
> 
> I can reproduce this, thanks.