From: Jimmy Wong <wyuenho@gmail.com>
To: Andrea Corallo <akrl@sdf.org>
Cc: Eli Zaretskii <eliz@gnu.org>, 63302@debbugs.gnu.org
Subject: bug#63302: 29.0.90; Native comp does not respect byte-compile-warnings
Date: Sun, 14 May 2023 22:57:52 +0100 [thread overview]
Message-ID: <04aa1c13-8a5a-4a8a-884f-24a7f70f5607@Spark> (raw)
In-Reply-To: <xjf4jok1jyv.fsf@ma.sdf.org>
[-- Attachment #1: Type: text/plain, Size: 648 bytes --]
This works, thank you!
On 10 May 2023 at 12:53 PM +0100, Andrea Corallo <akrl@sdf.org>, wrote:
> Jimmy Yuen Ho Wong <wyuenho@gmail.com> writes:
>
> > Yes I'm talking about nativecomp.
> >
> > Reproduction:
> >
> > 1. (setq package-native-compile t)
> > 2. (setq byte-compile-warnings '(not docstrings docstrings-non-ascii-quotes))
> > 3. (setq native-comp-async-report-warnings-errors 'silent)
> > 4. M-x package-install ov
> > 5. Observe the differences between the *Compile-Log* buffer and the *Warnings* buffer.
> >
> > Jimmy
>
> Hi Jimmy,
>
> could you try the attached and report if it solves the reported issue?
>
> Best Regards
>
> Andrea
>
[-- Attachment #2.1: Type: text/html, Size: 1255 bytes --]
[-- Attachment #2.2: warning.patch --]
[-- Type: application/octet-stream, Size: 1143 bytes --]
diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el
index 025d21631bb..d7a60b9f007 100644
--- a/lisp/emacs-lisp/comp.el
+++ b/lisp/emacs-lisp/comp.el
@@ -3732,6 +3732,7 @@ comp-final
',native-comp-compiler-options
native-comp-driver-options
',native-comp-driver-options
+ byte-compile-warnings ',byte-compile-warnings
load-path ',load-path)
,native-comp-async-env-modifier-form
(message "Compiling %s..." ',output)
@@ -4004,6 +4005,7 @@ comp-run-async-workers
native-comp-driver-options
load-path
backtrace-line-length
+ byte-compile-warnings
;; package-load-list
;; package-user-dir
;; package-directory-list
next prev parent reply other threads:[~2023-05-14 21:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 11:51 bug#63302: 29.0.90; Native comp does not respect byte-compile-warnings Jimmy Yuen Ho Wong
2023-05-05 13:22 ` Eli Zaretskii
2023-05-06 16:52 ` Jimmy Yuen Ho Wong
2023-05-10 11:53 ` Andrea Corallo
2023-05-14 21:57 ` Jimmy Wong [this message]
2023-05-17 7:49 ` Andrea Corallo
2023-05-17 11:05 ` Eli Zaretskii
2023-05-17 13:14 ` Andrea Corallo
2023-05-10 9:57 ` Andrea Corallo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=04aa1c13-8a5a-4a8a-884f-24a7f70f5607@Spark \
--to=wyuenho@gmail.com \
--cc=63302@debbugs.gnu.org \
--cc=akrl@sdf.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).