From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#63967: 28.2; switch-to-buffer in normal window fails if minibuffer window is active Date: Sat, 10 Jun 2023 08:52:57 +0200 Message-ID: <0469e0cb-4f63-eb4b-1184-2dfeabdcf9e6@gmx.at> References: <83o7lo28e6.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5530"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 63967@debbugs.gnu.org To: Eli Zaretskii , Al Petrofsky , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 10 08:54:39 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q7sUh-0001FE-9D for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 10 Jun 2023 08:54:39 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q7sUZ-0002EO-Hy; Sat, 10 Jun 2023 02:54:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q7sU8-0002Bq-9m for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 02:54:10 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q7sU6-0005LY-Ie for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 02:54:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q7sU6-0007QY-EQ for bug-gnu-emacs@gnu.org; Sat, 10 Jun 2023 02:54:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Jun 2023 06:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63967 X-GNU-PR-Package: emacs Original-Received: via spool by 63967-submit@debbugs.gnu.org id=B63967.168637999128482 (code B ref 63967); Sat, 10 Jun 2023 06:54:02 +0000 Original-Received: (at 63967) by debbugs.gnu.org; 10 Jun 2023 06:53:11 +0000 Original-Received: from localhost ([127.0.0.1]:33145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7sTH-0007PI-BE for submit@debbugs.gnu.org; Sat, 10 Jun 2023 02:53:11 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:54625) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q7sTE-0007P5-LM for 63967@debbugs.gnu.org; Sat, 10 Jun 2023 02:53:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1686379979; x=1686984779; i=rudalics@gmx.at; bh=pGX174wRS1nYVBhaHIapiopbFMzgVVWJcdBJ7dWW+w8=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=ud6omFdVBVq7VVpWCs9a3pYd93Ba/LpN4RmAdwvaDGk1iA87Vxg1duh0emb6PQdsangoewK J2BzheITBluasNIrj+B5T9E0AcjfAPPKRDAMY1KBMTTHoSHZm5HFMGKqk4c6gV4gmQR2HOhT1 9CExGhRVy5WtNPvimvHnmJzhIK5cmLpl2DDzpOpdVEHIMEplm0iCZe80TGjPFuKNarNMF2bxT 7m/LGJZhAe8cnImCoQBFLeWjHCJ+Eth3lqrazUYpJQbFsFAXOALnN6QFAz/f+XAmD07nO8tk+ R12m30WmM7qYLx374cOEFEKXEoxtjXCSWtkd/9G0yLj33daWf8HQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from [192.168.1.100] ([212.95.5.146]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MKsjH-1qQuDn3zMT-00LFPp; Sat, 10 Jun 2023 08:52:59 +0200 Content-Language: en-US In-Reply-To: <83o7lo28e6.fsf@gnu.org> X-Provags-ID: V03:K1:gWRGjn+Utc3CQwIkcqLAtKcHfLno9skaEJC35nTgTWuLUIlKZcP LHDiX6otqHvcYryj3D4/DFI+BOUdN3Yu1FsFCucmlBFMxmITZkCgmnO7ltekMQbpEDbg+/n mg+02TUfUhI8mia+BYAOgZivVtS98dqZ7d6FCauFXtUzCtTRk8soaGwM4fEmBTCnf9CpTk9 7SjcaLppem7BRrZveEW4Q== UI-OutboundReport: notjunk:1;M01:P0:64foIftWxew=;p7S87+zdUexnXVYfDsDCeTmX4hB aIQgY3D4bGICXwsDlF8andm+8B54R2VkDzhpzBKTV/ZVfhHHKIu/bKpj3sfXP2r8c8sDK0u6S JkygUSDYrODCSQkxNJJ97zUEAXQ9I6YAdYTZNHRdWY0OYD8boczFfiWeCHdDeGzk6ziux2Yg7 WTWBORR4TrvxAxH9bWVfTjK1GParEYPMbYIF8ulS4tCYKU7XjsniFBVRPtRbeug8jyZaH2yOu VjhZ526lmiwLSSsTDSJkr3Hs7d7SOmsteidU8B2z9PfWVTz8HIyp4Ax/mJzO7xZawFrPRiFH5 DpcvUS9bDt1jC7TBe1yUGZ2MNGZLetFeQWbVGaPElPsrFskPumsMNFssEguonaE74fm8MTNel 3Mty9MJC4tRa+bkbLu3gi0iidCgf62cOSs06UXAa5B+qNWOp7aAqnAG7lb5P2gWjYkcqJdk3V 7FywLrJTMoprIeoodK/j0IzDrrNJsX8jqee/PAJsnKSY6y7NoFusQtIeC6tqhQIfCTCdTHum8 cc7dguMp/9rB4poxl6nHk3JcJw8XClDyczM8ESk/VzdBKnFvTfgwWskvtZUXKhGNqRMoxBI23 0ReEgT4X1HcfCLHsDonv34Rc2mlXHNcxUgpCh3rgIt9FXvB9j6Fk2R4ASbv8NvdKOCGHA4gwm 09URQseZdErtvVB6VFM5lztlSApwjQ4QN8iqGG1KZW7+0XM3ONIgevGV//MXUooZLtqRy9ejs Ytwg6/AkQjXBACRNsyI8ZtygV7NZMO0f9v4BZxrOS/QKii92UxTp07drBtupadbWyI3713kD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:263198 Archived-At: > diff --git a/lisp/window.el b/lisp/window.el > index a11b1a5..6777944 100644 > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -8941,7 +8941,9 @@ switch-to-buffer > "Cannot switch buffers in a dedicated window"))) > ('pop nil) > (_ (set-window-dedicated-p nil nil) 'force-same-window))))))) > - (list (read-buffer-to-switch "Switch to buffer: ") nil force-same-window))) > + (save-selected-window > + (list > + (read-buffer-to-switch "Switch to buffer: ") nil force-same-window)))) > (let ((buffer (window-normalize-buffer-to-switch-to buffer-or-name)) > (set-window-start-and-point (not switch-to-buffer-obey-display-actions))) > (cond That wouldn't help in all other use cases of read_minibuf where the user will be thrown back to the minibuffer window as well. I'd rather try (the still timid) -static void minibuffer_unwind (void); +static void minibuffer_unwind (Lisp_Object); ... - record_unwind_protect_void (minibuffer_unwind); + record_unwind_protect (minibuffer_unwind, selected_window); ... -minibuffer_unwind (void) +minibuffer_unwind (Lisp_Object old_selected_window) ... + if (!EQ (old_selected_window, FRAME_SELECTED_WINDOW (f))) + Fset_frame_selected_window (exp_MB_frame, window, Qnil); since the last line seems to suggest that exp_MB_frame should not be the selected frame. martin