From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#61235: 30.0.50; tree-sit: `treesit-node-check' lacks a way to tell if a node belongs to a deleted parser Date: Tue, 7 Feb 2023 19:54:03 -0800 Message-ID: <0469A0B1-784F-4C08-81C2-549CB894C9B2@gmail.com> References: <83edr3q8ez.fsf@gnu.org> <87o7q7dl4o.fsf@masteringemacs.org> <83a61rq6ck.fsf@gnu.org> <87k00uexdt.fsf@masteringemacs.org> <835yceris5.fsf@gnu.org> <87fsbievbi.fsf@masteringemacs.org> <83y1paq0pd.fsf@gnu.org> <83ilgep2ww.fsf@gnu.org> <4C7AB77E-FBB6-4F34-A73A-297243E2E3AF@gmail.com> <83fsbhpst5.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29495"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61235@debbugs.gnu.org, mickey@masteringemacs.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 08 04:55:19 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pPbYE-0007Wx-MS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Feb 2023 04:55:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pPbY0-00028N-DW; Tue, 07 Feb 2023 22:55:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pPbXz-000289-2O for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 22:55:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pPbXy-0003hO-N6 for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 22:55:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pPbXy-0007mZ-Jo for bug-gnu-emacs@gnu.org; Tue, 07 Feb 2023 22:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Feb 2023 03:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61235 X-GNU-PR-Package: emacs Original-Received: via spool by 61235-submit@debbugs.gnu.org id=B61235.167582846329858 (code B ref 61235); Wed, 08 Feb 2023 03:55:02 +0000 Original-Received: (at 61235) by debbugs.gnu.org; 8 Feb 2023 03:54:23 +0000 Original-Received: from localhost ([127.0.0.1]:54456 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPbXL-0007lW-99 for submit@debbugs.gnu.org; Tue, 07 Feb 2023 22:54:23 -0500 Original-Received: from mail-pj1-f43.google.com ([209.85.216.43]:35528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pPbXJ-0007lG-1E for 61235@debbugs.gnu.org; Tue, 07 Feb 2023 22:54:21 -0500 Original-Received: by mail-pj1-f43.google.com with SMTP id n20-20020a17090aab9400b00229ca6a4636so1038587pjq.0 for <61235@debbugs.gnu.org>; Tue, 07 Feb 2023 19:54:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=bHO1EV3d7reXUCGE4vC5j6gv0Did60jGgRHAeu31M5A=; b=KBf7uzo39z1f/RW535d1w/9i2pHXShDvT/3oV+tMlNXNol6IwbPtCkWgNk+f5dF2EY jGMPEcveGk8NlFi0BnTlVsg+hItuVKyjitqhkNmNDPBmqYeqvRsmR0C/+Slbq3W2CFJJ j/rBUj0wD0s8AfMZ+3CDRd0c9mdJJargYJg7H9hIXWNF5fbgtKJE0nfkbi0xifze9diE C6s8giTJpJxQ/up7Qm537zMTGEV+Zfhf2xTXjiWevC8ie/hwh0avjXk+NbMkGatclVBB UNXCc9Z9r/rhNnL8xZsBhodLYkrjeGwnhJz0kqfFXw8CNgXnWS85C5ara73CTICrTeZx rfAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bHO1EV3d7reXUCGE4vC5j6gv0Did60jGgRHAeu31M5A=; b=RFJzfuzmMTgR/zVxUbLYQ0YpAOi+OPmnQxJtI/k0kx+ScKsDab4gxLVwPLMNXfMu2o /K7QF0hfgSHbhnlkliLtRSjU6vyBSsrokrwoPRuKZHsaZDivoqpHxh5M3hwcZ6pT3ulw cVFGqLO06iPJF2Y919vLVSLrpEo7t3migc5qlroyYGBrZLycymth6Vj75l5C1CJXf3yT QoDZstsAINRm9dZWqSf6MZKrehxisONJzfwIv00Cqy/dKeaSKbH3HiouktGE6jjUwCuN SbLsHTAACwZ9FT53UkuXd8ckNI5otuOwEb2B/uy9t2yQ6bqXd2z+dkJQuzznpNjYyDmo WzFg== X-Gm-Message-State: AO0yUKUfLv/rs3rLV3IUyFr+cq/NHd2rl7Rnt3bNHtMVoaUte0GlaOyl 7J2GcAI+Q+PX0OqXGMssZKI= X-Google-Smtp-Source: AK7set+GBwkZtHjLxfG7S6XHsB5DZ4FD5pzwKD4dMf7Waat4md2n3XJ0wiEDMBsJTzyC3FZHDat++w== X-Received: by 2002:a17:903:234a:b0:199:2353:1eff with SMTP id c10-20020a170903234a00b0019923531effmr6858110plh.21.1675828455342; Tue, 07 Feb 2023 19:54:15 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id je12-20020a170903264c00b00198e663a856sm8675385plb.205.2023.02.07.19.54.14 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Feb 2023 19:54:15 -0800 (PST) In-Reply-To: <83fsbhpst5.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255099 Archived-At: > On Feb 7, 2023, at 4:24 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Mon, 6 Feb 2023 20:55:38 -0800 >> Cc: Mickey Petersen , >> 61235@debbugs.gnu.org >>=20 >>>>> Yuan, any reason not to extend treesit-node-check instead? >>>>=20 >>>> I did extend treesit-node-check in the patch. But I also added a = function treesit-parser-live-p, which makes the same check but directly = on a parser. It just made sense to me that if we let treesit-node-check = check the nodes=E2=80=99 parser=E2=80=99s status, we=E2=80=99d also add = a function to allow directly checking the status of a parser. >>>=20 >>> That additional function would signal an error in the case discussed >>> here, so I'm not sure we should add it in that shape, or at all. = Why >>> isn't treesit-node-check enough? >>=20 >> Oops, it shouldn=E2=80=99t have. The updated patch fixes that. = Treesit-node-check is enough, it just made more sense = implentattion-wise, to implement that function that checks a parser, and = let treesit-node-check use that function to check the node=E2=80=99s = parser. We can choose to not expose that function, and only expose this = feature through treesit-node-check, if you prefer so. >=20 > I think treesit-node-check alone should be enough. Cool, I=E2=80=99ll only modify treesit-node-check, then. >=20 > One comment: >=20 >> @@ -1943,9 +1959,11 @@ DEFUN ("treesit-node-check", >> result =3D ts_node_is_extra (treesit_node); >> else if (EQ (property, Qhas_error)) >> result =3D ts_node_has_error (treesit_node); >> + else if (EQ (property, Qlive)) >> + result =3D Ftreesit_parser_live_p (XTS_NODE (node)->parser); >=20 > Ftreesit_parser_live_p returns a Lisp object, whereas 'result' is a C > 'bool' type. This won't compile if you configure with > "--enable-check-lisp-object-type=E2=80=9D. Right, sorry :-( Yuan