From: Dmitry Gutov <dgutov@yandex.ru>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 22923@debbugs.gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>
Subject: bug#22923: [PATCH] Support completion of attribute values in CSS mode
Date: Fri, 11 Mar 2016 03:25:41 +0200 [thread overview]
Message-ID: <0400ddb1-6995-eb93-2dde-c7d5a5a992b0@yandex.ru> (raw)
In-Reply-To: <1457550112.3805.2@smtp.gmail.com>
On 03/09/2016 09:01 PM, Simen Heggestøyl wrote:
> There are two lists that must be traversed to find completion
> candidates: the property alist and the value class alist. company-css.el
> supports indirections from the property alist into itself, and into the
> value class alist. With this patch, indirection can happen from the
> property alist into itself and into the value class alist, but also from
> the value class alist into itself and back into the property alist.
I see. Is there anything in particular this approach is buying us? Any
properties that company-css doesn't support now, and would be suboptimal
using its current approach?
IMHO, having the indirection go only one way is better organization, and
it's easier to understand when reading the code.
> With the change mentioned above, the property alist and the value class
> alist are now treated like the same kind of data structure by
> `css--property-values'. The only difference is that the CARs of the
> entries in the property alist are also valid property names. So I
> thought it simpler if the keys were of the same data type. I don't have
> an opinion on whether that should be string or symbol, just that they
> are the same.
>
> Did this answer your question?
Yes, thanks.
next prev parent reply other threads:[~2016-03-11 1:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-06 13:53 bug#22923: [PATCH] Support completion of attribute values in CSS mode Simen Heggestøyl
2016-03-06 19:10 ` Dmitry Gutov
2016-03-09 19:01 ` Simen Heggestøyl
2016-03-11 1:25 ` Dmitry Gutov [this message]
2016-03-19 12:42 ` Simen Heggestøyl
2016-03-20 1:17 ` Dmitry Gutov
2016-03-21 9:14 ` Simen Heggestøyl
2016-03-21 11:02 ` Dmitry Gutov
2016-03-23 18:17 ` Simen Heggestøyl
2016-03-23 23:08 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0400ddb1-6995-eb93-2dde-c7d5a5a992b0@yandex.ru \
--to=dgutov@yandex.ru \
--cc=22923@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=simenheg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).