From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src Date: Thu, 2 Aug 2018 07:41:38 -0700 Organization: UCLA Computer Science Department Message-ID: <03ee75fd-294d-ad72-48e8-9d8ad6ef480b@cs.ucla.edu> References: <20180717234729.15507-1-eggert@cs.ucla.edu> <83va9c33kk.fsf@gnu.org> <15823bbe-8298-0d69-c7a6-edf2001e4513@cs.ucla.edu> <83lg9ovp7u.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1533222680 22504 195.159.176.226 (2 Aug 2018 15:11:20 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Thu, 2 Aug 2018 15:11:20 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: 32194@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Aug 02 17:11:15 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flFFx-0005iQ-Rs for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Aug 2018 17:11:14 +0200 Original-Received: from localhost ([::1]:46200 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flFI2-0006mn-RU for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Aug 2018 11:13:22 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34347) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1flEnl-0004e3-3p for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:42:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1flEni-0004Na-1e for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:42:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:34075) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1flEnh-0004NP-RP for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:42:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1flEnh-0003uH-L2 for bug-gnu-emacs@gnu.org; Thu, 02 Aug 2018 10:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Aug 2018 14:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 32194 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 32194-submit@debbugs.gnu.org id=B32194.153322091115002 (code B ref 32194); Thu, 02 Aug 2018 14:42:01 +0000 Original-Received: (at 32194) by debbugs.gnu.org; 2 Aug 2018 14:41:51 +0000 Original-Received: from localhost ([127.0.0.1]:39093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flEnW-0003tq-5l for submit@debbugs.gnu.org; Thu, 02 Aug 2018 10:41:51 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:34718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1flEnU-0003td-Dy for 32194@debbugs.gnu.org; Thu, 02 Aug 2018 10:41:49 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3A9EC160EC1; Thu, 2 Aug 2018 07:41:42 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id zMnmnYoYj8K6; Thu, 2 Aug 2018 07:41:41 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7DA3A160F6D; Thu, 2 Aug 2018 07:41:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id zFdz393wR0pP; Thu, 2 Aug 2018 07:41:41 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 3B0FB160EC1; Thu, 2 Aug 2018 07:41:41 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: <83lg9ovp7u.fsf@gnu.org> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:149209 Archived-At: Eli Zaretskii wrote: > I thought that using >=20 > #include "regex.h" >=20 > in src/regex.c should avoid any such "fights". The problem I ran into was the other way around: lib-src/etags.c and lib/= regex.c=20 say '#include ' and this grabs the wrong regex.h. Changing the=20 directives to say '#include ""' would start to diverge from glib= c=20 source, which I'd rather not do. Also, for non-POSIX compilers, the '#inc= lude=20 ""' trick might not work; it also might not work if the builder = puts=20 '-I-' in CFLAGS with GCC. The whole mess is easily avoidable by renaming=20 src/regex.h. Renaming is appropriate anyway, since the APIs are not the same, and it's= =20 confusing to have two include files with the same name.