From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 32194@debbugs.gnu.org
Subject: bug#32194: [PATCH] Use Gnulib regex for lib-src
Date: Thu, 2 Aug 2018 07:41:38 -0700 [thread overview]
Message-ID: <03ee75fd-294d-ad72-48e8-9d8ad6ef480b@cs.ucla.edu> (raw)
In-Reply-To: <83lg9ovp7u.fsf@gnu.org>
Eli Zaretskii wrote:
> I thought that using
>
> #include "regex.h"
>
> in src/regex.c should avoid any such "fights".
The problem I ran into was the other way around: lib-src/etags.c and lib/regex.c
say '#include <regex.h>' and this grabs the wrong regex.h. Changing the
directives to say '#include "<regex.h>"' would start to diverge from glibc
source, which I'd rather not do. Also, for non-POSIX compilers, the '#include
"<regex.h>"' trick might not work; it also might not work if the builder puts
'-I-' in CFLAGS with GCC. The whole mess is easily avoidable by renaming
src/regex.h.
Renaming is appropriate anyway, since the APIs are not the same, and it's
confusing to have two include files with the same name.
next prev parent reply other threads:[~2018-08-02 14:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 23:47 bug#32194: [PATCH] Use Gnulib regex for lib-src Paul Eggert
2018-07-18 16:34 ` Eli Zaretskii
2018-07-31 18:21 ` Paul Eggert
2018-08-01 0:29 ` Noam Postavsky
2018-08-01 0:59 ` Paul Eggert
2018-08-01 1:10 ` Noam Postavsky
2018-08-01 1:27 ` Paul Eggert
2018-08-02 0:58 ` Noam Postavsky
2018-08-02 1:49 ` Paul Eggert
2018-08-02 1:55 ` Noam Postavsky
2018-08-02 2:42 ` Eli Zaretskii
2018-08-02 3:19 ` Paul Eggert
2018-08-02 10:28 ` Noam Postavsky
2018-08-02 14:05 ` Eli Zaretskii
2018-08-02 14:41 ` Paul Eggert [this message]
2018-08-02 14:55 ` Eli Zaretskii
2018-08-02 15:41 ` Paul Eggert
2018-08-04 15:41 ` Eli Zaretskii
2018-08-04 23:34 ` Paul Eggert
2018-08-05 17:58 ` Eli Zaretskii
2018-08-06 2:40 ` Paul Eggert
2018-08-06 10:59 ` Andy Moreton
2018-08-06 14:52 ` Eli Zaretskii
2018-08-06 15:40 ` Andy Moreton
2018-08-06 14:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ee75fd-294d-ad72-48e8-9d8ad6ef480b@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=32194@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).