From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#56682: Fix the long lines font locking related slowdowns Date: Tue, 16 Aug 2022 00:18:35 +0300 Message-ID: <03742b06-6053-fb75-8873-8d355fd1f71b@yandex.ru> References: <92da07bd02941d5537e9@heytings.org> <5308e3b5-a160-17d7-77ee-b1d00acfa20d@yandex.ru> <92da07bd02a6cc861e1a@heytings.org> <837d3lzv8n.fsf@gnu.org> <2c8d6755-cfe2-6559-3fde-3fa30ffb411e@yandex.ru> <83mtcgy44k.fsf@gnu.org> <83k07jx5jn.fsf@gnu.org> <866e510d-a060-7daa-d002-97861d056fa7@yandex.ru> <1144021660321893@iva5-64778ce1ba26.qloud-c.yandex.net> <12348081660379417@sas2-a098efd00d24.qloud-c.yandex.net> <66bbbb95983414e79637@heytings.org> <83wnb9hadb.fsf@gnu.org> <395454dd-7238-c5d0-e924-2f65a186baa7@yandex.ru> <83r11hh4pm.fsf@gnu.org> <83k079gy4h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------pLQNIg0oRp034t0tyjTV8GSX" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7192"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 23:19:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNhUM-0001dm-8M for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 23:19:10 +0200 Original-Received: from localhost ([::1]:57234 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNhUL-0006Yu-AO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 17:19:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNhUE-0006Ym-4h for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 17:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54487) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNhUD-0001KA-Qp for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 17:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNhUD-0007bQ-Lx for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 17:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 21:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56682 X-GNU-PR-Package: emacs Original-Received: via spool by 56682-submit@debbugs.gnu.org id=B56682.166059832629203 (code B ref 56682); Mon, 15 Aug 2022 21:19:01 +0000 Original-Received: (at 56682) by debbugs.gnu.org; 15 Aug 2022 21:18:46 +0000 Original-Received: from localhost ([127.0.0.1]:44236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNhTx-0007ax-E2 for submit@debbugs.gnu.org; Mon, 15 Aug 2022 17:18:45 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:43631) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNhTv-0007ai-Ew for 56682@debbugs.gnu.org; Mon, 15 Aug 2022 17:18:44 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id ay39-20020a05600c1e2700b003a5503a80cfso4475332wmb.2 for <56682@debbugs.gnu.org>; Mon, 15 Aug 2022 14:18:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:from:to:cc; bh=E3xbtIrUEY6mlHI20AaIiFGXzGdhldz+gXdAJWceVOE=; b=HVPKUDQBHI2iJi7RHD0FYxDHeMoQcxqbREPIk7/CbuTyHgK/8BC8kAuVSCKjaQnnoO UeqTHBvu9USij+xhBXAZUOPK7sAjbZmBnCA/wuR3DCRMcvUHuChxoF8Ov31xGpqn8dOb h6nt3gm7e1XsFBRfWT0yJbEdECeKebh1bCz5CjTuSdnRqttYUz2F0w0e9LbG/z7QEeqy WYqATELerxRpbV2ybsQ9dodBhKN3Zq14QK5nkP5xkGTfYVeghBwetz4hNlx/tV9rcg7t iC1fJhGFB+KSjxGEQMUS7azpXGDbMoH1YgUIB+R/L2d9Mzqkc5SGFKOFCfsnwKTn0Qqg nK2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc; bh=E3xbtIrUEY6mlHI20AaIiFGXzGdhldz+gXdAJWceVOE=; b=NV3swvFyAGgcyEWshdsM15q2T+rUD+mhAthsUZNhIe1oIIupWEBkeE1XdOOueTIPHG S/dr889SBHAxpZ0irJ3k9tdQ/Gt1eW/TiUE6ks+XkC6MYWoSFhV6ldyrSZagSiON49Qi HUDNNjMgu+B5VSAm2gak56RAG5RE5ZMc9hTYWcOgJesv88OZ1ocwtlC9bBD7CD1JT20f QDNL+v/TBQow9jlM52wluhRCwehRCeIOK+924HhRhnNEjDd6tXTsoEGE2rjnbXd1p+IV a/1X4KTgHYNgnbBS0bGtZqhoWBsiIAhn7nsRrGy09whUv1dRU0uQkMcXRSfCtdfnvc2w 9ohQ== X-Gm-Message-State: ACgBeo3kQ8gM7bPyS5FxDIaAGY3hOTylpv74mHuRCFv2LFYlL+BV4VHZ mnVazT0nl5DOXQVDoIDKAGI= X-Google-Smtp-Source: AA6agR4n4gUnP9zBIkS/Y1XJLSq0MOEGEUnm4wPR4xLIj6L2ENU8VrIzle8J9FNnLNFHh6c+cRFCog== X-Received: by 2002:a05:600c:4fcb:b0:3a5:f2cc:2f19 with SMTP id o11-20020a05600c4fcb00b003a5f2cc2f19mr4424074wmq.142.1660598317812; Mon, 15 Aug 2022 14:18:37 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id c6-20020a05600c0a4600b003a31fd05e0fsm451222wmq.2.2022.08.15.14.18.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Aug 2022 14:18:37 -0700 (PDT) Content-Language: en-US In-Reply-To: <83k079gy4h.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239843 Archived-At: This is a multi-part message in MIME format. --------------pLQNIg0oRp034t0tyjTV8GSX Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 15.08.2022 21:28, Eli Zaretskii wrote: >> Date: Mon, 15 Aug 2022 21:17:23 +0300 >> Cc: 56682@debbugs.gnu.org, gregory@heytings.org, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >>>> I'm pretty sure that doing all that in Lisp is a good thing, and would >>>> be conducive to whatever improvements we might want to add later... >>> >>> No, because quite a few packages use jit-lock-register to run stuff >>> that is not font-lock at all, and I don't want that to slow down >>> redisplay when long lines are involved. And trying various values of >>> a variable exposed to Lisp is easy enough. >> >> It should also be possible to move the whole invocation of the >> fontification-functions up to Lisp > > How do you do that, given that these functions should be called from > redisplay with the region of buffer text only redisplay knows about? Something like in the attached patch. >> Another reason I chose font-lock-fontify-region, though, is that it's >> called from different places. It's the common entry point for font-lock. > > I have no problem with doing something similar in font-lock, I'm just > saying that it cannot be the only place. If we apply narrowing in handle_fontified_prop (or like in the attachment), and also in font-lock-fontify-region, it seems like every significant (*) execution path will go through two repetitions of the same logic. That's not ideal. (*) Significant by the metric of having impact on Emacs's performance, in large files especially. >> I've never seen fontification-functions contain anything but >> jit-lock-function, but jit-lock-functions is used by nlinum, for >> instance. And bug-reference-mode, and goto-address-mode. Perhaps we >> should ask Stefan's opinion on this. > > Stefan was and is on the CC list for the entire discussion. > >> And nlinum might not appreciate being narrowed. It seems to be working >> okay without that in my 20 MB XML file. And in 200 MB one too. > > Why is it important what nlinum does, when we have native line numbers > nowadays? Just an example of a mode which uses jit-lock-functions. With an implication that other, less known modes, might have similar needs and behavior. There aren't too many known examples. --------------pLQNIg0oRp034t0tyjTV8GSX Content-Type: text/x-patch; charset=UTF-8; name="run-fontification-functions.diff" Content-Disposition: attachment; filename="run-fontification-functions.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3AvZm9udC1jb3JlLmVsIGIvbGlzcC9mb250LWNvcmUuZWwKaW5k ZXggZjcwYzQyYmIwMy4uMDllNTViY2ZiMSAxMDA2NDQKLS0tIGEvbGlzcC9mb250LWNvcmUu ZWwKKysrIGIvbGlzcC9mb250LWNvcmUuZWwKQEAgLTI2Niw2ICsyNjYsMTIgQEAgdHVybi1v bi1mb250LWxvY2staWYtZGVzaXJlZAogICAgIChsZXQgKGluaGliaXQtcXVpdCkKICAgICAg ICh0dXJuLW9uLWZvbnQtbG9jaykpKSkKIAorKGRlZnVuIHJ1bi1mb250aWZpY2F0aW9uLWZ1 bmN0aW9ucyAocG9zKQorICA7OyBYWFg6IEFwcGx5IG5hcnJvd2luZyBhcm91bmQgaGVyZS4K KyAgOzsgKHBjYXNlLWV4aGF1c3RpdmUgZm9udC1sb2NrLWxhcmdlLWZpbGVzCisgIDs7ICAg Li4uKQorICAocnVuLWhvb2std2l0aC1hcmdzICdmb250aWZpY2F0aW9uLWZ1bmN0aW9ucyBw b3MpKQorCiAoZGVmaW5lLWdsb2JhbGl6ZWQtbWlub3ItbW9kZSBnbG9iYWwtZm9udC1sb2Nr LW1vZGUKICAgZm9udC1sb2NrLW1vZGUgdHVybi1vbi1mb250LWxvY2staWYtZGVzaXJlZAog ICA7OyBXaGF0IHdhcyB0aGlzIDpleHRyYS1hcmdzIHRoaW5neSBmb3I/ICAtLVN0ZWYKZGlm ZiAtLWdpdCBhL3NyYy94ZGlzcC5jIGIvc3JjL3hkaXNwLmMKaW5kZXggMWU4ZjcwYjJkYi4u Y2U5MGFlZWZiYyAxMDA2NDQKLS0tIGEvc3JjL3hkaXNwLmMKKysrIGIvc3JjL3hkaXNwLmMK QEAgLTQzODEsNTMgKzQzODEsMTggQEAgaGFuZGxlX2ZvbnRpZmllZF9wcm9wIChzdHJ1Y3Qg aXQgKml0KQogCSAgTklMUCAocHJvcCkgJiYgSVRfQ0hBUlBPUyAoKml0KSA8IFopKQogICAg IHsKICAgICAgIHNwZWNwZGxfcmVmIGNvdW50ID0gU1BFQ1BETF9JTkRFWCAoKTsKLSAgICAg IExpc3BfT2JqZWN0IHZhbDsKICAgICAgIHN0cnVjdCBidWZmZXIgKm9idWYgPSBjdXJyZW50 X2J1ZmZlcjsKICAgICAgIHB0cmRpZmZfdCBiZWd2ID0gQkVHViwgenYgPSBaVjsKICAgICAg IGJvb2wgb2xkX2NsaXBfY2hhbmdlZCA9IGN1cnJlbnRfYnVmZmVyLT5jbGlwX2NoYW5nZWQ7 CiAgICAgICBib29sIHNhdmVkX2luaGliaXRfZmxhZyA9IGl0LT5mLT5pbmhpYml0X2NsZWFy X2ltYWdlX2NhY2hlOwogCi0gICAgICB2YWwgPSBWZm9udGlmaWNhdGlvbl9mdW5jdGlvbnM7 Ci0gICAgICBzcGVjYmluZCAoUWZvbnRpZmljYXRpb25fZnVuY3Rpb25zLCBRbmlsKTsKLQog ICAgICAgZWFzc2VydCAoaXQtPmVuZF9jaGFycG9zID09IFpWKTsKIAogICAgICAgLyogRG9u J3QgYWxsb3cgTGlzcCB0aGF0IHJ1bnMgZnJvbSAnZm9udGlmaWNhdGlvbi1mdW5jdGlvbnMn CiAJIGNsZWFyIG91ciBmYWNlIGFuZCBpbWFnZSBjYWNoZXMgYmVoaW5kIG91ciBiYWNrLiAg Ki8KICAgICAgIGl0LT5mLT5pbmhpYml0X2NsZWFyX2ltYWdlX2NhY2hlID0gdHJ1ZTsKIAot ICAgICAgaWYgKCFDT05TUCAodmFsKSB8fCBFUSAoWENBUiAodmFsKSwgUWxhbWJkYSkpCi0J c2FmZV9jYWxsMSAodmFsLCBwb3MpOwotICAgICAgZWxzZQotCXsKLQkgIExpc3BfT2JqZWN0 IGZucywgZm47Ci0KLQkgIGZucyA9IFFuaWw7Ci0KLQkgIGZvciAoOyBDT05TUCAodmFsKTsg dmFsID0gWENEUiAodmFsKSkKLQkgICAgewotCSAgICAgIGZuID0gWENBUiAodmFsKTsKLQot CSAgICAgIGlmIChFUSAoZm4sIFF0KSkKLQkJewotCQkgIC8qIEEgdmFsdWUgb2YgdCBpbmRp Y2F0ZXMgdGhpcyBob29rIGhhcyBhIGxvY2FsCi0JCSAgICAgYmluZGluZzsgaXQgbWVhbnMg dG8gcnVuIHRoZSBnbG9iYWwgYmluZGluZyB0b28uCi0JCSAgICAgSW4gYSBnbG9iYWwgdmFs dWUsIHQgc2hvdWxkIG5vdCBvY2N1ci4gIElmIGl0Ci0JCSAgICAgZG9lcywgd2UgbXVzdCBp Z25vcmUgaXQgdG8gYXZvaWQgYW4gZW5kbGVzcwotCQkgICAgIGxvb3AuICAqLwotCQkgIGZv ciAoZm5zID0gRmRlZmF1bHRfdmFsdWUgKFFmb250aWZpY2F0aW9uX2Z1bmN0aW9ucyk7Ci0J CSAgICAgICBDT05TUCAoZm5zKTsKLQkJICAgICAgIGZucyA9IFhDRFIgKGZucykpCi0JCSAg ICB7Ci0JCSAgICAgIGZuID0gWENBUiAoZm5zKTsKLQkJICAgICAgaWYgKCFFUSAoZm4sIFF0 KSkKLQkJCXNhZmVfY2FsbDEgKGZuLCBwb3MpOwotCQkgICAgfQotCQl9Ci0JICAgICAgZWxz ZQotCQlzYWZlX2NhbGwxIChmbiwgcG9zKTsKLQkgICAgfQotCX0KKyAgICAgIHNhZmVfY2Fs bDEgKGludGVybiAoInJ1bi1mb250aWZpY2F0aW9uLWZ1bmN0aW9ucyIpLCBwb3MpOwogCiAg ICAgICBpdC0+Zi0+aW5oaWJpdF9jbGVhcl9pbWFnZV9jYWNoZSA9IHNhdmVkX2luaGliaXRf ZmxhZzsKICAgICAgIHVuYmluZF90byAoY291bnQsIFFuaWwpOwo= --------------pLQNIg0oRp034t0tyjTV8GSX--