bug#11506: bug: "C-x z" ("repeat") no longer works correctly with M-x

bug#11506: bug: "C-x z" ("repeat") no longer works correctly with M-x

[Stefan Monnier]

> The problem is that the old execute-extended-command sets the
> real_this_command internal variable, which causes the Emacs command loop
> to record the command that was actually executed into real-last-command
> and last-repeatable-command.

Indeed.

> In other words, it's not just the fact that `C-x z' doesn't work
> properly.  Moving execute-extended-command to Lisp produces a
> backward-incompatible change in the values of the real-last-command and
> last-repeatable-command variables for M-x.  I suspect this may break
> things other than `C-x z'.  I guess we could fix this by exposing
> real_this_command to Lisp too, but that kinda defeats the point of that
> variable...

I don't see why this would defeat anything.  Clearly,
execute-extended-command demonstrates that there can be very good
reasons to change real-this-command.
I installed a change that does just that.

> Is there a strong rationale for moving execute-extended-command to Lisp,
> other than the general principle that we want as much functionality
> implemented Lisp as possible?

To me, an important part of moving code to Elisp is to make sure that it
*can* be implemented in Elisp (i.e. that some third-party package can
provide a new implementation of that functionality).


        Stefan

bug#11506: bug: "C-x z" ("repeat") no longer works correctly with M-x

[Drew Adams]

Is there a problem with the automatic mailing of bug-thread messages, or is
there perhaps a problem with my mail server?

I sent two messages to this bug thread, and never received those mails from the
bug list.  But they showed up on the archive site OK:
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11506#15
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11506#17

Similarly, I received Stefan's reply to the first of these directly from him,
but I did not receive his message from the bug address.

If there is a mail problem at the Emacs BUGS end, is it perhaps only for the
<N>-done@debbugs.gnu.org address?  If so, can that please be fixed?  Whatever
discussion continues in a bug thread should be echoed to the bug mailing list,
no?

If not, I will no doubt have to manually remove "-done" from the cc address from
now on (or else add the address without "-done", in addition to "-done").

Users do not pay a lot of attention to the cc addresses when they hit `Reply
All'.  This bug server automatically changes the address from
<N>@debbugs.gnu.org to <N>-done@debbugs.gnu.org, which is arguably not very user
friendly to begin with (changing recipient lists is not a great idea).

If we cannot figure out a better way to handle routing/classifying messages than
simply changing addresses, too bad.  But can't we at least continue to echo the
discussion to <N>@debbugs.gnu.org (as well as cc or bcc it to
<N>-done@debbugs.gnu.org), so that readers of the thread receive the message?

The classification of a bug is not the same thing as the end of the discussion
of it.