From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#65470: 29.1.50; js-ts-mode: regex pattern can cause incorrect parenthesis matching Date: Thu, 31 Aug 2023 14:15:22 +0300 Message-ID: <03415a27-f082-b204-cece-19a9859e178d@gutov.dev> References: <127B5BEA-A24B-48A3-9827-85B7CDB67D10@secure.kjonigsen.net> <5f823f8f-d249-f4a1-71e6-083e47d0d123@gutov.dev> <83jztbeeh2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30158"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: casouri@gmail.com, 65470@debbugs.gnu.org, theo@thornhill.no, jostein@secure.kjonigsen.net, btuin@mailo.com, jostein@kjonigsen.net To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 31 13:16:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbfei-0007eM-SB for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Aug 2023 13:16:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbfeZ-0000MV-4W; Thu, 31 Aug 2023 07:15:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbfeU-0000M5-0Q for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 07:15:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbfeT-0003r4-P4 for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 07:15:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbfeb-0008JE-Ql for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 07:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 11:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65470 X-GNU-PR-Package: emacs Original-Received: via spool by 65470-submit@debbugs.gnu.org id=B65470.169348054231913 (code B ref 65470); Thu, 31 Aug 2023 11:16:01 +0000 Original-Received: (at 65470) by debbugs.gnu.org; 31 Aug 2023 11:15:42 +0000 Original-Received: from localhost ([127.0.0.1]:55059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbfeH-0008Id-Lp for submit@debbugs.gnu.org; Thu, 31 Aug 2023 07:15:42 -0400 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45305) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbfeF-0008IR-Hh for 65470@debbugs.gnu.org; Thu, 31 Aug 2023 07:15:40 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 46B4C5C018E; Thu, 31 Aug 2023 07:15:26 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 31 Aug 2023 07:15:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1693480526; x=1693566926; bh=GuD2UeTCAByt1JZEqSIRdCLkada5ZzB4ZiF 31+EzPiU=; b=O2WCVx6eK0L72GHDDcZ7R/VUiLo6kwBHo9XLQTn+hYxWJhKk4X9 UVsACMoMrGh45W4MsZf+Dg3hlveX830L+EpcPy3qRdh4U+PSawpqGlwOlF6Hgity +BAPd+E5wDo+hLtBcnoWCy4ifiHuzBIoZ049WbIMFFCdc2VYoirfhFBkja2INjTK PP4pUYeEyDWH1ssLlGAUvGtd874AKtOywBxxlmd51bGFRiB313iA6XFeEWRCCVIL 2vUq7v4yzZ0arCAHj25Ja6qliMcrjZWUCPwbbx/Fsc/EgmKGVy4OEGXh/ow0tBn+ zjCHT3cn9+5pRifiY/EKWP7gYRiEH7sED+Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1693480526; x=1693566926; bh=GuD2UeTCAByt1JZEqSIRdCLkada5ZzB4ZiF 31+EzPiU=; b=AKzqhwwr5nD2MeO2nW3cMoL071flTmETHqhOCownSYNGX2h9NWr pWliqsmc4i2MXirePGApDOLPj81VBzAENtPesik3qhTvFL/YOvbtJOR+MAmg+8La 6t33cwNFBRu4QiaP4l/c3+za0pldK8ByzEy//U7aFYJKKQCZj8ZmOJQ5sHto7wbd Q4mo2Y+RVmNbKHM4imFkXxvYyndZETvhhmHAnXgCvUoKFygltpmwhHshbq9jgCWb UEGon2wbSHN07Ws6/DD/IKILC9qmDB+qjOhvidJXKG9IYmrcqj7sdEv0ChfUvWmk jJZh+MKPGnceGuXllvXkFyYBsezO9gc2hkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrudegtddgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtkeertddtfeejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhephfffheeljeffgeffueeghfekkedtfffgheejvdegjeettdduheeufffggfef jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 31 Aug 2023 07:15:24 -0400 (EDT) Content-Language: en-US In-Reply-To: <83jztbeeh2.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268812 Archived-At: On 31/08/2023 12:41, Eli Zaretskii wrote: >> Date: Sun, 27 Aug 2023 00:45:19 +0300 >> Cc: Theodor Thornhill, Eli Zaretskii, >> Jostein Kjønigsen,btuin@mailo.com, >> 65470@debbugs.gnu.org >> From: Dmitry Gutov >> >> On 27/08/2023 00:13, Jostein Kjønigsen wrote: >>> I don’t really work with JSX and don’t think have a “idiomatic” code base to try it on where I would notice brokenness. >>> >>> I think this would be better handled by people more experienced with both JSX and our JSX code base than I am. >> Just checking that viewing some JSX code in .tsx files doesn't show >> errors in Messages might be good enough. >> >> I tried that with javascript, didn't notice any problems so far. > I'm a bit confused by this discussion. Should I install the patch on > the emacs-29 branch now, or are you still discussing whether it's > correct? I think we were discussing the typescript modes here. Personally I was waiting for some additional confirmation that my v2 for js-ts-mode is correct, but I guess we have a silent approval, so we can install it.