From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#53371: 28.0.90; eshell completion error when trying to complete buffer name, args-out-of-range Date: Sat, 11 Mar 2023 19:35:34 -0800 Message-ID: <033b4070-cc23-5b54-db62-78fe154cebb1@gmail.com> References: <7b725604-e2ea-f193-0899-4e72a348fdf9@daniel-mendler.de> <8a8d563f-738e-7a03-6e9c-700ab5bf7365@gmail.com> <9306144c-afbd-efcd-a90b-f22c32753a72@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33178"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 53371-done@debbugs.gnu.org, mail@daniel-mendler.de To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Mar 12 04:36:32 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pbCVc-0008Te-A2 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 12 Mar 2023 04:36:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pbCVB-0003Qi-Sn; Sat, 11 Mar 2023 22:36:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pbCV9-0003MH-Fe for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 22:36:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pbCV8-0005pO-7l for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 22:36:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pbCV7-0001DQ-V5 for bug-gnu-emacs@gnu.org; Sat, 11 Mar 2023 22:36:01 -0500 Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sun, 12 Mar 2023 03:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 53371 X-GNU-PR-Package: emacs Mail-Followup-To: 53371@debbugs.gnu.org, jporterbugs@gmail.com, mail@daniel-mendler.de Original-Received: via spool by 53371-done@debbugs.gnu.org id=D53371.16785921444646 (code D ref 53371); Sun, 12 Mar 2023 03:36:01 +0000 Original-Received: (at 53371-done) by debbugs.gnu.org; 12 Mar 2023 03:35:44 +0000 Original-Received: from localhost ([127.0.0.1]:58891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbCUp-0001Cs-Lb for submit@debbugs.gnu.org; Sat, 11 Mar 2023 22:35:43 -0500 Original-Received: from mail-pj1-f46.google.com ([209.85.216.46]:43910) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pbCUn-0001Ce-W5 for 53371-done@debbugs.gnu.org; Sat, 11 Mar 2023 22:35:42 -0500 Original-Received: by mail-pj1-f46.google.com with SMTP id y15-20020a17090aa40f00b00237ad8ee3a0so8651691pjp.2 for <53371-done@debbugs.gnu.org>; Sat, 11 Mar 2023 19:35:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678592136; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=K3n3Y/YPN+A9bEWaPoPi209UXM72UEnDjy/6Kef702A=; b=me/2om1wUmzwMXIwTSgV/0zqtcImRShZGIwps921jDvSUazOTELJA9B+ifooM4zu8d EAMgvOtJweRZ3/WyufpTSJ/ftsBw9EpYTf+AbACd1ASpfqOOEH0bEA+7vyeYnS+y/MsT 8FOaBsP+aYaREainiRWbudz/xIIPSLjURh3HHm62kt2NOE37A/BmICIP+hGmYA7wE3sY wwhII6A9vSPL7FS31jtyqb54GzTpIPpm0loGklkPTSM7r+cQ1wADDy2Tkl6sIM3ichCN Sjq8WiTKTQmgjYG6pK4oVN7i3MBvY8RqzUeR/jGDN+6r35cIUz5bkfAITtShmoJYKasm wrrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678592136; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K3n3Y/YPN+A9bEWaPoPi209UXM72UEnDjy/6Kef702A=; b=cF1HeY9L3hQIrdS8h4mDmntj/80NnMfgvahouH4SO/nzR9JvvgM/Q/GvgEAtqTR6QQ Mf/FG6ZIMt6GocD1/nIOl0Ct0Lu3shboWWipPhshD3zoM1YmqD1z1LUvbfJ7euvW+ofc 0secKREx+yvgDiksU8Hv7gW3WswrIevajIryjHiqwh1ku0Tc6kE6MfnuTcYNS+buIPup ElvT+nYUxkl6lr462tG/J1qP55smgs3fRmOczjg2HI8rwTYrFY9N34WfYFQjuB7gE6O5 QzfQO/6fCrv8013lnZbWO5QMJ/7ZgejWO7tg74oxARNFNQQsgLh3a1jDkKerNm7L/cq9 FQsw== X-Gm-Message-State: AO0yUKXiu5T6ofhi7EV04bdy2LL5c0P42E/xlSP9w7uYRhyxzR6xePL0 RxGrCDnvEnK3EzhnOqXNtO6r9YL0EKU= X-Google-Smtp-Source: AK7set8ZIdHMKXs2UNJaXQZQmpZv0bfq7v9DyvYp9KG96AaMPTFmI4I6Vomrn+bbacvo2ZXMyU3bCQ== X-Received: by 2002:a17:90b:4a83:b0:234:a9df:db96 with SMTP id lp3-20020a17090b4a8300b00234a9dfdb96mr31140499pjb.33.1678592135727; Sat, 11 Mar 2023 19:35:35 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id jg19-20020a17090326d300b0019a7c890c5asm2112380plb.263.2023.03.11.19.35.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 19:35:35 -0800 (PST) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257831 Archived-At: On 2/24/2023 9:53 AM, Jim Porter wrote: > On 2/24/2023 7:09 AM, Stefan Monnier via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >>> +      (let ((buffer-p (if (match-beginning 1) >>> +                          (equal (match-string 1) "buffer") >>>                           t)) ;; buffer-p is non-nil by default. >> >> The comment just describes what the code does but it would be more >> useful to explain why. > > Thanks, fixed. Since there haven't been any further comments, merged as 9199fa00caa. Closing this bug now, though if there are any remaining issues, just let me know.