From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#32189: 27.0.50; GCC 7 warning due to -Wformat-truncation=2 Date: Tue, 17 Jul 2018 15:26:34 -0400 Message-ID: <031d18cf-e661-6dea-8882-38d75924d0d4@cornell.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------9FD99D1FB873E554C8503191" X-Trace: blaine.gmane.org 1531855507 28280 195.159.176.226 (17 Jul 2018 19:25:07 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 17 Jul 2018 19:25:07 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 To: 32189@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jul 17 21:25:03 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffVap-0007Gd-9X for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 21:25:03 +0200 Original-Received: from localhost ([::1]:32793 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffVcw-0008Lc-5j for geb-bug-gnu-emacs@m.gmane.org; Tue, 17 Jul 2018 15:27:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffVco-0008LT-SB for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 15:27:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffVck-00034h-S2 for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 15:27:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ffVck-00033w-NO for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 15:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ffVck-0004pb-IH for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 15:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 17 Jul 2018 19:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32189 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.153185561218555 (code B ref -1); Tue, 17 Jul 2018 19:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 17 Jul 2018 19:26:52 +0000 Original-Received: from localhost ([127.0.0.1]:45721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffVcZ-0004pB-Ix for submit@debbugs.gnu.org; Tue, 17 Jul 2018 15:26:51 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:43228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffVcX-0004ov-B9 for submit@debbugs.gnu.org; Tue, 17 Jul 2018 15:26:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffVcR-0001c3-3K for submit@debbugs.gnu.org; Tue, 17 Jul 2018 15:26:44 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:42772) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ffVcQ-0001bT-VO for submit@debbugs.gnu.org; Tue, 17 Jul 2018 15:26:43 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffVcP-0008L2-Lf for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 15:26:42 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ffVcL-0001Nh-MF for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 15:26:41 -0400 Original-Received: from limerock02.mail.cornell.edu ([128.84.13.242]:50706) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ffVcL-0001J8-DR for bug-gnu-emacs@gnu.org; Tue, 17 Jul 2018 15:26:37 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock02.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w6HJQZ7M026838 for ; Tue, 17 Jul 2018 15:26:35 -0400 Original-Received: from [128.84.234.242] (dhcp242.math.cornell.edu [128.84.234.242]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w6HJQYBN022320 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT) for ; Tue, 17 Jul 2018 15:26:34 -0400 Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=X X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:148619 Archived-At: This is a multi-part message in MIME format. --------------9FD99D1FB873E554C8503191 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by limerock02.mail.cornell.edu id w6HJQZ7M026838 I'm getting the following warning when building the master branch on=20 Cygwin with GCC 7.3: In file included from /usr/include/stdio.h:800:0, from ../lib/stdio.h:43, from ../../master/src/w32cygwinx.c:22: ../../master/src/w32cygwinx.c: In function =E2=80=98Fw32_battery_status=E2= =80=99: ../../master/src/w32cygwinx.c:116:26: warning: =E2=80=98%3.1f=E2=80=99 di= rective output=20 may be truncated writing between 3 and 312 bytes into a region of size=20 16 [-Wformat-truncation=3D] snprintf (buffer, 16, "%3.1f", h); ^ ../../master/src/w32cygwinx.c:116:4: note: =E2=80=98__builtin_snprintf=E2= =80=99 output=20 between 4 and 313 bytes into a destination of size 16 snprintf (buffer, 16, "%3.1f", h); ^ The attached patch avoids the warning. Is this a reasonable fix, or is there a better way? In GNU Emacs 27.0.50 (build 6, x86_64-unknown-cygwin, GTK+ Version 3.22.2= 8) of 2018-07-17 built on moufang Repository revision: 04599bb1b219b236356ba3393a23e1c1dd8c541b Windowing system distributor 'The Cygwin/X Project', version 11.0.1200000= 0 --------------9FD99D1FB873E554C8503191 Content-Type: text/plain; charset=UTF-8; name="0001-Pacify-GCC-7-with-Wformat-truncation-2.patch" Content-Disposition: attachment; filename="0001-Pacify-GCC-7-with-Wformat-truncation-2.patch" Content-Transfer-Encoding: base64 RnJvbSBmNzlhZDk0ZjhkY2NhODJhYTE1MjNlZjg5ZmY4OGFhYjFiMmQzZmU0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGticm93bkBjb3JuZWxsLmVkdT4K RGF0ZTogVHVlLCAxNyBKdWwgMjAxOCAxNToxMjozNSAtMDQwMApTdWJqZWN0OiBbUEFUQ0hd IFBhY2lmeSBHQ0MgNyB3aXRoIC1XZm9ybWF0LXRydW5jYXRpb249MgoKKiBzcmMvdzMyY3ln d2lueC5jIChGdzMyX2JhdHRlcnlfc3RhdHVzKTogSW5jcmVhc2Ugc2l6ZSBvZgonYnVmZmVy Jy4gIChCdWcjeHh4eHgpCi0tLQogc3JjL3czMmN5Z3dpbnguYyB8IDEwICsrKysrLS0tLS0K IDEgZmlsZSBjaGFuZ2VkLCA1IGluc2VydGlvbnMoKyksIDUgZGVsZXRpb25zKC0pCgpkaWZm IC0tZ2l0IGEvc3JjL3czMmN5Z3dpbnguYyBiL3NyYy93MzJjeWd3aW54LmMKaW5kZXggOGQz YWUxNjRjZi4uZjdiYmYxN2ExNiAxMDA2NDQKLS0tIGEvc3JjL3czMmN5Z3dpbnguYworKysg Yi9zcmMvdzMyY3lnd2lueC5jCkBAIC0xMDQsMTkgKzEwNCwxOSBAQCBUaGUgZm9sbG93aW5n ICUtc2VxdWVuY2VzIGFyZSBwcm92aWRlZDoKIAl7CiAJICBsb25nIG07CiAJICBkb3VibGUg aDsKLQkgIGNoYXIgYnVmZmVyWzE2XTsKLQkgIHNucHJpbnRmIChidWZmZXIsIDE2LCAiJWxk Iiwgc2Vjb25kc19sZWZ0KTsKKwkgIGNoYXIgYnVmZmVyWzQwMF07CisJICBzbnByaW50ZiAo YnVmZmVyLCA0MDAsICIlbGQiLCBzZWNvbmRzX2xlZnQpOwogCSAgc2Vjb25kcyA9IGJ1aWxk X3N0cmluZyAoYnVmZmVyKTsKIAogCSAgbSA9IHNlY29uZHNfbGVmdCAvIDYwOwotCSAgc25w cmludGYgKGJ1ZmZlciwgMTYsICIlbGQiLCBtKTsKKwkgIHNucHJpbnRmIChidWZmZXIsIDQw MCwgIiVsZCIsIG0pOwogCSAgbWludXRlcyA9IGJ1aWxkX3N0cmluZyAoYnVmZmVyKTsKIAog CSAgaCA9IHNlY29uZHNfbGVmdCAvIDM2MDAuMDsKLQkgIHNucHJpbnRmIChidWZmZXIsIDE2 LCAiJTMuMWYiLCBoKTsKKwkgIHNucHJpbnRmIChidWZmZXIsIDQwMCwgIiUzLjFmIiwgaCk7 CiAJICBob3VycyA9IGJ1aWxkX3N0cmluZyAoYnVmZmVyKTsKIAotCSAgc25wcmludGYgKGJ1 ZmZlciwgMTYsICIlbGQ6JTAybGQiLCBtIC8gNjAsIG0gJSA2MCk7CisJICBzbnByaW50ZiAo YnVmZmVyLCA0MDAsICIlbGQ6JTAybGQiLCBtIC8gNjAsIG0gJSA2MCk7CiAJICByZW1haW4g PSBidWlsZF9zdHJpbmcgKGJ1ZmZlcik7CiAJfQogCi0tIAoyLjE3LjAKCg== --------------9FD99D1FB873E554C8503191--