From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#62720: 29.0.60; Not easy at all to upgrade :core packages like Eglot Date: Tue, 25 Apr 2023 21:35:11 +0300 Message-ID: <0295d425-7c42-9a09-bda0-d3e4c92b4ff4@gutov.dev> References: <87a5zj2vfo.fsf@gmail.com> <47140c27-ba63-ca7b-8b9e-cc38a6f9a866@gutov.dev> <838rem636a.fsf@gnu.org> <83leil4u63.fsf@gnu.org> <8a9d0e2b-6ae2-bcdc-efd0-52a44ac862bb@gutov.dev> <83h6t94hru.fsf@gnu.org> <7676c8d2-1324-31e7-38b3-de167ecf683a@gutov.dev> <8e9bd99a-3093-3b69-8429-aa1ae6b7240d@gutov.dev> <834jp82u5c.fsf@gnu.org> <83ildo189j.fsf@gnu.org> <6e91a10e-e8bb-c7db-f6ce-917790e7e391@gutov.dev> <83edoc1602.fsf@gnu.org> <8e4ec101-adc3-0d1b-af3d-cce92f17b874@gutov.dev> <83r0sbyuew.fsf@gnu.org> <83edoazr8k.fsf@gnu.org> <3fb17c71-2a37-b306-472b-d8bc845e5777@gutov.dev> <83a5yyznfe.fsf@gnu.org> <41a79777-2cc6-9562-8915-9f28070b7bc9@gutov.dev> <83cz3txzi5.fsf@gnu.org> <5ae14089-f76f-84a1-d39a-3ec9e473a0aa@gutov.dev> <83jzy0wggy.fsf@gnu.org> <60a19aa0-e87c-1702-4ef4-df4450ed8fc7@gutov.dev> <831qk8w2rx.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5218"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, monnier@iro.umontreal.ca, larsi@gnus.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 25 20:36:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prNWU-000182-En for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 25 Apr 2023 20:36:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1prNWG-0005nc-T0; Tue, 25 Apr 2023 14:36:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1prNWE-0005nH-Og for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2023 14:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1prNWE-00040S-Gg for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2023 14:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1prNWD-0007LO-Ty for bug-gnu-emacs@gnu.org; Tue, 25 Apr 2023 14:36:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Apr 2023 18:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62720 X-GNU-PR-Package: emacs Original-Received: via spool by 62720-submit@debbugs.gnu.org id=B62720.168244772628176 (code B ref 62720); Tue, 25 Apr 2023 18:36:01 +0000 Original-Received: (at 62720) by debbugs.gnu.org; 25 Apr 2023 18:35:26 +0000 Original-Received: from localhost ([127.0.0.1]:53589 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prNVd-0007KO-HJ for submit@debbugs.gnu.org; Tue, 25 Apr 2023 14:35:25 -0400 Original-Received: from new3-smtp.messagingengine.com ([66.111.4.229]:51741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prNVZ-0007K7-Bm for 62720@debbugs.gnu.org; Tue, 25 Apr 2023 14:35:23 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailnew.nyi.internal (Postfix) with ESMTP id 4A25A58243B; Tue, 25 Apr 2023 14:35:16 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 25 Apr 2023 14:35:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1682447716; x=1682451316; bh=bvwWm1cXADk6ZVPJKXG+IJ5p8Kd+BwgfNpm TO3kGXa4=; b=T4PY8zM8ZSijYjs5b7xg3txbjibzI6NFyfGYa/eU8QoDUUZmZZt n2BMl+9cvGlQTGTcl6YXH1t/YNoJXmOuaVJfWAF+Y/3goHmQzA4/JE8ioXnRCCQm Cery4H95SUmFyrwu29FwPIA5a7rDB4XoHBBu6hMwDctH2RV8Eu9J2jgsMePiCNPw pPoNQULiQC1A9jgzheuWmz/NKmGoil5rPwuoF2kLUul0yhK0Ezxi9TyeFTYn29I1 Y/+LS4U9yuimq6CkHtIC1p9XJL2IS8W0eSSYIfAnfAdNl6MfnPV1NMImTiaPvNiX b6bY0MK0LEp3MhuEUSCBmzSeydvan7YZswA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1682447716; x=1682451316; bh=bvwWm1cXADk6ZVPJKXG+IJ5p8Kd+BwgfNpm TO3kGXa4=; b=YuZwQVQutETyBuf9wwwOmfAxGdr9Ir4d0R4npQYUn9/MMxKou3v slewJJAhYyIBzCTDf+4fBpr10692ca92eII1g9vlME1OJ5xUFpyptKayW0lZqnSG Mos52DJx7BQbYdsdm50XzorIzkaZebSW83QLhGSkRlZF4WVE9sDtfB8j1AVvfQ3D Di7ZSGhCS0tJNMydaN8kS4e+1SMl4KFJquL3cvrd9VxWa8CUt+xHBc2EjhOvTVhU 3t8WITAR0RFaIDUGX86eqxXcJyj0cxpgSwjiQN0jAQeLvAtvG9zuGIap00A0SN1o n929+ReAG7trVQOt0sIE4TmSZPFw0rmTrKw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeduvddguddvjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhm ihhtrhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrg htthgvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeev ledvveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe gumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 25 Apr 2023 14:35:13 -0400 (EDT) Content-Language: en-US In-Reply-To: <831qk8w2rx.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260637 Archived-At: On 25/04/2023 15:43, Eli Zaretskii wrote: >> Date: Tue, 25 Apr 2023 15:08:15 +0300 >> Cc: jporterbugs@gmail.com, philipk@posteo.net, 62720@debbugs.gnu.org, >> joaotavora@gmail.com, larsi@gnus.org, monnier@iro.umontreal.ca >> From: Dmitry Gutov >> >>>> -(defun package-update (name) >>>> - "Update package NAME if a newer version exists." >>>> +(defun package-update (name &optional update-built-ins) >>>> + "Update package NAME if a newer version exists. >>>> + >>>> +Only packages installed from ELPA are allowed to be updated this >>>> +way. >>> >>> I'm not sure I understand where this restriction comes from. Did the >>> original code enforce it? >> >> I'm not sure what you mean about "enforce it". That's the essence of the >> bug here: this function's inability to upgrade built-in packages >> (packages installed not from ELPA). Since you are asking to keep that >> behavior by default, it now needs to be documented. > > Oh, then I misunderstood what that says. I thought is says ELPA as > opposed to, say, MELPA. No, just ELPA in general. > So I think we need to rephrase that. Something like > > Packages which are part of the Emacs distribution cannot be updated > that way. This is probably better. As long as we understand it to read "packages which are part ... and were never upgraded to a version from ELPA". >> >> Regarding obeying package-install-upgrade-built-in, I think it would >> >> need to be renamed, and both package-update-all and >> >> package-menu-mark-upgrades would need to be made obey it too. All that >> >> could be done in a subsequent change. >> > >> > If the option will affect more than just package-install, it should >> > indeed be renamed. >> >> That will require some more work. On package-menu-mark-upgrades in >> particular. >> >> TBH, I'm getting more doubts about this change now. >> >> What will we do in Emacs 30? If we add the new argument, it will be hard >> to back out of it, to default to the proper behavior. > > I thought that in Emacs 30 we could make the user option be non-nil by > default, assuming we will decide not to treat built-in packages > specially in this regard. Then the additional argument will become > much less important, perhaps for some rare situations or something. It would remain an odd vestige, and it might be difficult to repurpose for something more useful (e.g. being able to pick a specific version to upgrade/downgrade to?) >> Perhaps we should just wait and then fix it on master properly. >> Workarounds exist, after all. > > I won't object, but I thought you and others wanted to have > package-install and package-update to behave consistently in this > respect. Having package-install and package-update behave the same was never the goal, at least not for me. Quite the opposite: package-install doesn't install anything when the package is already installed (and the argument is a package name symbol, which is the case for interactive invocations). package-update/upgrade, OTOH, is supposed to upgrade already installed packages. Which I'm assuming is the category we are going to assign the built-ins to, after all.