From: "Петров Андрей" <an.petrov@pay-lab.ru>
To: Dmitry Gutov <dgutov@yandex.ru>, Eli Zaretskii <eliz@gnu.org>
Cc: "54025@debbugs.gnu.org" <54025@debbugs.gnu.org>
Subject: bug#54025: 27.2; dired-do-find-regexp skips occurences
Date: Wed, 23 Feb 2022 07:01:09 +0000 [thread overview]
Message-ID: <0239f68191344ab49b23ddc96c7bd6e9@pay-lab.ru> (raw)
In-Reply-To: <d4ad01db-4062-4e55-9295-42e4085145be@yandex.ru>
Dmitry,
Looks great!
RecentlyI found a function `dired-do-search' which uses searching in buffers (and sees unsaved occurences). It seems that processing unmodified (or not open) files with grep and modified ones with searching in buffers would be a well-balanced approach saving both memory and possible network traffic (or SSD rewrite cycles) but this is rather feature to make in the future then a hot fix )).
People who expect searching in modified buffers still can use `dired-do-search' and `dired-do-query-replace-regexp' which may work slower.
So I think the current decision is OK.
Best regards,
Andrey Petrov.
________________________________________
От: DG <raaahh@gmail.com> от имени Dmitry Gutov <dgutov@yandex.ru>
Отправлено: 23 февраля 2022 г. 7:38:17
Кому: Петров Андрей; Eli Zaretskii
Копия: 54025@debbugs.gnu.org
Тема: Re: bug#54025: 27.2; dired-do-find-regexp skips occurences
On 21.02.2022 09:00, Петров Андрей wrote:
> I think it is convenient to ask user to save some buffers (like `rgrep' do) if the search algorithm implementation requires all files to be saved. Optionally modified buffers can be skipped with appropriate logging into messages buffer.
How about this?
diff --git a/lisp/dired-aux.el b/lisp/dired-aux.el
index 56897826cb..16094f4551 100644
--- a/lisp/dired-aux.el
+++ b/lisp/dired-aux.el
@@ -3272,6 +3272,7 @@ dired-do-find-regexp
(require 'xref)
(defvar grep-find-ignored-files)
(declare-function rgrep-find-ignored-directories "grep" (dir))
+ (save-some-buffers)
(let* ((marks (dired-get-marked-files nil nil nil nil t))
(ignores (nconc (mapcar
#'file-name-as-directory
diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 880c5b5517..f772871f72 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -834,6 +834,7 @@ project-or-external-find-regexp
nil)))
(defun project--find-regexp-in-files (regexp files)
+ (save-some-buffers)
(unless files
(user-error "Empty file list"))
(let ((xrefs (xref-matches-in-files regexp files)))
diff --git a/lisp/progmodes/xref.el b/lisp/progmodes/xref.el
index aa98aa89f1..ae19632974 100644
--- a/lisp/progmodes/xref.el
+++ b/lisp/progmodes/xref.el
@@ -273,6 +273,7 @@ xref-backend-references
The default implementation uses `semantic-symref-tool-alist' to
find a search tool; by default, this uses \"find | grep\" in the
current project's main and external roots."
+ (save-some-buffers)
(mapcan
(lambda (dir)
(message "Searching %s..." dir)
@@ -2013,7 +2014,9 @@ xref--find-file-buffer
(setq xref--last-file-buffer
;; `find-buffer-visiting' is considerably slower,
;; especially on remote files.
- (cons file (get-file-buffer file))))
+ (cons file (get-file-buffer file)))
+ (when (buffer-modified-p (cdr xref--last-file-buffer))
+ (message "Buffer %s has unsaved changes" (cdr
xref--last-file-buffer))))
(cdr xref--last-file-buffer))
(provide 'xref)
next prev parent reply other threads:[~2022-02-23 7:01 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 11:40 bug#54025: 27.2; dired-do-find-regexp skips occurences Петров Андрей
2022-02-21 0:35 ` Dmitry Gutov
2022-02-21 3:33 ` Eli Zaretskii
2022-02-21 7:00 ` Петров Андрей
2022-02-21 23:58 ` Dmitry Gutov
2022-02-23 2:38 ` Dmitry Gutov
2022-02-23 7:01 ` Петров Андрей [this message]
2022-02-24 2:50 ` Dmitry Gutov
2022-02-24 7:25 ` Петров Андрей
2022-02-25 1:38 ` Dmitry Gutov
2022-02-25 8:13 ` Michael Albinus
2022-02-25 13:47 ` Dmitry Gutov
2022-02-25 15:05 ` Michael Albinus
2022-02-26 0:28 ` Dmitry Gutov
2022-02-26 11:56 ` Michael Albinus
2022-02-26 14:54 ` Петров Андрей
2022-02-27 2:50 ` Dmitry Gutov
2022-02-27 12:50 ` Петров Андрей
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0239f68191344ab49b23ddc96c7bd6e9@pay-lab.ru \
--to=an.petrov@pay-lab.ru \
--cc=54025@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).