From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#41544: 26.3; Possible incorrect results from color-distance Date: Sat, 6 Jun 2020 15:29:31 +0200 Message-ID: <020DE875-14A8-457A-9AE4-AA0925DB8997@acm.org> References: <5C4A633D-8222-4439-BE37-9B8674F1DA6D@acm.org> <87r1v2aat3.fsf@tromey.com> <9902865C-01B4-4E50-A433-DBC8B8311234@acm.org> <83tuzueogo.fsf@gnu.org> <6272275C-560C-4437-90F1-2A8294D27019@acm.org> <83o8q2elja.fsf@gnu.org> <83mu5mel4o.fsf@gnu.org> <77F1DDD3-A69F-40ED-902D-74986D5E6596@acm.org> <83y2p5cumz.fsf@gnu.org> <83blm0cjlz.fsf@gnu.org> <83367ccf8w.fsf@gnu.org> <624D7FB8-A836-4A7E-8895-47E867214504@acm.org> <83o8pyc4bq.fsf@gnu.org> <55D73CA5-1EFB-4B0A-8F8B-FDA1D39F51BF@acm.org> <835zc5bsut.fsf@gnu.org> <3BBCFDD4-C14D-4628-91CB-2A0456A96FC7@acm.org> <838sh0abzz.fsf@gnu.org> <83r1us8kw6.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="118612"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 41544@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jun 06 15:30:14 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhYtp-000UmY-DN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jun 2020 15:30:13 +0200 Original-Received: from localhost ([::1]:59888 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jhYto-0005xZ-7T for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 06 Jun 2020 09:30:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40440) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jhYtf-0005vd-6g for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 09:30:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:39522) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jhYte-0001ZU-Tw for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 09:30:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jhYte-0003xG-OS for bug-gnu-emacs@gnu.org; Sat, 06 Jun 2020 09:30:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Jun 2020 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41544 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41544-submit@debbugs.gnu.org id=B41544.159145018115151 (code B ref 41544); Sat, 06 Jun 2020 13:30:02 +0000 Original-Received: (at 41544) by debbugs.gnu.org; 6 Jun 2020 13:29:41 +0000 Original-Received: from localhost ([127.0.0.1]:51068 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhYtJ-0003wI-B2 for submit@debbugs.gnu.org; Sat, 06 Jun 2020 09:29:41 -0400 Original-Received: from mail157c50.megamailservers.eu ([91.136.10.167]:51618 helo=mail51c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jhYtE-0003w7-DF for 41544@debbugs.gnu.org; Sat, 06 Jun 2020 09:29:40 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1591450174; bh=Q7L2t01bzD0Gp9w1YwDcKsQOepa8E7GDWP8E9rDiShg=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Ijug6IQocfRjcN3FQHaCwokrEyd51NhWfwgnsytsnw8J6gXSH05eGKM4hKRgoa92K PH03gPEbKm9YBqoJmJT3QPUfXWRepb4S4+7e0FZ5eMFA4N+SykUjpUcvIV2vS2YUAO B/2BUJiUseiN2ZcjZXYCt4GCXDCluU5GhjTwhqKM= Feedback-ID: mattiase@acm.or Original-Received: from stanniol.lan (c-4e4ae655.032-75-73746f71.bbcust.telenor.se [85.230.74.78]) (authenticated bits=0) by mail51c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 056DTWI6030485; Sat, 6 Jun 2020 13:29:33 +0000 In-Reply-To: <83r1us8kw6.fsf@gnu.org> X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F23.5EDB99C4.000C:SCFSTAT68638221, ss=1, re=-4.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: -4.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=MOMeZ/Rl c=1 sm=1 tr=0 a=klNLuyVZdLUgl+K5Uafb2A==:117 a=klNLuyVZdLUgl+K5Uafb2A==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=mDV3o1hIAAAA:8 a=IwwuGxysOwN4sJXSbG8A:9 a=CjuIK1q_8ugA:10 a=_FVE-zBwftR9WsbkzFJk:22 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:181615 Archived-At: 6 juni 2020 kl. 13.59 skrev Eli Zaretskii : > I have already pointed out the negative consequences: the fix you > proposed changes the behavior and return values of a low-level API > that is used in many places, both directly and indirectly. Thus, it > runs a high risk of producing bugs and breaking code that works well > enough now. This is very speculative and hypothetical. Forgive me for being = sceptical, but can you come up with a concrete and realistic example of = what you think will break? > That is, assuming we are still talking about the last patch you > posted in this matter. We were specifically talking about fixing the bug in color-name-to-rgb, = I believe. It is subordinate to the main change, which we have not = discussed at all. If you like, we could leave color-name-to-rgb alone, = and we will see whether the change is needed when doing the actual work = (color-dark-p). > My assumption is that making changes for purely academic and/or > aesthetic reasons is something that we should avoid. That is a rather disparaging way of referring to fixes intended to make = code working as advertised.=20 > I don't even understand what each paragraph above tries to say, and/or > with what argument of mine it attempts to argue. You were saying that #ffffffffffff is as good an approximation as any = other, and I was showing that it's not. > Specifically, what is there that is the current state of affairs, what > is that _should_be_ the state of affairs The current state of affairs is that 'color-values' returns an incorrect = value in certain cases. This can be fixed by making the code simpler and = more robust.