From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#45748: 28.0.50; fit-frame-to-buffer ignores leading spaces Date: Sat, 9 Jan 2021 18:07:36 +0100 Message-ID: <01d09a7b-09b0-9221-5bf3-8454f94704f7@gmx.at> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8096"; mail-complaints-to="usenet@ciao.gmane.io" To: Aaron Jensen , 45748@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 09 18:09:00 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kyHjX-0001wy-MQ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Jan 2021 18:08:59 +0100 Original-Received: from localhost ([::1]:36768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kyHjW-0002KB-O9 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 09 Jan 2021 12:08:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38912) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kyHid-0001ue-5k for bug-gnu-emacs@gnu.org; Sat, 09 Jan 2021 12:08:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40973) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kyHic-0003eG-Un for bug-gnu-emacs@gnu.org; Sat, 09 Jan 2021 12:08:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kyHic-0002cP-Q8 for bug-gnu-emacs@gnu.org; Sat, 09 Jan 2021 12:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jan 2021 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45748 X-GNU-PR-Package: emacs Original-Received: via spool by 45748-submit@debbugs.gnu.org id=B45748.161021206510028 (code B ref 45748); Sat, 09 Jan 2021 17:08:02 +0000 Original-Received: (at 45748) by debbugs.gnu.org; 9 Jan 2021 17:07:45 +0000 Original-Received: from localhost ([127.0.0.1]:52517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyHiL-0002bf-1S for submit@debbugs.gnu.org; Sat, 09 Jan 2021 12:07:45 -0500 Original-Received: from mout.gmx.net ([212.227.15.15]:39537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kyHiJ-0002bS-Ax for 45748@debbugs.gnu.org; Sat, 09 Jan 2021 12:07:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1610212057; bh=Nj4X90cV+RLnh0g2d1ahc09yvohyV9V0ZO3IsLRgDmU=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=bRfErZ4O+HEaGwRQSRnOZQ8lzyX+PyxCBlphi0fnp+bxYJcg+56isZSCSCiHYmE6A EJh5E3wBVINvHvduhIMOYXn6Mn29ZNVOLCnXDbW5Ex6U4rX7YLCG3XgKqDZLuL7Tpo FZCTYBI4Kgh49HzPlhyR/N5u33ImXHeH/lnR0nL0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([46.125.249.80]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MmDEg-1kG7Cq3xia-00iAnw; Sat, 09 Jan 2021 18:07:37 +0100 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:FjmaM/u7PxmcC2Lapu1Hymav7m8+Bkmh17MBFdxGMt53g7Yc7/X /5ygD6aNWohVRofVv120HBbTJmTR6jnW8w2bcb47s2YuLX4HoHcmvCtlbHJ/MDur4H5YsN+ jWmJvILbaqEdc16cMgMrr2KS81jh1moLp0zoJzoVbZDjhXIpudy870qzx39myYbwWdvgSk9 k/qvNDGngEq1XH+2EEj2A== X-UI-Out-Filterresults: notjunk:1;V03:K0:5KHr19ety+s=:yLS3bI7RsUtCO8IC0aA7Br qQ3OdIyvA/RfSoBbiv3UblU0HnNnZlfrE0/7/oFkO1pz9BDlmFJjOJpk1Ff9dxkhJpNBYYGP3 qSP/pdW/77av/nKNlqhgbQfT161a/MhtC2/piuKceAnzQNtE877hk6HELbykofIX2fNs1/p61 92pzOJldVBScR25jb2GqSMD3UlAXjWFBnzHBrTMMHQV21XHrxj9ONh0G3Qcrb5NgqEne+rpvw zJFpbxhQdSHhS2rYnFcLeWxqgbUoywSFEPXOM8HHCBRdAzDHk5QFsGRzzbbut58cuVCTWaLo5 pxxi2unhB9/b9ZvaPVHOrIadD5pJCsPA74Ig4r7L8K2ibm0iQyGncR0LqqdZsaFJcuU+MPwJD WxP3PXzKVzVnkE30JtEZiBpR7MBGJ/GqTuwkWJ13bFzJ9zPloKuBNbJ0keKrS9//8RVHCcyLd Oey8Pp2oKvIESvjXXxO9ICRI7O99Q0yh6IV24ThdQdgf0uHw6VdFbEnRkL9a2Y+gdZVh3WmL3 J03bjm159IyUTYzkj3Q+qapKnErPY8AhCRUid4EySYcTTVVkiRyEJigyVBwC6AAmKopwbWvHv hn10tigOAAKrZ3a7V3+JsEFGeR1PGKyiNSvweE3AssRZeLiJ+Y196TKm48mHmchtNkJDUolJh b7iMSVvQuO1MADQ7WFkWpdP+W+b1zv/zUofYaTVKxT6rS6CSFEP+bPtq6DAuabSrcC63aonCI gNpD5qmYDxMdDiaW6OmYpriIMaafZfx4crVPRo2k5085QOq/W9oGydsQrYD+uVM+sXv662Au X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197558 Archived-At: > The problematic code appears to be here in window-text-pixel-size: > > else if (EQ (from, Qt)) > { > start = BEGV; > bpos = BEGV_BYTE; > while (bpos < ZV_BYTE) > { > c = fetch_char_advance (&start, &bpos); > if (!(c == ' ' || c == '\t' || c == '\n' || c == '\r')) > break; > } > while (bpos > BEGV_BYTE) > { > dec_both (&start, &bpos); > c = FETCH_BYTE (bpos); > if (!(c == ' ' || c == '\t')) > break; > } > } > > The second loop looks like it's attempting to backtrack to the > beginning of the line, but FETCH_BYTE (bpos) after a dec_both returns > the same character that the first loop ended on. In other words, start > and bpos are not in sync, or the way that FETCH_BYTE works is > different. If I subtract 1 from bpos when calling FETCH_BYTE, it works > as expected. Do you mean the first dec_both skips too much or not enough? That code was broken when I wrote it initially, someone fixed the char/byte issue later and now I'm too silly to understand it. martin