unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#24023: 24.5; Use `custom-file' (if defined), not init file, for `en/disable-command'
@ 2016-07-19  3:55 Drew Adams
  2016-07-19 15:30 ` Eli Zaretskii
  0 siblings, 1 reply; 5+ messages in thread
From: Drew Adams @ 2016-07-19  3:55 UTC (permalink / raw)
  To: 24023

This very old feature still writes to your init file.  If you have
defined `custom-file' then it should write to that file instead.

In GNU Emacs 24.5.1 (i686-pc-mingw32)
 of 2015-04-11 on LEG570
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/usr --host=i686-pc-mingw32'





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24023: 24.5; Use `custom-file' (if defined), not init file, for `en/disable-command'
  2016-07-19  3:55 bug#24023: 24.5; Use `custom-file' (if defined), not init file, for `en/disable-command' Drew Adams
@ 2016-07-19 15:30 ` Eli Zaretskii
  2016-07-19 15:42   ` Glenn Morris
  0 siblings, 1 reply; 5+ messages in thread
From: Eli Zaretskii @ 2016-07-19 15:30 UTC (permalink / raw)
  To: Drew Adams; +Cc: 24023

> Date: Mon, 18 Jul 2016 20:55:07 -0700 (PDT)
> From: Drew Adams <drew.adams@oracle.com>
> 
> This very old feature still writes to your init file.  If you have
> defined `custom-file' then it should write to that file instead.

This feature is not a defcustom, so it doesn't work like one.  Perhaps
the easiest way forward would be to make it a defcustom, or something
like one.





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24023: 24.5; Use `custom-file' (if defined), not init file, for `en/disable-command'
  2016-07-19 15:30 ` Eli Zaretskii
@ 2016-07-19 15:42   ` Glenn Morris
  2016-07-19 15:48     ` Drew Adams
  0 siblings, 1 reply; 5+ messages in thread
From: Glenn Morris @ 2016-07-19 15:42 UTC (permalink / raw)
  To: Eli Zaretskii; +Cc: 24023


See discussion from previous identical report:
http://debbugs.gnu.org/5974





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24023: 24.5; Use `custom-file' (if defined), not init file, for `en/disable-command'
       [not found] ` <<83bn1t1w7h.fsf@gnu.org>
@ 2016-07-19 15:47   ` Drew Adams
  0 siblings, 0 replies; 5+ messages in thread
From: Drew Adams @ 2016-07-19 15:47 UTC (permalink / raw)
  To: Eli Zaretskii, Drew Adams; +Cc: 24023

> This feature is not a defcustom, so it doesn't work like one.  Perhaps
> the easiest way forward would be to make it a defcustom, or something
> like one.

I see now that this was all discussed in the bug that this one was merged with. I'd forgotten about that bug.

Yes, something should be done, to bring this feature up to the level of current Emacs.  A priori, I don't really care what is done or how.  IOW, I trust your judgment on this.

The point is that Emacs should not still be writing to a users init file.  As mentioned in that other bug thread, two alternative suggestions were:

* Replace this way of enabling/disabling with a way that uses defcustom.  (It could involve a wrapper around the `put' thingy or something else.)

* Keep the current mechanism, but write to a different file from the init file (and different from `custom-file').





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#24023: 24.5; Use `custom-file' (if defined), not init file, for `en/disable-command'
  2016-07-19 15:42   ` Glenn Morris
@ 2016-07-19 15:48     ` Drew Adams
  0 siblings, 0 replies; 5+ messages in thread
From: Drew Adams @ 2016-07-19 15:48 UTC (permalink / raw)
  To: Glenn Morris, Eli Zaretskii; +Cc: 24023

> See discussion from previous identical report:
> http://debbugs.gnu.org/5974

+1.  And apologies for creating a duplicate bug report.





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2016-07-19 15:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-19  3:55 bug#24023: 24.5; Use `custom-file' (if defined), not init file, for `en/disable-command' Drew Adams
2016-07-19 15:30 ` Eli Zaretskii
2016-07-19 15:42   ` Glenn Morris
2016-07-19 15:48     ` Drew Adams
     [not found] <<013bc8d5-e959-4814-9f31-bc9297499588@default>
     [not found] ` <<83bn1t1w7h.fsf@gnu.org>
2016-07-19 15:47   ` Drew Adams

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).