From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#38796: 26.3; `view-lossage': Use a variable for the lossage limit Date: Sat, 22 Aug 2020 15:54:09 -0700 (PDT) Message-ID: <00e30775-94b9-4663-a823-296bad355dcf@default> References: <43aac56d-ecf1-44ed-9be1-ffb8e5f8a7ce@default> <83zhfbm448.fsf@gnu.org> <87zh8pij6e.fsf@calancha-pc.dy.bbexcite.jp> <83v9jc3o3q.fsf@gnu.org> <87wo3qj1s6.fsf@calancha-pc.dy.bbexcite.jp> <87eenygyrx.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2433"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , 38796@debbugs.gnu.org, uyennhi.qm@gmail.com To: Lars Ingebrigtsen , Tino Calancha Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Aug 23 00:57:09 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k9cRh-0000TX-Ig for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Aug 2020 00:57:09 +0200 Original-Received: from localhost ([::1]:32900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k9cRg-0002Rc-7R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 22 Aug 2020 18:57:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:32778) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k9cRa-0002RR-7y for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 18:57:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40166) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1k9cRZ-00047o-Sz for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 18:57:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1k9cRZ-0004uo-Pc for bug-gnu-emacs@gnu.org; Sat, 22 Aug 2020 18:57:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Aug 2020 22:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38796 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 38796-submit@debbugs.gnu.org id=B38796.159813698118845 (code B ref 38796); Sat, 22 Aug 2020 22:57:01 +0000 Original-Received: (at 38796) by debbugs.gnu.org; 22 Aug 2020 22:56:21 +0000 Original-Received: from localhost ([127.0.0.1]:51712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9cQv-0004tt-3g for submit@debbugs.gnu.org; Sat, 22 Aug 2020 18:56:21 -0400 Original-Received: from aserp2120.oracle.com ([141.146.126.78]:37198) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1k9cQt-0004tg-PB for 38796@debbugs.gnu.org; Sat, 22 Aug 2020 18:56:20 -0400 Original-Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07MMplsk035956; Sat, 22 Aug 2020 22:56:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=d70q9WL5NpdLr4RlPQduMSNZp6FDr1Dl5hiNXSmMYgo=; b=h4FUO1aRkzCEc+K/R7A6lOYKjEAvCr0q+3ni+9GNyPqguDy+QUtJw15PMEg4hlnSGGXc x/qHIYpdF65lJdmLpIh9CKmfNtomURBC9W9p43i9EzOSQtW3KZ3ebZcMDdtQaWoPc9SQ erKjGKwzhCuLk4u8sRidCRQqvZhONOQY85yAk6SFejo1VarS3Y2FcAan9GCeX5QnY0El RCsZ6m2uoXkdP/5r97YpT7pQA5i73I1+uiQ3Ss9vtDwrrUEfJjp9PYybFrhP1B+Ue9Oa 120rDbzDlNejacLcokTTY9xKI/YSia/THCcOT/M482b25XfRbKBDMI8hxTwxz2ayOuAU qw== Original-Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 332uak9q0q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 22 Aug 2020 22:56:13 +0000 Original-Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 07MMrwDi031212; Sat, 22 Aug 2020 22:54:13 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3020.oracle.com with ESMTP id 332u6151rd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 22 Aug 2020 22:54:13 +0000 Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 07MMsBnp014888; Sat, 22 Aug 2020 22:54:11 GMT In-Reply-To: <87eenygyrx.fsf@gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5044.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9721 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008220254 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9721 signatures=668679 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 clxscore=1011 impostorscore=0 mlxlogscore=999 spamscore=0 mlxscore=0 phishscore=0 bulkscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2008220254 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:186009 Archived-At: > I thought it sounded quite natural to use the same mechanism to switch > lossage logging off. `(update-lossage-size 0)' seems like a natural > thing to do to have no lossage. FWIW, I said the same thing: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D38796#28 It's not unusual or weird for a zero-valued size parameter to have such an effect.=20 > > Users can still safely modify the lossage limit with the > > command `update-lossage-size'. For convenience, add > > a function `lossage-size' to return the current limit. >=20 > Hm... other functions use the convention of having a zero-parameter > function return the data, and having a parameter to set it. So > (lossage-size 500) could set it and (lossage-size) could return the > current size? FWIW, most `set-*' functions are commands. And a command is what we should shoot for here.