From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#1754: 23.0.60; tool-bar is shown with tool-bar-mode off Date: Wed, 31 Dec 2008 21:17:19 -0800 Message-ID: <006101c96bd0$387ac7b0$0200a8c0@us.oracle.com> References: <877i5f914m.fsf@cyd.mit.edu> Reply-To: Drew Adams , 1754@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1230788624 5923 80.91.229.12 (1 Jan 2009 05:43:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Jan 2009 05:43:44 +0000 (UTC) Cc: 1754@emacsbugs.donarmstrong.com To: "'Chong Yidong'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jan 01 06:44:53 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LIGMV-0003m4-60 for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Jan 2009 06:44:51 +0100 Original-Received: from localhost ([127.0.0.1]:39821 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LIGLG-00064v-8H for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 Jan 2009 00:43:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LIGLB-00064m-M9 for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 00:43:29 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LIGL9-00064W-W9 for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 00:43:29 -0500 Original-Received: from [199.232.76.173] (port=41403 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LIGL9-00064S-MJ for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 00:43:27 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:36311) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LIGL9-0001RL-6Y for bug-gnu-emacs@gnu.org; Thu, 01 Jan 2009 00:43:27 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n015hMw7024230; Wed, 31 Dec 2008 21:43:22 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n015P4Rg019639; Wed, 31 Dec 2008 21:25:04 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 01 Jan 2009 05:25:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 1754 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 1754-submit@emacsbugs.donarmstrong.com id=B1754.123078705118272 (code B ref 1754); Thu, 01 Jan 2009 05:25:04 +0000 Original-Received: (at 1754) by emacsbugs.donarmstrong.com; 1 Jan 2009 05:17:31 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from acsinet11.oracle.com (acsinet11.oracle.com [141.146.126.233]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n015HSTU018266 for <1754@emacsbugs.donarmstrong.com>; Wed, 31 Dec 2008 21:17:30 -0800 Original-Received: from acsinet13.oracle.com (acsinet13.oracle.com [141.146.126.235]) by acsinet11.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n015IkiI017871 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 1 Jan 2009 05:18:47 GMT Original-Received: from acsmt707.oracle.com (acsmt707.oracle.com [141.146.40.85]) by acsinet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n015HrlT013104; Thu, 1 Jan 2009 05:17:55 GMT Original-Received: from dradamslap1 (/24.5.134.5) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 01 Jan 2009 05:17:18 +0000 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <877i5f914m.fsf@cyd.mit.edu> Thread-Index: AclrvfrzdiZgpZO6QamZOO3HfcPNKQAENv3A X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt707.oracle.com [141.146.40.85] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010208.495C51E0.005A:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Thu, 01 Jan 2009 00:43:29 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:23639 Archived-At: > Arguably, Emacs 23 is now doing the right thing. Your > default-frame-alist specifies a tool-bar-lines frame parameter of 1, > which means the tool-bar should be enabled in new frames. If > you remove that frame parameter from your default-frame-alist, or set it > to 0, new frames will not show a tool-bar. > > I am not 100% sure why previous version of Emacs did not show the > tool-bar, but they probably ought to have. Possibly it's > because we now set up the contents of the tool-bar at startup even if the > initial frame cannot or does not display it (a change required by > the new multi-tty functionality). Huh? Why is that the right thing? The default-frame-alist is set before turning off tool-bar-mode. Turning off the mode should turn off the mode everywhere, until you turn it back on - and it should change the value of default-frame-alist - which it does, except in the scenario I gave. The default-frame-alist doesn't override the current setting of any modes. It must not. It is simply a default setting. On the contrary - changing a mode such as tool-bar-mode or menu-bar-mode should (and generally does) change the value of default-frame-alist. Tool-bar-mode is global and applies to all frames and future frames. That has always been the case and should continue to be the case. What would be the point of having such a mode if the original default frame alist overrode it? Look at menu-bar-mode. It's exactly the same type of thing. But menu-bar-mode acts normally, as it always has acted and as tool-bar-mode should also act. And tool-bar-mode DOES act correctly, except in the scenario I gave, with pop-up-frames non-nil, pop-up-frame-alist as I gave it, and a standalone minibuffer frame. If you don't have all three of those, then turning off (or on) tool-bar-mode, just like turning off (or on) menu-bar-mode, changes the value of default-frame-alist to reflect the mode change, as it should.