bug#2949: 23.0.92; font-info incompatible across Emacs versions

bug#2949: 23.0.92; font-info incompatible across Emacs versions

[Drew Adams]

Function `font-info', on which several other functions are based,
changed its return value sometime after Emacs 20. The CHARSET entry
was removed.

In Emacs 20, `font-info' returns an array like this:

["-*-Lucida Console-normal-r-*-*-14-112-96-96-c-*-iso8859-1"
 "-*-Lucida Console-normal-r-*-*-14-105-96-96-c-*-iso8859-1"
 ascii 8 14 0 0 0]

In Emacs 22 and later, it returns an array like this:

["-*-Lucida Console-normal-r-*-*-14-112-96-96-c-*-iso8859-1"
 "-*-Lucida Console-normal-r-*-*-14-105-96-96-c-*-iso8859-1"
 8 14 0 0 0]

This breaks any code that tries to use the result with different Emacs versions.


In GNU Emacs 23.0.92.1 (i386-mingw-nt5.1.2600)
 of 2009-03-30 on SOFT-MJASON
Windowing system distributor `Microsoft Corp.', version 5.1.2600
configured using `configure --with-gcc (3.4)'

bug#2949: 23.0.92; font-info incompatible across Emacs versions

[Miles Bader]

"Drew Adams" <drew.adams@oracle.com> writes:
> In Emacs 20, `font-info' returns an array like this:
...
> In Emacs 22 and later, it returns an array like this:
...
> This breaks any code that tries to use the result with different Emacs versions.

So.... what exactly do you want to happen?

The two formats look easy enough to distinguish.  Since the change
occurred in 22, it's been widely released, so obviously 3rd-party code
simply has to be prepared to deal with it (if they care about 21 and
older versions), and there's little point in changing it back now.

-Miles

-- 
Education, n. That which discloses to the wise and disguises from the foolish
their lack of understanding.

bug#2949: 23.0.92; font-info incompatible across Emacs versions

[Drew Adams]

> > In Emacs 20, `font-info' returns an array like this: ...
> > In Emacs 22 and later, it returns an array like this: ...
> > This breaks any code that tries to use the result with 
> > different Emacs versions.
> 
> So.... what exactly do you want to happen?
> 
> The two formats look easy enough to distinguish.  Since the change
> occurred in 22, it's been widely released, so obviously 3rd-party code
> simply has to be prepared to deal with it (if they care about 21 and
> older versions), and there's little point in changing it back now.

I guess nothing can be done.

But I do wonder why CHARSET was dropped from both `font-info' and
`describe-font'. There seems to be nothing about this in NEWS (e.g. for Emacs
22). Is the character set no longer meaningful? useful? appropriate?
discoverable?

bug#2949: 23.0.92; font-info incompatible across Emacs versions

[Kenichi Handa]

In article <000601c9bacd$14ef5120$0200a8c0@us.oracle.com>, "Drew Adams" <drew.adams@oracle.com> writes:

> > > In Emacs 20, `font-info' returns an array like this: ...
> > > In Emacs 22 and later, it returns an array like this: ...
> > > This breaks any code that tries to use the result with 
> > > different Emacs versions.
> > 
> > So.... what exactly do you want to happen?
> > 
> > The two formats look easy enough to distinguish.  Since the change
> > occurred in 22, it's been widely released, so obviously 3rd-party code
> > simply has to be prepared to deal with it (if they care about 21 and
> > older versions), and there's little point in changing it back now.

Actually the change occurred in Emacs 21.

> I guess nothing can be done.

> But I do wonder why CHARSET was dropped from both `font-info' and
> `describe-font'. There seems to be nothing about this in NEWS (e.g. for Emacs
> 22). Is the character set no longer meaningful? useful? appropriate?
> discoverable?

I vaguely remember that the change was within a big change
of fontset implementation to match with Gerd's new display
engine for the release of 21.  Before that, fonts are
specified for each charset, but after that, fonts are
specified for each character using a char table.  As a
result, the concept for charset for a font lost the meaning.
Because the changes are quite lot at that time, perhaps I
forgot to record this specific change in NEWS and ChangeLog.

2000-03-21  Kenichi HANDA  <handa@etl.go.jp>

	The following changes are to make font selection based on
	characters, not charset.  In addition, they recover fontset
	facilities while utilizing the new font selection mechanism.
[...]

In article <49E153DA.7070502@gnu.org>, Jason Rumney <jasonr@gnu.org> writes:

> Miles Bader wrote:
> > So.... what exactly do you want to happen?
> >   

> At least the doc string for font-info should be updated. It still claims 
> that the third entry in the returned vector is CHARSET.

I fixed the docstring.

---
Kenichi Handa
handa@m17n.org

bug#2949: 23.0.92; font-info incompatible across Emacs versions

[Drew Adams]

> new display engine for the release of 21.
> Before that, fonts are specified for each charset,
> but after that, fonts are specified for each character
> using a char table.  As a result, the concept for charset
> for a font lost the meaning.

Thanks for the explanation. 

> I fixed the docstring.

Thanks.

bug#2949: 23.0.92; font-info incompatible across Emacs versions

[Jason Rumney]

Miles Bader wrote:
> So.... what exactly do you want to happen?
>   

At least the doc string for font-info should be updated. It still claims 
that the third entry in the returned vector is CHARSET.