unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Chong Yidong'" <cyd@stupidchicken.com>,
	<788@emacsbugs.donarmstrong.com>
Cc: Richard Stallman <rms@gnu.org>
Subject: bug#788: menu indications of key bindings for remapped commands
Date: Sun, 15 Mar 2009 12:33:38 -0700	[thread overview]
Message-ID: <004c01c9a5a4$f12a9890$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <871vsy8y4m.fsf@cyd.mit.edu>

> From: Chong Yidong Sent: Sunday, March 15, 2009 11:00 AM
> > As described in:
> > http://lists.gnu.org/archive/html/emacs-devel/2007-05/msg01020.html
> > key bindings defined via remap look odd in menus.
> 
> I changed the code so that [remap foo] commands are not 
> displayed in the menus.
> 
> Ideally, we would follow the remappings, but I think this 
> could mess up the menu cache (e.g., if the remapped-to
> command is rebound).  So that's a larger, post-release project.

I haven't tried after your fix, but from your description of the fix, (a) the
bug is not fixed at all, and (b) the change is negative.

1. It is inappropriate to *remove* such commands (menu items) from the menu. Or
did you mean just remove the confusing key bindings from the menu items?

The latter would be OK as a temporary workaround, but it represents a loss of
information, and it does not fix the bug. To fix the bug, the real, user-level
key binding needs to be shown.


2. The bug needs to be fixed properly, as Richard requested two years ago. It's
inappropriate to just close it now with a statement that we are too close to the
release to fix it properly.

The goal should be to improve Emacs by fixing bugs, not simply to reduce the bug
count by closing bugs without fixing them.

If you want to keep this bug open and fix it sometime after the release, that
would be appropriate, but closing it with a non-fix fix is inappropriate.








  reply	other threads:[~2009-03-15 19:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-15 18:00 bug#788: menu indications of key bindings for remapped commands Chong Yidong
2009-03-15 19:33 ` Drew Adams [this message]
2009-03-16  1:16   ` Chong Yidong
2009-03-16  1:51     ` Drew Adams
2009-03-16  2:11       ` Chong Yidong
2009-03-16  3:20         ` Drew Adams
2009-03-16  0:59 ` Stefan Monnier
2009-03-16  1:34   ` Chong Yidong
2009-03-16  3:01     ` Stefan Monnier
2009-03-16 15:30       ` Chong Yidong
2009-03-16 19:27         ` Stefan Monnier
2010-01-22 18:17           ` Drew Adams
2010-01-25  2:53             ` Stefan Monnier
2010-01-25  5:05               ` Drew Adams
2010-01-25  5:22                 ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004c01c9a5a4$f12a9890$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=788@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).