unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'martin rudalics'" <rudalics@gmx.at>,
	<445@emacsbugs.donarmstrong.com>,
	"'Chong Yidong'" <cyd@stupidchicken.com>
Cc: 'Daniel Colascione' <dan.colascione@gmail.com>
Subject: bug#445: Invalid read syntax in savehist-mode's history file
Date: Mon, 18 Aug 2008 14:24:52 -0700	[thread overview]
Message-ID: <004c01c90178$dad3b2a0$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <48A9DF65.3050507@gmx.at>

>  > AFAIK, savehist-mode doesn't save command-history.  Please 
>  > provide a recipe for reproducing this bug.
> 
> The comment below seems to contradict this
>    (defcustom savehist-ignored-variables nil ;; '(command-history)
> but I'm a stranger here.

Yes, you need a recipe and knowledge of the user's savehist variables. It's
likely that 
`savehist-save-hook' added `command-history' to
`savehist-minibuffer-history-variables'. That is the default behavior (and a
good one), since `savehist-ignored-variables' is nil by default.

Another, less likely possibility is that `command-history' was included in
`savehist-additional-variables' or `savehist-save-minibuffer-history'.

My own values, FWIW:

`savehist-additional-variables' is (search-ring regexp-search-ring)

`savehist-save-minibuffer-history' is t

`savehist-minibuffer-history-variables' is automatically set to:
(color-theme-history iswitchb-history icicle-face-name-history find-tag-history
icicle-doc-history junk-ring woman-file-history woman-topic-history
icicle-command-abbrev-history ediff-url-read-url-history grep-find-history
variable-name-history widget-function-prompt-value-history
icicle-font-name-history hi-lock-face-history hi-lock-regexp-history
shell-command-history icicle-search-replacement-history
icicle-function-name-history face-name-history icicle-function-history
icicle-text-property-value-history icicle-dictionary-history icicle-kill-history
icicle-color-theme-history icicle-bookmark-history icicle-kmacro-history
icicle-buffer-config-history icicle-search-history icicle-completion-set-history
frame-name-history comint-input-ring dired-shell-command-history
imenu--history-list compile-history Info-search-history search-ring
dired-regexp-history info-lookup-history coding-system-history synonyms-history
icicle-thesaurus-history input-method-history minibuffer-history-search-history
bookmark-history set-any-variable-value-history yes-or-no-p-history
set-variable-value-history query-replace-history grep-history
read-expression-history buffer-name-history command-history regexp-history
file-name-history minibuffer-history extended-command-history)

As you can see, `command-history' was automatically added to
`savehist-minibuffer-history-variables' (because
`savehist-save-minibuffer-history' is t).







  reply	other threads:[~2008-08-18 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18 19:43 bug#445: Invalid read syntax in savehist-mode's history file Chong Yidong
2008-08-18 19:51 ` Daniel Colascione
2008-08-18 20:45 ` martin rudalics
2008-08-18 21:24   ` Drew Adams [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-06-18 18:32 Daniel Colascione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004c01c90178$dad3b2a0$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=445@emacsbugs.donarmstrong.com \
    --cc=cyd@stupidchicken.com \
    --cc=dan.colascione@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).