From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#57556: 28.1; Eshell not finding executables in PATH when tramp-integration loaded Date: Thu, 6 Oct 2022 20:19:26 -0700 Message-ID: <00448968-481d-9bdd-b0c8-7bc3d04e5d60@gmail.com> References: <87h715j5gy.fsf@gmx.de> <0480c49e-75da-68c4-d255-242ff65323fe@gmail.com> <87czbsjyby.fsf@gmx.de> <877d1vthto.fsf@gmx.de> <871qrrffzj.fsf@gmx.de> <2d1f17a5-554d-1b1f-7bcb-52e3839d9d0c@gmail.com> <87wn9iehl1.fsf@gmx.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------74U3h0ZRZbhoU383NLqcl8up" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16967"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57556@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 07 05:20:13 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogduG-0004Fn-5l for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Oct 2022 05:20:12 +0200 Original-Received: from localhost ([::1]:43848 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogduE-0007dY-JP for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 23:20:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58426) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogdu7-0007dL-6u for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 23:20:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34872) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogdu6-0001Es-Th for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 23:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogdu6-0006i3-Bt for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 23:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Oct 2022 03:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57556 X-GNU-PR-Package: emacs Original-Received: via spool by 57556-submit@debbugs.gnu.org id=B57556.166511277725756 (code B ref 57556); Fri, 07 Oct 2022 03:20:02 +0000 Original-Received: (at 57556) by debbugs.gnu.org; 7 Oct 2022 03:19:37 +0000 Original-Received: from localhost ([127.0.0.1]:33950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogdth-0006hM-Cy for submit@debbugs.gnu.org; Thu, 06 Oct 2022 23:19:37 -0400 Original-Received: from mail-pl1-f179.google.com ([209.85.214.179]:43782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogdte-0006h8-VK for 57556@debbugs.gnu.org; Thu, 06 Oct 2022 23:19:36 -0400 Original-Received: by mail-pl1-f179.google.com with SMTP id z20so3410397plb.10 for <57556@debbugs.gnu.org>; Thu, 06 Oct 2022 20:19:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=gVmtivERYiznSx7UV7s+WLAz8y4Mzlwmpe5x3ZcSHO0=; b=L/6+LPig0oe4A3CUvY+SfkMMi8j7K+LnAbn6nwgZeHj+dq+YHJ/v1r5JKyd7bmhi4z zZR4VFP57gXEu5/LMNBkPQAjPBBHHvWpe66V//s88En/GpH6lOa2ff5GMuhbMiTEPlYQ Nq6Li02ZfRQHFj1BZALrsZTYPQjIc12fxlAec3NYajeFz+BL6aVKqZmK8q/PRI7vxlYn J1xqyMK/Qi/7yG64zxBkUDhknTbIC5mHBMLvDYggSkTlS/Ld9gXesh1obtNTwCCy26gm DIhYuSRRYIrmDBLTpJ0HCeAQKjistZodEJAJ56hfpBk8CcMHQ5h4Lb7Yk5hdSI+Hr0dy dNbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=gVmtivERYiznSx7UV7s+WLAz8y4Mzlwmpe5x3ZcSHO0=; b=ZYDu3vPR7wz7p1cbtCwDmhwOq69wtES+RQU7YrNxXtLYyudeZuj4cVZNTYTBc8SG67 rBy9l/m1zj4iK+t4REBdqOCJLmQCpFd/Rn/lvNZujrRyzGj0MbRmeSIHujNQtNrfJP6O MK0ozRTVtUM+F7j3gnM60TMGnr6SxIowm+Kcp0ayddKd/qbUxO9S36j+REm5nYS3F4L9 29et0sQATvdV+iFsRWCvjuHu340T2rIAZ3pf88JXU/eMkVDBGEDJIO/UxdDVpIgsZtbN 57MuaWpt55mc5HPaDZ5iMpjvVWdpETWFUREwrOQUI+cTGebxJuO6mUiA2RVKtduC/Dfb L5HQ== X-Gm-Message-State: ACrzQf1N/QKO3E6jgkn0OhWHL/o8G2JtidshVyBk1RKt5ZKmyH5b8hVj VqUwurWMVz3N5JVq9ByIjDI= X-Google-Smtp-Source: AMsMyM6aBqUIwjXxRkVf5NK5v2vUTr1CMkPhR8LS+vMefOxULb6T/q40tWCM2SwNReLCs0g4YReQug== X-Received: by 2002:a17:90b:4a4d:b0:20a:c49f:9928 with SMTP id lb13-20020a17090b4a4d00b0020ac49f9928mr13958598pjb.133.1665112768995; Thu, 06 Oct 2022 20:19:28 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id l4-20020a635704000000b0045dc85c4a5fsm477456pgb.44.2022.10.06.20.19.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Oct 2022 20:19:27 -0700 (PDT) Content-Language: en-US In-Reply-To: <87wn9iehl1.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244727 Archived-At: This is a multi-part message in MIME format. --------------74U3h0ZRZbhoU383NLqcl8up Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/2/2022 1:48 AM, Michael Albinus wrote: > Yes. with-connection-local-variables is designed to provide those > variables inside the BODY only. And you have used nil as CRITERIA in > connection-local-set-profiles, which means you get the same variables > for every kind of default-directory, which means you don't use > connection-local variables at all :-) > > What you need is a permanent setting of variables. Something like > > (connection-local-set-profiles > (connection-local-criteria-for-default-directory 'eshell) > 'eshell-connection-local-profile) > > (let ((enable-connection-local-variables t) > connection-local-variables-alist) ;; I'm not sure this is needed. > (hack-connection-local-variables-apply > (connection-local-criteria-for-default-directory 'eshell)) > ;; The body. > ...) Hmm, I've tried this a few different ways, and I haven't been able to get it to work the way it should. Maybe I'm just missing something? Attached is a minimal test case I've extracted to show the issue I'm having. It seems the problem is that, while I can update the path in 'eshell-set-path' with no problem, when I call 'eshell-get-path' again, 'hack-connection-local-variables-apply' resets 'eshell-path-env-list' to nil, so the modified path is lost. Do you have any ideas about what I'm doing wrong? Or maybe connection-local variables aren't supposed to be used this way. All the documentation I see on them involves setting variables to constant values, not updating them in-place over the life of a program. --------------74U3h0ZRZbhoU383NLqcl8up Content-Type: text/plain; charset=UTF-8; name="connection-local.el" Content-Disposition: attachment; filename="connection-local.el" Content-Transfer-Encoding: base64 Ozs7IC0qLSBsZXhpY2FsLWJpbmRpbmc6dCAtKi0KCjs7IFJ1biB0aGVzZSB0ZXN0cyB3aXRo Ogo7OyAgZW1hY3MgLVEgLS1iYXRjaCAtbCB+L2V0Yy9lbWFjcy9jb25uZWN0aW9uLWxvY2Fs LmVsIFwKOzsgICAgICAgIC0tZXZhbCAnKGVydC1ydW4tdGVzdHMtYmF0Y2gtYW5kLWV4aXQg dCknCgoocmVxdWlyZSAndHJhbXApCihyZXF1aXJlICdlcnQpCihyZXF1aXJlICdlcnQteCkK CihkZWZ2YXItbG9jYWwgZXNoZWxsLXBhdGgtZW52LWxpc3QgbmlsKQoKKGNvbm5lY3Rpb24t bG9jYWwtc2V0LXByb2ZpbGUtdmFyaWFibGVzCiAnZXNoZWxsLWNvbm5lY3Rpb24tbG9jYWwt cHJvZmlsZQogJygoZXNoZWxsLXBhdGgtZW52LWxpc3QgLiBuaWwpKSkKCihjb25uZWN0aW9u LWxvY2FsLXNldC1wcm9maWxlcwogKGNvbm5lY3Rpb24tbG9jYWwtY3JpdGVyaWEtZm9yLWRl ZmF1bHQtZGlyZWN0b3J5ICdlc2hlbGwpCiAnZXNoZWxsLWNvbm5lY3Rpb24tbG9jYWwtcHJv ZmlsZSkKCihkZWZ1biBlc2hlbGwtZ2V0LXBhdGggKCkKICAiUmV0dXJuICRQQVRIIGFzIGEg bGlzdC4iCiAgKGxldCAoKGVuYWJsZS1jb25uZWN0aW9uLWxvY2FsLXZhcmlhYmxlcyB0KQog ICAgICAgIGNvbm5lY3Rpb24tbG9jYWwtdmFyaWFibGVzLWFsaXN0KSA7OyBJJ20gbm90IHN1 cmUgdGhpcyBpcyBuZWVkZWQuCiAgICAoaGFjay1jb25uZWN0aW9uLWxvY2FsLXZhcmlhYmxl cy1hcHBseQogICAgIChjb25uZWN0aW9uLWxvY2FsLWNyaXRlcmlhLWZvci1kZWZhdWx0LWRp cmVjdG9yeSAnZXNoZWxsKSkKICAgIChvciBlc2hlbGwtcGF0aC1lbnYtbGlzdAogICAgICAg IDs7IElmIG5vdCBhbHJlYWR5IGNhY2hlZCwgZ2V0IHRoZSBwYXRoIGZyb20gYGV4ZWMtcGF0 aCcsCiAgICAgICAgOzsgcmVtb3ZpbmcgdGhlIGxhc3QgZWxlbWVudCwgd2hpY2ggaXMgYGV4 ZWMtZGlyZWN0b3J5Jy4KICAgICAgICAoc2V0cSBlc2hlbGwtcGF0aC1lbnYtbGlzdCAoYnV0 bGFzdCAoZXhlYy1wYXRoKSkpKSkpCgooZGVmdW4gZXNoZWxsLXNldC1wYXRoIChwYXRoKQog ICJTZXQgdGhlIEVzaGVsbCAkUEFUSCB0byBQQVRILgpQQVRIIGNhbiBiZSBlaXRoZXIgYSBs aXN0IG9mIGRpcmVjdG9yaWVzIG9yIGEgc3RyaW5nIG9mCmRpcmVjdG9yaWVzIHNlcGFyYXRl ZCBieSBgcGF0aC1zZXBhcmF0b3InLiIKICAobGV0ICgoZW5hYmxlLWNvbm5lY3Rpb24tbG9j YWwtdmFyaWFibGVzIHQpCiAgICAgICAgY29ubmVjdGlvbi1sb2NhbC12YXJpYWJsZXMtYWxp c3QpIDs7IEknbSBub3Qgc3VyZSB0aGlzIGlzIG5lZWRlZC4KICAgIChoYWNrLWNvbm5lY3Rp b24tbG9jYWwtdmFyaWFibGVzLWFwcGx5CiAgICAgKGNvbm5lY3Rpb24tbG9jYWwtY3JpdGVy aWEtZm9yLWRlZmF1bHQtZGlyZWN0b3J5ICdlc2hlbGwpKQogICAgKHNldHEgZXNoZWxsLXBh dGgtZW52LWxpc3QKICAgICAgICAgIChpZiAobGlzdHAgcGF0aCkKICAgICAgICAgICAgICBw YXRoCiAgICAgICAgICAgIDs7IERvbid0IHVzZSBgcGFyc2UtY29sb24tcGF0aCcgaGVyZSwg c2luY2Ugd2UgZG9uJ3Qgd2FudAogICAgICAgICAgICA7OyB0aGUgYWRkaXRvbmFsIHRyYW5z bGF0aW9ucyBpdCBkb2VzIG9uIGVhY2ggZWxlbWVudC4KICAgICAgICAgICAgKHNwbGl0LXN0 cmluZyBwYXRoIChwYXRoLXNlcGFyYXRvcikpKSkpKQoKKGVydC1kZWZ0ZXN0IGVzaC12YXIt dGVzdC9wYXRoLXZhci9wcmVzZXJ2ZS1hY3Jvc3MtaG9zdHMgKCkKICAiVGVzdCB0aGF0ICRQ QVRIIGNhbiBiZSBzZXQgaW5kZXBlbmRlbnRseSBvbiBtdWx0aXBsZSBob3N0cy4iCiAgOzsg VGVzdCB0aGUgaW5pdGlhbCB2YWx1ZSBvZiB0aGUgbG9jYWwgJFBBVEguCiAgKHNob3VsZCAo ZXF1YWwgKGVzaGVsbC1nZXQtcGF0aCkgKGJ1dGxhc3QgKGV4ZWMtcGF0aCkpKSkKCiAgOzsg U2V0IHRoZSBsb2NhbCAkUEFUSCBhbmQgbWFrZSBzdXJlIGl0IHJldGFpbnMgdGhlIHZhbHVl IHdlIHNldC4KICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLXNldC1wYXRoICIvbG9jYWwvcGF0 aCIpICcoIi9sb2NhbC9wYXRoIikpKQogIChzaG91bGQgKGVxdWFsIChlc2hlbGwtZ2V0LXBh dGgpICcoIi9sb2NhbC9wYXRoIikpKSAgICAgIDsgRkFJTAoKICAobGV0ICgoZGVmYXVsdC1k aXJlY3RvcnkgZXJ0LXJlbW90ZS10ZW1wb3JhcnktZmlsZS1kaXJlY3RvcnkpKQogICAgOzsg VGVzdCB0aGUgaW5pdGlhbCB2YWx1ZSBvZiB0aGUgcmVtb3RlICRQQVRILgogICAgKHNob3Vs ZCAoZXF1YWwgKGVzaGVsbC1nZXQtcGF0aCkgKGJ1dGxhc3QgKGV4ZWMtcGF0aCkpKSkKCiAg ICA7OyBTZXQgdGhlIHJlbW90ZSAkUEFUSCBhbmQgbWFrZSBzdXJlIGl0IHJldGFpbnMgdGhl IHZhbHVlIHdlIHNldC4KICAgIChzaG91bGQgKGVxdWFsIChlc2hlbGwtc2V0LXBhdGggIi9y ZW1vdGUvcGF0aCIpICcoIi9yZW1vdGUvcGF0aCIpKSkKICAgIChzaG91bGQgKGVxdWFsIChl c2hlbGwtZ2V0LXBhdGgpICcoIi9yZW1vdGUvcGF0aCIpKSkpICA7IEZBSUwKCiAgOzsgTWFr ZSBzdXJlIHdlIGdldCB0aGUgbG9jYWwgJFBBVEggd2Ugc2V0IGFib3ZlLgogIChzaG91bGQg KGVxdWFsIChlc2hlbGwtZ2V0LXBhdGgpICcoIi9sb2NhbC9wYXRoIikpKSAgICAgIDsgRkFJ TAoKICA7OyBNYWtlIHN1cmUgd2UgZ2V0IHRoZSByZW1vdGUgJFBBVEggd2Ugc2V0IGFib3Zl LgogIChsZXQgKChkZWZhdWx0LWRpcmVjdG9yeSBlcnQtcmVtb3RlLXRlbXBvcmFyeS1maWxl LWRpcmVjdG9yeSkpCiAgICAoc2hvdWxkIChlcXVhbCAoZXNoZWxsLWdldC1wYXRoKSAnKCIv cmVtb3RlL3BhdGgiKSkpKSkgOyBGQUlMCg== --------------74U3h0ZRZbhoU383NLqcl8up--