From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#66635: 30.0.50; customize-icon State button doesn't work (never did) Date: Sat, 21 Oct 2023 08:09:59 -0300 Message-ID: <003ee580-1063-4673-9ca4-b3542e21a1b7@gmail.com> References: <0b43fa93-0540-45ec-ab2d-b2843888c806@gmail.com> <1034a4cb-217a-4e60-a474-bf07948e3dd1@gmail.com> <83cyx8sa1e.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5526"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: stefankangas@gmail.com, 66635@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 21 13:10:48 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qu9sU-0001H4-Ke for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 21 Oct 2023 13:10:46 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qu9sK-0007ct-TG; Sat, 21 Oct 2023 07:10:36 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qu9sI-0007cP-Iu for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 07:10:34 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qu9sI-0007aU-AA for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 07:10:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qu9sk-0004sz-05 for bug-gnu-emacs@gnu.org; Sat, 21 Oct 2023 07:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Oct 2023 11:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66635 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66635-submit@debbugs.gnu.org id=B66635.169788665118763 (code B ref 66635); Sat, 21 Oct 2023 11:11:01 +0000 Original-Received: (at 66635) by debbugs.gnu.org; 21 Oct 2023 11:10:51 +0000 Original-Received: from localhost ([127.0.0.1]:42363 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9sZ-0004sZ-Dz for submit@debbugs.gnu.org; Sat, 21 Oct 2023 07:10:51 -0400 Original-Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]:56533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qu9sW-0004sL-R5 for 66635@debbugs.gnu.org; Sat, 21 Oct 2023 07:10:49 -0400 Original-Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-6b709048f32so1398341b3a.0 for <66635@debbugs.gnu.org>; Sat, 21 Oct 2023 04:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697886615; x=1698491415; darn=debbugs.gnu.org; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=prgS7GZcw9+JDX2EGDmpMU3VpKMz4CruTcYrwy/ASXg=; b=OVCAokCdm9sV+FuwDbfVQlZJwaF7vhpkyVYR4aTwDHUX6c192uhfCCPgHda89LRQY4 gfLIFu2F9ITdK0nuTCPp/hilUASeLeNLmb0sxI6IaxWi3mKbdwb0izXPHwFLcSS5vwp5 88KYwsShHHrsSyHZZG57CnBCa94o1xyJCdrPna6u0+AaP1dPa7pDLUia1FyBb2w1O0hy LVAzAsik0f+z1x/csld94tfmbQAkc6weLFULF6vQaJjYOkOnyjQUaQLWq6ZuNnItTYmO jD0EEgJ0jVu0L43IsN1S8qsHrVWv9t8qObPBZo/wCXrZlzoBhpV6QfwZIO6iVeOTVBSA vELA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697886615; x=1698491415; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=prgS7GZcw9+JDX2EGDmpMU3VpKMz4CruTcYrwy/ASXg=; b=aGcwjoXnLZxTRMqtN9G73NvBITVqjCAz6Xzsbyt44FXlHMxWYPMSDqHphfMLfTabSZ a5Lj89Z3XZ0qRLdV6wKPtdA+mrgeo4npxsCujQ3hdte8ZCpukSEwQqvg8mgG7vDgKbL1 SliIYUHLUWdFYxcaSRMsskG2Pizjs7Z+VFToEs9CsnflFL80bcdIHaaKxm4YylZbOnlz pGqHWCS1YkVPGk80ar+xQcImHE6C/fYN2peOuGCLvRwrMwKGtjUFBWhpZ8UxzyiN5WwL UdbXTmcusGNsO74JRX6Yi/1ONfsWrOsuB3mbtPBXDptfl18VLAOiqIprnFM2xRlTQ4QN 18Mw== X-Gm-Message-State: AOJu0YwONpDpNcTjjW7jPTma/7hSPwSZ4S6VwyDb2QqPEWdJ4+LjU6M+ KRGFWZtOOt3G45TXqW8Bv8E= X-Google-Smtp-Source: AGHT+IEk2XR1nlZXcFLfMEbGEgdnzO2faRDpLskih7xi+REDMwQociVpYzpao00f/S7hgnw30wrB/g== X-Received: by 2002:aa7:9622:0:b0:68e:42c9:74e0 with SMTP id r2-20020aa79622000000b0068e42c974e0mr3661698pfg.3.1697886614756; Sat, 21 Oct 2023 04:10:14 -0700 (PDT) Original-Received: from [192.168.0.234] ([152.168.142.156]) by smtp.gmail.com with ESMTPSA id g5-20020aa79dc5000000b006bd2bbbaf49sm3062062pfq.122.2023.10.21.04.10.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 21 Oct 2023 04:10:14 -0700 (PDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:272862 Archived-At: On 21/10/23 07:18, Mauro Aranda wrote: > On 21/10/23 04:35, Eli Zaretskii wrote: > > How well is the fix tested? Did you test it with several icons > > introduced in Emacs 29 in various modes? If not, would you please > > test those and see the changes work well enough there to be > > appropriate for a bug-fix release? > > I just tested with the button icon, the only one suggested after > running emacs -Q. I tested making modifications in the buffer, and that > the two options (three if not started with -Q) work and do what's > intended. Namely: > - Undo Editions took me back to the STANDARD state. > - Setting for the session modified the specs for the session and > correctly displayed the SET state. > - Saving the setting saved a spec that in a new session (without emacs > -Q) causes: > M-x describe-icon RET button > to show the button customized. The value I changed for that was from > LARGE BLUE CIRCLE to LARGE RED SQUARE > > It's important to note that saving the setting shows the SET state > (rather than the SAVED state), but that's in a FIXME right before > custom-icon-state. > > I'll do some more testing with the icons defined in outline.el, > tab-bar.el and warnings.el. Additionally I'll try to test if > Customizing an icon interacts good enough with a Theme customizations. > I'll do that and report back. I checked outline.el icons and everything seems to work OK. Tested in some buffer with outline-mode, including the NEWS file. Savings get loaded correctly. Similarly with warning-suppress icon. With tab-bar.el I tried other images, and works fine too. It didn't get updated immediately, but after some time and user interaction, it showed the new image. I don't use tab-bar-mode so maybe there's something to do to make it update. Then I created a foo theme to customize icons and pon starting emacs and customizing the icons the state was THEMED, and after customizing them my customizations were respected. So that works fine too. One thing I found, but not related to my patch (and see below for others) is that I had to require 'cus-edit to make custom-theme-set-icons available. That might not be optimal. To sum it up, after testing more thoroughly, I haven't yet found any trouble with my patch, which improves considerably icons customization. More work needs to be done (expanding state checking, reverting customizations, improving help in the custom buffer, adding support in customize-create-theme, showing the image that would get used, etc), but those should be separate bug reports, I think.