* bug#662: 23.0.60; Constant recentering with scroll-margin set
@ 2008-08-07 1:54 Chong Yidong
2008-08-07 18:21 ` Ralf Angeli
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Chong Yidong @ 2008-08-07 1:54 UTC (permalink / raw)
To: Ralf Angeli; +Cc: 662
Actually, I see the bug now. I've made some changes to CVS that ought
to fix it. Does it work for you now?
^ permalink raw reply [flat|nested] 11+ messages in thread* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-07 1:54 bug#662: 23.0.60; Constant recentering with scroll-margin set Chong Yidong
@ 2008-08-07 18:21 ` Ralf Angeli
2008-08-07 18:41 ` Ralf Angeli
2008-08-08 18:32 ` Ralf Angeli
2 siblings, 0 replies; 11+ messages in thread
From: Ralf Angeli @ 2008-08-07 18:21 UTC (permalink / raw)
To: Chong Yidong; +Cc: 662
* Chong Yidong (2008-08-07) writes:
> Actually, I see the bug now. I've made some changes to CVS that ought
> to fix it. Does it work for you now?
It's better, but it doesn't seem to be totally fixed. There is still
some recentering happening when scrolling a long article in Gnus. If
you type <RET> to scroll, the bottom of the article will be reached
eventually and once this happens, the buffer will be recentered and the
last line jumps to the middle of the window.
--
Ralf
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-07 1:54 bug#662: 23.0.60; Constant recentering with scroll-margin set Chong Yidong
2008-08-07 18:21 ` Ralf Angeli
@ 2008-08-07 18:41 ` Ralf Angeli
2008-08-08 18:32 ` Ralf Angeli
2 siblings, 0 replies; 11+ messages in thread
From: Ralf Angeli @ 2008-08-07 18:41 UTC (permalink / raw)
To: Chong Yidong; +Cc: 662
* Ralf Angeli (2008-08-07) writes:
> * Chong Yidong (2008-08-07) writes:
>
>> Actually, I see the bug now. I've made some changes to CVS that ought
>> to fix it. Does it work for you now?
>
> It's better, but it doesn't seem to be totally fixed. There is still
> some recentering happening when scrolling a long article in Gnus. If
> you type <RET> to scroll, the bottom of the article will be reached
> eventually and once this happens, the buffer will be recentered and the
> last line jumps to the middle of the window.
It could also be that this has to be fixed in Gnus. I'm not sure, but I
remember that there was a similar issue back in 2005 where some changes
hat to be made in `gnus-article-next-page' and related functions in
order to deal with some changes in the handling of `scroll-margin'.
--
Ralf
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-07 1:54 bug#662: 23.0.60; Constant recentering with scroll-margin set Chong Yidong
2008-08-07 18:21 ` Ralf Angeli
2008-08-07 18:41 ` Ralf Angeli
@ 2008-08-08 18:32 ` Ralf Angeli
2008-08-08 20:56 ` Stefan Monnier
` (3 more replies)
2 siblings, 4 replies; 11+ messages in thread
From: Ralf Angeli @ 2008-08-08 18:32 UTC (permalink / raw)
To: Chong Yidong; +Cc: 662
* Ralf Angeli (2008-08-07) writes:
> It could also be that this has to be fixed in Gnus. I'm not sure, but I
> remember that there was a similar issue back in 2005 where some changes
> hat to be made in `gnus-article-next-page' and related functions in
> order to deal with some changes in the handling of `scroll-margin'.
Okay, the problem is the statement
(move-to-window-line -1)
in `gnus-article-next-page'. If `scroll-margin' is set and greater than
0 it will lead to a recentering. This is usually countered by
`gnus-article-next-page-1', but not at the end of an article where
`gnus-article-next-page-1' will not be called.
The problem can be circumvented by changing the above statement to
(move-to-window-line (- -1 scroll-margin))
Let me know if the recentering behavior will stay like it is now, then I
can report this to the Gnus maintainers.
--
Ralf
^ permalink raw reply [flat|nested] 11+ messages in thread* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
@ 2008-08-08 20:56 ` Stefan Monnier
2008-08-12 18:51 ` Ralf Angeli
2008-08-09 1:00 ` ＯＦＦＩＣＥ ZERO
` (2 subsequent siblings)
3 siblings, 1 reply; 11+ messages in thread
From: Stefan Monnier @ 2008-08-08 20:56 UTC (permalink / raw)
To: Ralf Angeli; +Cc: 662, Chong Yidong
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
BTW, shouldn't Gnus "just" set scroll-margin (and such things)
buffer-locally in its article buffer, so as to isolate it from
such problems?
Or maybe not buffer-locally but let-bound around a call to redisplay?
Stefan
^ permalink raw reply [flat|nested] 11+ messages in thread* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 20:56 ` Stefan Monnier
@ 2008-08-12 18:51 ` Ralf Angeli
0 siblings, 0 replies; 11+ messages in thread
From: Ralf Angeli @ 2008-08-12 18:51 UTC (permalink / raw)
To: Stefan Monnier, ding; +Cc: 662, Chong Yidong
* Stefan Monnier (2008-08-08) writes:
> BTW, shouldn't Gnus "just" set scroll-margin (and such things)
> buffer-locally in its article buffer, so as to isolate it from
> such problems?
> Or maybe not buffer-locally but let-bound around a call to redisplay?
I guess this is something to decide for the Gnus developers, so I am
forwarding the message to the Gnus list.
Note that this discussion is centered around the recentering bug I
reported earlier on the Gnus list, so this is not related to a new bug.
--
Ralf
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
2008-08-08 20:56 ` Stefan Monnier
@ 2008-08-09 1:00 ` ＯＦＦＩＣＥ ZERO
2008-08-09 1:07 ` ＯＦＦＩＣＥ ZERO
2008-08-09 14:13 ` ＯＦＦＩＣＥ ZERO
3 siblings, 0 replies; 11+ messages in thread
From: ＯＦＦＩＣＥ ZERO @ 2008-08-09 1:00 UTC (permalink / raw)
To: Ralf Angeli, 662
配信不要
----- Original Message -----
From: "Ralf Angeli" <angeli@caeruleus.net>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: <662@emacsbugs.donarmstrong.com>
Sent: Saturday, August 09, 2008 3:32 AM
Subject: bug#662: 23.0.60; Constant recentering with scroll-margin set
>* Ralf Angeli (2008-08-07) writes:
>
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
>
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
>
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
>
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
>
> --
> Ralf
>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
2008-08-08 20:56 ` Stefan Monnier
2008-08-09 1:00 ` ＯＦＦＩＣＥ ZERO
@ 2008-08-09 1:07 ` ＯＦＦＩＣＥ ZERO
2008-08-09 14:13 ` ＯＦＦＩＣＥ ZERO
3 siblings, 0 replies; 11+ messages in thread
From: ＯＦＦＩＣＥ ZERO @ 2008-08-09 1:07 UTC (permalink / raw)
To: Ralf Angeli, 662
配信不要
----- Original Message -----
From: "Ralf Angeli" <angeli@caeruleus.net>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: <662@emacsbugs.donarmstrong.com>
Sent: Saturday, August 09, 2008 3:32 AM
Subject: bug#662: 23.0.60; Constant recentering with scroll-margin set
>* Ralf Angeli (2008-08-07) writes:
>
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
>
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
>
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
>
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
>
> --
> Ralf
>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
2008-08-08 18:32 ` Ralf Angeli
` (2 preceding siblings ...)
2008-08-09 1:07 ` ＯＦＦＩＣＥ ZERO
@ 2008-08-09 14:13 ` ＯＦＦＩＣＥ ZERO
3 siblings, 0 replies; 11+ messages in thread
From: ＯＦＦＩＣＥ ZERO @ 2008-08-09 14:13 UTC (permalink / raw)
To: Ralf Angeli, 662
Do'nt send me mail !!!
no tkank you!!
----- Original Message -----
From: "Ralf Angeli" <angeli@caeruleus.net>
To: "Chong Yidong" <cyd@stupidchicken.com>
Cc: <662@emacsbugs.donarmstrong.com>
Sent: Saturday, August 09, 2008 3:32 AM
Subject: bug#662: 23.0.60; Constant recentering with scroll-margin set
>* Ralf Angeli (2008-08-07) writes:
>
>> It could also be that this has to be fixed in Gnus. I'm not sure, but I
>> remember that there was a similar issue back in 2005 where some changes
>> hat to be made in `gnus-article-next-page' and related functions in
>> order to deal with some changes in the handling of `scroll-margin'.
>
> Okay, the problem is the statement
> (move-to-window-line -1)
> in `gnus-article-next-page'. If `scroll-margin' is set and greater than
> 0 it will lead to a recentering. This is usually countered by
> `gnus-article-next-page-1', but not at the end of an article where
> `gnus-article-next-page-1' will not be called.
>
> The problem can be circumvented by changing the above statement to
> (move-to-window-line (- -1 scroll-margin))
>
> Let me know if the recentering behavior will stay like it is now, then I
> can report this to the Gnus maintainers.
>
> --
> Ralf
>
>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
@ 2008-08-07 1:26 Chong Yidong
0 siblings, 0 replies; 11+ messages in thread
From: Chong Yidong @ 2008-08-07 1:26 UTC (permalink / raw)
To: Ralf Angeli; +Cc: 662
> Start Emacs with emacs -Q -eval "(progn (setq scroll-margin 1)
> (dotimes (i 100) (newline)))" and start typing in the scratch buffer.
> With nearly every new line which is inserted, the buffer is
> recentered.
Could you try to provide a more precise recipe? I'm not sure what you
mean.
^ permalink raw reply [flat|nested] 11+ messages in thread
* bug#662: 23.0.60; Constant recentering with scroll-margin set
@ 2008-08-06 21:16 Ralf Angeli
0 siblings, 0 replies; 11+ messages in thread
From: Ralf Angeli @ 2008-08-06 21:16 UTC (permalink / raw)
To: emacs-pretest-bug
Start Emacs with
emacs -Q -eval "(progn (setq scroll-margin 1) (dotimes (i 100) (newline)))"
and start typing in the scratch buffer. With nearly every new line
which is inserted, the buffer is recentered.
In GNU Emacs 23.0.60.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.12.11)
of 2008-08-06 on photon
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
Important settings:
value of $LC_ALL: nil
value of $LC_COLLATE: nil
value of $LC_CTYPE: nil
value of $LC_MESSAGES: nil
value of $LC_MONETARY: nil
value of $LC_NUMERIC: nil
value of $LC_TIME: nil
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: nil
locale-coding-system: utf-8-unix
default-enable-multibyte-characters: t
Major mode: Lisp Interaction
Minor modes in effect:
tooltip-mode: t
mouse-wheel-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
global-auto-composition-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Recent input:
M-x r e p o r t - e m <tab> <return>
Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2008-08-12 18:51 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-08-07 1:54 bug#662: 23.0.60; Constant recentering with scroll-margin set Chong Yidong
2008-08-07 18:21 ` Ralf Angeli
2008-08-07 18:41 ` Ralf Angeli
2008-08-08 18:32 ` Ralf Angeli
2008-08-08 20:56 ` Stefan Monnier
2008-08-12 18:51 ` Ralf Angeli
2008-08-09 1:00 ` ＯＦＦＩＣＥ ZERO
2008-08-09 1:07 ` ＯＦＦＩＣＥ ZERO
2008-08-09 14:13 ` ＯＦＦＩＣＥ ZERO
-- strict thread matches above, loose matches on Subject: below --
2008-08-07 1:26 Chong Yidong
2008-08-06 21:16 Ralf Angeli
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).