From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#2459: 22.2.1: global-font-lock-mode does not turn off colors:ido.el, minibuffer prompt Date: Wed, 25 Feb 2009 09:24:04 -0800 Message-ID: <002b01c9976d$dbf8e0c0$c2b22382@us.oracle.com> References: <871vtot5hx.fsf@jondo.cante.net> Reply-To: Drew Adams , 2459@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1235583846 7536 80.91.229.12 (25 Feb 2009 17:44:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 25 Feb 2009 17:44:06 +0000 (UTC) Cc: 'Jari Aalto' To: "'Stefan Monnier'" , <2459@emacsbugs.donarmstrong.com>, "'Glenn Morris'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 25 18:45:21 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LcNoj-0005Lz-9E for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2009 18:45:09 +0100 Original-Received: from localhost ([127.0.0.1]:51151 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcNnO-0001eS-M5 for geb-bug-gnu-emacs@m.gmane.org; Wed, 25 Feb 2009 12:43:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LcNnK-0001ct-EO for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:43:42 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LcNnI-0001Zg-Nk for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:43:41 -0500 Original-Received: from [199.232.76.173] (port=51751 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LcNnI-0001ZR-JR for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:43:40 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46896) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LcNnI-0006mT-0t for bug-gnu-emacs@gnu.org; Wed, 25 Feb 2009 12:43:40 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PHhbPq018802; Wed, 25 Feb 2009 09:43:37 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1PHU39E014260; Wed, 25 Feb 2009 09:30:03 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 25 Feb 2009 17:30:03 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2459 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2459-submit@emacsbugs.donarmstrong.com id=B2459.123558267612758 (code B ref 2459); Wed, 25 Feb 2009 17:30:03 +0000 Original-Received: (at 2459) by emacsbugs.donarmstrong.com; 25 Feb 2009 17:24:36 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from rgminet12.oracle.com (rcsinet12.oracle.com [148.87.113.124]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1PHOXsc012749 for <2459@emacsbugs.donarmstrong.com>; Wed, 25 Feb 2009 09:24:34 -0800 Original-Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet12.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1PHO5kE013017 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Feb 2009 17:24:06 GMT Original-Received: from acsmt700.oracle.com (acsmt700.oracle.com [141.146.40.70]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1PHO6i0029423; Wed, 25 Feb 2009 17:24:08 GMT Original-Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 25 Feb 2009 09:24:03 -0800 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: AcmXbEXLcfyj965/TR+U141/6Bk1FgAADYfw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt700.oracle.com [141.146.40.70] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090204.49A57EB6.00E7:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Wed, 25 Feb 2009 12:43:41 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25699 Archived-At: > > These features, and several other places that use colour, are not > > implemented using font-lock, so toggling global-font-lock-mode > > has no effect. In this specific case, you can set ido-use-faces > > and customize the minibuffer-prompt face. > > Several places now use the `font-lock-face' property so that toggling > font-lock indeed also toggles the corresponding highlighting. > Maybe we should use that a bit more. > > This said, font-lock has traditionally been used for the highlighting > of buffer's contents, as opposed to modelines, menu-bars, and > minibuffers. > > What Jari seems to be suggesting is to let the minibuffer highlighting > obey font-lock as well. Maybe it's a good idea. I do not know. My 2c: It's not a good idea. That would dilute the meaning of the concept font-lock and its behavior. It would mean that you could not turn on/off font-lock highlighting independently of the highlighting of such features. The use case seems to be only to turn off *all* highlighting. We should find a good way to handle that particular use case. Equating all highlighting to font-lock highlighting, just to respond to this use case, would be using a sledge hammer to kill a fly - a step backward. This is not the first time someone has complained about not being able to turn off the highlighting added by such things as the minibuffer prompt. This is a reaction to our adding that highlighting, and enabling it by default. It has nothing per se to do with font-lock and syntax highlighting. TRT is to look for an easy way for a user to turn off *all* highlighting (but without affecting other face properties, presumably) - without messing with font-lock behavior.