unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Drew Adams" <drew.adams@oracle.com>
To: "'Stefan Monnier'" <monnier@iro.umontreal.ca>
Cc: bug-gnu-emacs@gnu.org
Subject: RE: bookmark structure
Date: Sat, 5 Apr 2008 09:53:02 -0700	[thread overview]
Message-ID: <001a01c8973d$83946980$0200a8c0@us.oracle.com> (raw)
In-Reply-To: <jwvtzig1j7b.fsf-monnier+emacsbugreports@gnu.org>

> > The doc string of bookmark-alist says each entry has this form:
> > (NAME
> >   (filename . FILE)
> >   (front-context-string . FRONT-STR)
> >   (rear-context-string  . REAR-STR)
> >   (position . POS)
> >   (info-node . POS)
> >   (annotation . ANNOTATION))
>  
> That's already fixed in the trunk.

Still doesn't look right to me:

 "where each BOOKMARK is typically of the form

 \(NAME
  (\(filename . FILE\)
   \(front-context-string . FRONT-STR\)
   \(rear-context-string  . REAR-STR\)
   \(position . POS\)
   \(annotation . ANNOTATION\)\))

 So the cdr of each bookmark is an alist too."

Aside from the unnecessary \'s (not a problem, but harder to read the code), the
last sentence is misleading (and unnecessary). The cdr of each bookmark is a
singleton list whose element is an alist.

And what I said about the code comment still holds:

> bookmark-name, string-in-front, string-behind, and the second
> occurrence of annotation here should be uppercase here.





  reply	other threads:[~2008-04-05 16:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-05  0:02 bookmark structure Drew Adams
2008-04-05 14:15 ` Stefan Monnier
2008-04-05 16:53   ` Drew Adams [this message]
2008-04-05 18:02     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001a01c8973d$83946980$0200a8c0@us.oracle.com' \
    --to=drew.adams@oracle.com \
    --cc=bug-gnu-emacs@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).