From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs Subject: bug#2397: 23.0.90; grep no longer highlights the match Date: Sun, 22 Feb 2009 12:04:02 -0800 Message-ID: <001601c99528$b5b2e380$0200a8c0@us.oracle.com> References: <011f01c992e9$854a3cc0$c2b22382@us.oracle.com><000f01c99516$f20a9a10$0200a8c0@us.oracle.com> <874oymnvx3.fsf@jurta.org> Reply-To: Drew Adams , 2397@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1235334236 17124 80.91.229.12 (22 Feb 2009 20:23:56 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 22 Feb 2009 20:23:56 +0000 (UTC) Cc: 2397@emacsbugs.donarmstrong.com To: "'Juri Linkov'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 22 21:25:12 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LbKsx-0003AN-2Z for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Feb 2009 21:25:11 +0100 Original-Received: from localhost ([127.0.0.1]:45020 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LbKrc-0007EO-IK for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Feb 2009 15:23:48 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LbKrY-0007EG-RH for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2009 15:23:44 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LbKrX-0007Dy-5C for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2009 15:23:44 -0500 Original-Received: from [199.232.76.173] (port=60332 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LbKrW-0007Dp-Vt for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2009 15:23:43 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42093) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LbKrW-0002iD-HE for bug-gnu-emacs@gnu.org; Sun, 22 Feb 2009 15:23:42 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1MKNa84021303; Sun, 22 Feb 2009 12:23:36 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1MKA5Ue017878; Sun, 22 Feb 2009 12:10:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 22 Feb 2009 20:10:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: followup 2397 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 2397-submit@emacsbugs.donarmstrong.com id=B2397.123533303415809 (code B ref 2397); Sun, 22 Feb 2009 20:10:04 +0000 Original-Received: (at 2397) by emacsbugs.donarmstrong.com; 22 Feb 2009 20:03:54 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from rgminet13.oracle.com (rcsinet13.oracle.com [148.87.113.125]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1MK3ptl015803 for <2397@emacsbugs.donarmstrong.com>; Sun, 22 Feb 2009 12:03:52 -0800 Original-Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1MK4ljo010291 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 22 Feb 2009 20:04:48 GMT Original-Received: from acsmt702.oracle.com (acsmt702.oracle.com [141.146.40.80]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1MK3hKA020427; Sun, 22 Feb 2009 20:03:44 GMT Original-Received: from dradamslap1 (/24.5.128.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 22 Feb 2009 20:03:41 +0000 X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <874oymnvx3.fsf@jurta.org> Thread-Index: AcmVIREXTzMKy3iCQhOE/5W6sekQ2gABeY1g X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt702.oracle.com [141.146.40.80] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090207.49A1AF9E.026D:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Sun, 22 Feb 2009 15:23:44 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25603 Archived-At: > From: Juri Linkov Sent: Sunday, February 22, 2009 11:02 AM > > Even more specifically, it is the change from > > (setenv "GREP_OPTIONS" (concat (getenv "GREP_OPTIONS") " > --color=always")) > > to > > (setenv "GREP_OPTIONS" (concat (getenv "GREP_OPTIONS") " > --color=auto")) > > that introduces the bug. Putting back `always' in place of > `auto' restores the > > highlighting. > > > > Why `auto' doesn't work, I don't know. > > This change was the result of the following discussion: > > http://thread.gmane.org/gmane.emacs.bugs/16956 > http://thread.gmane.org/gmane.emacs.devel/83316 > > As you can see grep source code emits highlighting sequences > only when TERM is not "dumb". So we set it to "emacs-grep". > > if(isatty(STDOUT_FILENO) && getenv("TERM") && > strcmp(getenv("TERM"), "dumb")) > color_option = 1; > else > color_option = 0; > > Could you please post the value of `process-connection-type'. `process-connection-type' has value t. > Also please eval `M-x grep RET set RET' Sorry, I don't understand. That does nothing; it just exits with no matches found - there are no file arguments specified. And in which directory? With which `grep' switches? I don't follow. > and show the value of the environment variable `TERM'. M-: (getenv "TERM) gives "dumb", both in emacs -Q and in my own environment (i.e., after loading the cywin libraries I mentioned). > If it is "emacs-grep" then I'm afraid it is the line > "isatty(STDOUT_FILENO)" in grep source code that fails > in your environment. It's not. And as I mentioned, before your change highlighting works fine.