From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Bob Floyd" Newsgroups: gmane.emacs.bugs Subject: bug#45617: loses the edit region. Works in 23.3, broke in 26.3 Date: Fri, 15 Jan 2021 10:05:04 -0800 Message-ID: <000c01d6eb68$f3f675f0$dbe361d0$@net> References: <000001d6e16c$984bcb70$c8e36250$@net> <83turycc18.fsf@gnu.org> <87ble4ob6v.fsf@mail.linkov.net> <000601d6e2ea$8f6601e0$ae3205a0$@net> <877dorkznt.fsf@mail.linkov.net> <002701d6e39b$4ac35680$e04a0380$@net> <8735ze9e09.fsf@mail.linkov.net> <83mtxm0vzd.fsf@gnu.org> <002d01d6e478$ca50cdf0$5ef269d0$@net> <87k0sgirr0.fsf@mail.linkov.net> <002101d6eadc$e816a070$b843e150$@net> <87k0sezj07.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1634"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 45617@debbugs.gnu.org To: "'Juri Linkov'" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 15 19:06:48 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1l0TUm-0000Lc-5b for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 19:06:48 +0100 Original-Received: from localhost ([::1]:60118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l0TUl-0007Qr-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 15 Jan 2021 13:06:47 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50512) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l0TU2-0007Q1-5x for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:06:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58368) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l0TU1-0001GE-Us for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:06:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1l0TU1-000276-PK for bug-gnu-emacs@gnu.org; Fri, 15 Jan 2021 13:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Bob Floyd" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 15 Jan 2021 18:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 45617 X-GNU-PR-Package: emacs Original-Received: via spool by 45617-submit@debbugs.gnu.org id=B45617.16107339208077 (code B ref 45617); Fri, 15 Jan 2021 18:06:01 +0000 Original-Received: (at 45617) by debbugs.gnu.org; 15 Jan 2021 18:05:20 +0000 Original-Received: from localhost ([127.0.0.1]:41681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0TTK-00026B-3U for submit@debbugs.gnu.org; Fri, 15 Jan 2021 13:05:20 -0500 Original-Received: from resqmta-po-05v.sys.comcast.net ([96.114.154.164]:60766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1l0TTE-00025k-Oi for 45617@debbugs.gnu.org; Fri, 15 Jan 2021 13:05:16 -0500 Original-Received: from resomta-po-08v.sys.comcast.net ([96.114.154.232]) by resqmta-po-05v.sys.comcast.net with ESMTP id 0SDWlxUZjoWle0TT8lO7Gi; Fri, 15 Jan 2021 18:05:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=20190202a; t=1610733906; bh=K7LCJ1qBewwDL3sYoP60ew57gnJQjFoJxFCpif1j0sM=; h=Received:Received:From:To:Subject:Date:Message-ID:MIME-Version: Content-Type; b=oZ+Y7Yvu6vn+xyJxHwNGAkMsQ+ZqWsf/M3LLpaGQhKvaQVnTwfs+0IW+43OEcNeQy r6fE4rhvh1WosgAvabLA9qTynF5AR7PVUK/dpxjF+g+EiBKlAmxV5tBasdEKKuypzk cleNbN++m6KyKy+pw7bu+eK0lJTL74FFp/vWW6fRXdnLqz+4HiL/VteghkYOw2wihf L6KWTb8LIuAYoupPnHEZEUK+LfIHunJ71gRVEl9n+qI5WULpLgRZfhNVBCrj7e2hXi sH57vtIJyyWFDETcEIywpzM181pEOf4O7/yk96PCmQF6+oETidXnVRMtR1j3JENVDb lV3Zev94M6EoA== Original-Received: from Cache ([IPv6:2601:647:6100:1480::5a21]) by resomta-po-08v.sys.comcast.net with ESMTPA id 0TT6lHVr38b6T0TT7l01wD; Fri, 15 Jan 2021 18:05:06 +0000 X-Xfinity-VMeta: sc=-100.00;st=legit In-Reply-To: <87k0sezj07.fsf@mail.linkov.net> X-Mailer: Microsoft Office Outlook 12.0 Thread-Index: AdbrHziXuXmfJwLtSGuGID0M5A7yRwAR4FDA Content-Language: en-us X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:197996 Archived-At: I'm having an issue with the new patch. fails! 1. Select entire region by dragging mouse. 2. Begin In the command window: Query replace in region: 3. Enter RL using the keyboard In the command window: Query replace in region RL with: 4. Now, with the mouse, select RL at line 12 ... paramset P2 RL; <--- THIS ONE ... then yank it to the command window and with keyboard enter X: In the command window: Query replace in region RL with: RLX 5. Enter Only one of the two RL's in the region are selected, depending on if the region was selected from top-to-bottom or bottom-to-top. It should select both RL's! ---------------------------------------------------- module RL ( electrical in, out ); parameter real R1 = 7000.0; parameter real C = 1p; analog begin I(in,out) <+ V(in,out) / R1; I(out) <+ C * ddt( V(out) ); end endmodule // Sub paramset P2 RL; parameter real R=1000; .R1= R; endparamset ---------------------------------------------------- Just in case I misread the diff, this is the function as I have manually patched it: (defun query-replace-read-args (prompt regexp-flag &optional noerror) (unless noerror (barf-if-buffer-read-only)) (save-mark-and-excursion (let* ((from (query-replace-read-from prompt regexp-flag)) (to (if (consp from) (prog1 (cdr from) (setq from (car from))) (query-replace-read-to from prompt regexp-flag)))) (or (and current-prefix-arg (not (eq current-prefix-arg '-))) (and (plist-member (text-properties-at 0 from) 'isearch-regexp-function) (get-text-property 0 'isearch-regexp-function from))) (list from to (and current-prefix-arg (not (eq current-prefix-arg '-))) (and current-prefix-arg (eq current-prefix-arg '-)))))) -----Original Message----- From: Juri Linkov [mailto:juri@linkov.net] Sent: Friday, January 15, 2021 12:55 AM To: Bob Floyd Cc: 'Eli Zaretskii'; 45617@debbugs.gnu.org Subject: Re: bug#45617: loses the edit region. Works in 23.3, broke in 26.3 > I've removed the earlier patch and installed these changes. Now testing it! > Thanks. > > -----Original Message----- > (defun query-replace-read-args (prompt regexp-flag &optional noerror) > (unless noerror > (barf-if-buffer-read-only)) > + (save-mark-and-excursion > (let* ((from (query-replace-read-from prompt regexp-flag)) > (to (if (consp from) (prog1 (cdr from) (setq from (car from))) > (query-replace-read-to from prompt regexp-flag)))) It seems this is what we need to push to be able to close this bug report. Indeed, it fixes only query-replace commands. But fixing all commands that use the minibuffer is not as easy as adding 'save-mark-and-excursion' like in the patch above. The problem is that 'read-from-minibuffer' is implemented in C. If it was implemented in Lisp, it would be easy to add just 'save-mark-and-excursion', but in C this is impossible.