From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Drew Adams" Newsgroups: gmane.emacs.bugs,gmane.emacs.pretest.bugs Subject: bug#2414: 23.0.90; use dired-guess-default too for minibuffer-default-add-shell-commands Date: Fri, 20 Feb 2009 12:01:29 -0800 Message-ID: <000601c99396$05d396a0$0200a8c0@us.oracle.com> Reply-To: Drew Adams , 2414@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1235161445 4220 80.91.229.12 (20 Feb 2009 20:24:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 20 Feb 2009 20:24:05 +0000 (UTC) To: Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Feb 20 21:25:21 2009 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Labvn-0000vS-Mn for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2009 21:25:08 +0100 Original-Received: from localhost ([127.0.0.1]:37411 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LabuT-0004FE-AK for geb-bug-gnu-emacs@m.gmane.org; Fri, 20 Feb 2009 15:23:45 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LabuO-0004Et-V6 for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2009 15:23:40 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LabuN-0004EZ-4J for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2009 15:23:39 -0500 Original-Received: from [199.232.76.173] (port=50229 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LabuN-0004EW-1a for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2009 15:23:39 -0500 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:46239) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LabuM-0004TT-HP for bug-gnu-emacs@gnu.org; Fri, 20 Feb 2009 15:23:38 -0500 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1KKNaar003643; Fri, 20 Feb 2009 12:23:36 -0800 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id n1KKA5a7032604; Fri, 20 Feb 2009 12:10:05 -0800 X-Loop: owner@emacsbugs.donarmstrong.com Resent-From: "Drew Adams" Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Fri, 20 Feb 2009 20:10:04 +0000 Resent-Message-ID: Resent-Sender: owner@emacsbugs.donarmstrong.com X-Emacs-PR-Message: report 2414 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by submit@emacsbugs.donarmstrong.com id=B.123516010430331 (code B ref -1); Fri, 20 Feb 2009 20:10:04 +0000 Original-Received: (at submit) by emacsbugs.donarmstrong.com; 20 Feb 2009 20:01:44 +0000 X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. Original-Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n1KK1fpo030325 for ; Fri, 20 Feb 2009 12:01:42 -0800 Original-Received: from mx10.gnu.org ([199.232.76.166]:52090) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LabX1-0002Ed-5c for emacs-pretest-bug@gnu.org; Fri, 20 Feb 2009 14:59:31 -0500 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LabZ2-0006WG-QH for emacs-pretest-bug@gnu.org; Fri, 20 Feb 2009 15:01:38 -0500 Original-Received: from rcsinet13.oracle.com ([148.87.113.125]:54156 helo=rgminet13.oracle.com) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LabZ2-0006UC-8d for emacs-pretest-bug@gnu.org; Fri, 20 Feb 2009 15:01:36 -0500 Original-Received: from rgminet15.oracle.com (rcsinet15.oracle.com [148.87.113.117]) by rgminet13.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1KK2WL6025781 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 20 Feb 2009 20:02:33 GMT Original-Received: from acsmt700.oracle.com (acsmt700.oracle.com [141.146.40.70]) by rgminet15.oracle.com (Switch-3.3.1/Switch-3.3.1) with ESMTP id n1KK1S2j029399 for ; Fri, 20 Feb 2009 20:01:29 GMT Original-Received: from dradamslap1 (/24.5.128.33) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 20 Feb 2009 12:01:25 -0800 X-Mailer: Microsoft Office Outlook 11 Thread-Index: AcmTlgTlM4Ywfk6oRceJo/Ce3dy/dA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.3350 X-Source-IP: acsmt700.oracle.com [141.146.40.70] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A09020B.499F0C17.0307:SCFSTAT928724,ss=1,fgs=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) Resent-Date: Fri, 20 Feb 2009 15:23:39 -0500 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:25522 gmane.emacs.pretest.bugs:23955 Archived-At: Enhancement request: `minibuffer-default-add-shell-commands' should add to the minibuffer defaults list not only the commands determined by MIME type (which it does now, using `mailcap-file-default-commands'), but also the commands determined by `dired-guess-default'. `dired-guess-default' is defined in dired-x.el, but it has nothing to do with Dired, AFAICT, so there is no reason that it should not be available (and used) generally. And variables `dired-guess-shell-alist-user' and `dired-guess-shell-alist-default' should also be factored out of dired-x.el. They too are not Dired-related, AFAICT. It is true that the default value of `dired-guess-shell-alist-default' is computed using some variables, such as `dired-guess-shell-gnutar', that are defined in dired-x.el. However, those parts of the value could be picked up dynamically and conditionally instead. Or, if they too are not Dired-related, they could be moved elsewhere and made available generally. Note, BTW, that dired-x.el already uses `minibuffer-default-add-shell-commands' in `dired-smart-shell-command' (in dired-x.el). It makes no sense that only the MIME types be used to come up with defaults, and not also `dired-guess-default', in the very library that defines `dired-guess-default'! My guess is that someone just updated `dired-smart-shell-command' for Emacs 23 mechanically, without thinking about the commands provided by `dired-guess-default'. IOW, it was a mechanical substitution of the same diff that was used to update `read-shell-command'. The idea behind this enhancement request is that there is no reason that `minibuffer-default-add-shell-commands' should not benefit also from the candidate commands defined by these alists. In GNU Emacs 23.0.90.1 (i386-mingw-nt5.1.2600) of 2009-02-01 on SOFT-MJASON Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4)'