From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: skykanin via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61312: Patch for eglot: scala LSP binary name Date: Sun, 05 Feb 2023 21:15:48 +0000 Message-ID: <-edmUJ29wZgHuAqckk1IXW8s3dBmAtrNRbO2nUbic7v2H38NPWS7HJIPpdeI1A-zvKlqRJ7LegKJ8HLszMHggEcWkVBu_z72mfmMBH3TwNg=@proton.me> Reply-To: skykanin Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32473"; mail-complaints-to="usenet@ciao.gmane.io" To: 61312@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Feb 06 06:52:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pOuQc-0008IR-3L for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Feb 2023 06:52:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pOuQA-0001VT-6H; Mon, 06 Feb 2023 00:52:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOuQ6-0001Un-SL for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 00:52:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pOuQ6-0004M2-HE for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 00:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pOuQ6-0003fR-DS for bug-gnu-emacs@gnu.org; Mon, 06 Feb 2023 00:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: skykanin Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Feb 2023 05:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 61312 X-GNU-PR-Package: emacs X-Debbugs-Original-To: "bug-gnu-emacs@gnu.org" Original-Received: via spool by submit@debbugs.gnu.org id=B.167566270214036 (code B ref -1); Mon, 06 Feb 2023 05:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Feb 2023 05:51:42 +0000 Original-Received: from localhost ([127.0.0.1]:47193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOuPl-0003eD-I8 for submit@debbugs.gnu.org; Mon, 06 Feb 2023 00:51:42 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:44504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pOmMt-0000BA-Sh for submit@debbugs.gnu.org; Sun, 05 Feb 2023 16:16:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOmMt-0001Uh-Gf for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:16:11 -0500 Original-Received: from mail-40138.protonmail.ch ([185.70.40.138]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pOmMm-0001y5-LR for bug-gnu-emacs@gnu.org; Sun, 05 Feb 2023 16:16:10 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proton.me; s=protonmail; t=1675631753; x=1675890953; bh=lBELv8IVVzkJLwDh4bQ50SUpGJq0x46p7cTeEut5OSw=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=Rg94/eJmXNkBlqnMqlPX7VXEVuneF3wBbAMDB//Wg7JLP8u4hstSE6Uhi9GB9NzRI aASAMbt7WJnqcWhewPg3p1Nwk6xqfONu6MYJ65MJts0VuHPsU8iQdHMGKgqJ8+ntTJ iksMrsfS7C6kU7qIP7OoEBji/dJ2mq6A9b+OsQTlehkaUSXFc4iXtT4RMQH1YERT4u ixyZmumpUEHf9dwpb7e/UNF0fWQSEzCW88N4VGMuN7NaFFx/BXB/pH8XYjAdEBmheS aokw4T7th+pA2eXCK0SsNHXslgCS7ni2j4bcXbrIM4HcM4pOAG/7e56Bq4/Sbyi2q3 i2eXUqjm3XQpg== Feedback-ID: 66914596:user:proton Received-SPF: pass client-ip=185.70.40.138; envelope-from=skykanin@proton.me; helo=mail-40138.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Mon, 06 Feb 2023 00:51:39 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254936 Archived-At: This is a multi-part message in MIME format. --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hello, It seems that eglot expects the scala metals LSP server binary to be named = `metals-emacs` instead of `metals`. The included patch fixes this behaviour= . At least in the nix package manager the `metals` binary is simply call 'm= etals'. However if other package managers distribute an alias for the binar= y as 'metals-emacs' as well we could instead do something like: ``` (scala-mode . ,(eglot-alternatives '("metals" "metals-emacs")) ``` --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA Content-Type: text/x-patch; name=0001-Patch-eglot-scala-LSP-server-binary-name.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-Patch-eglot-scala-LSP-server-binary-name.patch RnJvbSAyMTVkNTRmZjVlZTMzNTJiY2RhMDFkODhkN2ExNjc5MjVjZDhkYmViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBza3lrYW5pbiA8Mzc4OTc2NCtza3lrYW5pbkB1c2Vycy5ub3Jl cGx5LmdpdGh1Yi5jb20+CkRhdGU6IFN1biwgNSBGZWIgMjAyMyAyMTo0MToxOSArMDEwMApTdWJq ZWN0OiBbUEFUQ0hdIFBhdGNoIGVnbG90IHNjYWxhIExTUCBzZXJ2ZXIgYmluYXJ5IG5hbWUKCkVu c3VyZSB0aGF0IGVnbG90IHBpY2tzIHVwIHRoZSBjb3JyZWN0CmJpbmFyeSBuYW1lIGZvciB0aGUg c2NhbGEgbWV0YWxzIExTUCBzZXJ2ZXIuCi0tLQogbGlzcC9wcm9nbW9kZXMvZWdsb3QuZWwgfCAy ICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYg LS1naXQgYS9saXNwL3Byb2dtb2Rlcy9lZ2xvdC5lbCBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVs CmluZGV4IDRmYTg4NmJjNzguLmNhMDI1Y2Y3ZDggMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVz L2VnbG90LmVsCisrKyBiL2xpc3AvcHJvZ21vZGVzL2VnbG90LmVsCkBAIC0yMjEsNyArMjIxLDcg QEAgY2hvc2VuIChpbnRlcmFjdGl2ZWx5IG9yIGF1dG9tYXRpY2FsbHkpLiIKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiLS1jbGllbnQtaWQiICJlbWFjcy5l Z2xvdC1kYXJ0IikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChlbGl4aXItbW9k ZSAuICgibGFuZ3VhZ2Vfc2VydmVyLnNoIikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIChhZGEtbW9kZSAuICgiYWRhX2xhbmd1YWdlX3NlcnZlciIpKQotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAoc2NhbGEtbW9kZSAuICgibWV0YWxzLWVtYWNzIikpCisgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIChzY2FsYS1tb2RlIC4gKCJtZXRhbHMiKSkKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHJhY2tldC1tb2RlIC4gKCJyYWNrZXQiICItbCIg InJhY2tldC1sYW5nc2VydmVyIikpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgo dGV4LW1vZGUgY29udGV4dC1tb2RlIHRleGluZm8tbW9kZSBiaWJ0ZXgtbW9kZSkKICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIC4gLChlZ2xvdC1hbHRlcm5hdGl2ZXMgJygiZGlnZXN0 aWYiICJ0ZXhsYWIiKSkpCi0tIAoyLjM5LjAKCg== --b1_zaBX4M70YH0qWDkx6tsCLrW2YjKjdJ3S3JQNboSNA--