From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Randy Taylor Newsgroups: gmane.emacs.bugs Subject: bug#74461: [PATCH] Add go-work-ts-mode Date: Sun, 01 Dec 2024 20:42:55 +0000 Message-ID: <-9CYv1jXFzOpWe6WlJ_GVtAFtexLt4j0Jt62SEVC1ZGfDVmnzJSSGXQRqm2n47k9r1rLrCdBdaXxf9QEjXrQUSDFhT1iXyHqgYHmAy9t0Uc=@rjt.dev> References: <87ttbzd16p.fsf@disroot.org> <86jzcl81py.fsf@gnu.org> <877c8l55he.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6514"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 74461@debbugs.gnu.org To: Gabriel Santos Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 01 21:44:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tHqnm-0001ZB-PN for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Dec 2024 21:44:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tHqnT-0007Ar-H8; Sun, 01 Dec 2024 15:44:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tHqnS-0007Ac-Az for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 15:44:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tHqnR-0008NZ-SU for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 15:44:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=npiRvSCKK4DcQr3480et52+ab/Gz6FPAq1Shx4J7HBU=; b=R8DxiLgBjqZSfO1qvocefxgvu1JVgVdwF6RvsZS8d56dEhvVxbZFf+CQAk7xaPKl/l3sXhJ+DpzkZwT58WIzi5WWpFWpdWjzNQX74DFIMjw4AC0FI+4GnjDN1EV+j44ddrkJ2oXdQli6Oaryrz3uynngrD2L4WAIodW4q4QX5y6N/BwEF0RMWE9osLeH01Kaju9dc/cX90imkqzosY/RmI7JcHbMk/XPLu5QfJ7F/Qq7HdVImiY4mbKLdSEtqwrqck9cSh0jTd1w6EPEnHtdxsZyA/WxozRH+00h7eh8i7NF1r4x7XT++abbOlp9a/sq2FfiFd5EiYYtt1c5AwlHVA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tHqnR-0007Un-ND for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2024 15:44:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Dec 2024 20:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74461-submit@debbugs.gnu.org id=B74461.173308579028725 (code B ref 74461); Sun, 01 Dec 2024 20:44:01 +0000 Original-Received: (at 74461) by debbugs.gnu.org; 1 Dec 2024 20:43:10 +0000 Original-Received: from localhost ([127.0.0.1]:53213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHqmb-0007TF-PE for submit@debbugs.gnu.org; Sun, 01 Dec 2024 15:43:10 -0500 Original-Received: from mail-10625.protonmail.ch ([79.135.106.25]:33409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tHqmZ-0007SZ-7i for 74461@debbugs.gnu.org; Sun, 01 Dec 2024 15:43:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1733085779; x=1733344979; bh=npiRvSCKK4DcQr3480et52+ab/Gz6FPAq1Shx4J7HBU=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=Iq7hmxOB81t6valjXS6uQYyaQjdVdCCtpq3pogz1a5f7hdTVbenUGWNLsNnUU3GWl J0mcL+FNeXkNLUd1r8OmuoZHplsDhRbT5ZDcF1bIAfvqejxq5O+meVXCmzrrkhEpMc 5lak/X45QuNqQczjVqMNg1WsjQ3O8X7exeDx5ey0NwLIKZO7UGz+FTU33qX08yv/3f BqnbcdbJ9bYs8yCBdnKUl4MxYUI9wfc40lRb1qCGVxZwFOPQP/9hUqOvZIGpzTBBCx Amp7SWismUeWIfQJDjzmulkmKUAKHwiaKSWlU4/LW/kHwL85JZ7MZ3R81P0HWV1ZCP WPOmT08SY89UA== In-Reply-To: <877c8l55he.fsf@disroot.org> Feedback-ID: 44397038:user:proton X-Pm-Message-ID: 4fe027a4dbc988e8bf983fe8694496701f7e380e X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296279 Archived-At: On Saturday, November 30th, 2024 at 06:24, Gabriel Santos wrote: > > The only comment I have is that for the commit log message: >=20 > > > * lisp/progmodes/go-ts-mode: Add go-work-ts-mode for working with > > > workspace files. > > > * lisp/progmodes/go-ts-mode: Add the repositories for the grammars to > > > the commentary section. > > > * lisp/progmodes/go-ts-mode (go-mod-ts-mode--in-directive-p): Be more > > > specific on the directive location. > >=20 > > These should mention the file name only once, and they all should > > mention the names of functions/variables where the changes were made. > > For new functions, just list them and say "New functions." > >=20 > > Also, the lines in the log message are too long: they should > > preferably be at most 64 columns, and never more than 70. >=20 >=20 > Thanks, got it, I broke down some of the lines, > longest one is at 54 columns. > Both vc and Magit have functions for adding logs to commits, > really useful: >=20 > - log-edit-generate-changelog-from-diff > - magit-commit-add-log >=20 > > How is your copyright assignment paperwork going? I don't think I saw > > any responses from the FSF copyright clerk; if more than 2 weeks have > > passed since you emailed the assignment form, please ping them and CC > > me. >=20 >=20 > It has been a week since my first e-mail, > and five days since the second one. > I'll add a agenda entry for this to ping and CC you at 2024-12-09 > (2 weeks and 2 days since the first e-mail). >=20 > > Thanks. >=20 >=20 > My pleasure, wouldn't be able to contribute to this great software > without all of the previous work of you and other maintainers and > contributors. Thanks for working on this! The patch looks good to me.